From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@kernel.org, disgoel@linux.vnet.ibm.com
Cc: mpe@ellerman.id.au, linux-perf-users@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, maddy@linux.vnet.ibm.com,
rnsastry@linux.ibm.com, kjain@linux.ibm.com, irogers@google.com
Subject: [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries
Date: Thu, 5 May 2022 15:09:58 +0530 [thread overview]
Message-ID: <20220505094000.58220-1-atrajeev@linux.vnet.ibm.com> (raw)
The session topology test fails in powerpc pSeries platform.
Test logs:
<<>>
Session topology : FAILED!
<<>>
This test uses cpu topology information and in powerpc,
some of the topology info is restricted in environment
like virtualized platform. Hence this test needs to be
skipped in pSeries platform for powerpc. The information
about platform is available in /proc/cpuinfo.
Patch 1 adds generic utility function in "util/header.c"
to read /proc/cpuinfo for any entry. Though the testcase
fix needs value from "platform" entry, making this as a
generic function to return value for any entry from the
/proc/cpuinfo file which can be used commonly in future
usecases.
Patch 2 uses the newly added utility function to look for
platform and skip the test in pSeries platform for powerpc.
Athira Rajeev (2):
tools/perf: Add utility function to read /proc/cpuinfo for any field
tools/perf/tests: Fix session topology test to skip the test in guest
environment
Changelog:
V1 -> v2:
Addressed review comments from Kajol.
Use "strim" to remove space from string. Also
use "feof" to check for EOF instead of using new
variable "ret".
tools/perf/tests/topology.c | 17 ++++++++++++
tools/perf/util/header.c | 53 +++++++++++++++++++++++++++++++++++++
tools/perf/util/header.h | 1 +
3 files changed, 71 insertions(+)
--
2.35.1
next reply other threads:[~2022-05-05 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 9:39 Athira Rajeev [this message]
2022-05-05 9:39 ` [PATCH V2 1/2] tools/perf: Add utility function to read /proc/cpuinfo for any field Athira Rajeev
2022-05-05 17:24 ` Arnaldo Carvalho de Melo
2022-05-06 9:33 ` Athira Rajeev
2022-05-10 13:38 ` Athira Rajeev
2022-05-10 17:08 ` Arnaldo Carvalho de Melo
2022-05-05 9:40 ` [PATCH V2 2/2] tools/perf/tests: Fix session topology test to skip the test in guest environment Athira Rajeev
2022-05-06 2:40 ` Michael Ellerman
2022-05-05 10:52 ` [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505094000.58220-1-atrajeev@linux.vnet.ibm.com \
--to=atrajeev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=rnsastry@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).