From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Riccardo Mancini <rickyman7@gmail.com>,
Kim Phillips <kim.phillips@amd.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Shunsuke Nakamura <nakamura.shun@fujitsu.com>,
Florian Fischer <florian.fischer@muhq.space>,
Andi Kleen <ak@linux.intel.com>,
John Garry <john.garry@huawei.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@arm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v2 0/2] Fix topdown event weak grouping
Date: Wed, 11 May 2022 23:13:06 -0700 [thread overview]
Message-ID: <20220512061308.1152233-1-irogers@google.com> (raw)
Keep topdown events within a group when a weak group is broken. This
is a requirement as topdown events must form a group.
Add perf stat testing including for required topdown event group
behaviors.
Note: as with existing topdown evsel/evlist code topdown events are
assumed to be on the PMU "cpu". On Alderlake the PMU "cpu_core" should
also be tested. Future changes can fix Alderlake.
v2. Correct behavior wrt pmu prefixed events and avoid the test using
deprecated events: Suggested-by: Liang, Kan <kan.liang@linux.intel.com>
Ian Rogers (2):
perf evlist: Keep topdown counters in weak group
perf test: Add basic stat and topdown group test
tools/perf/arch/x86/util/evsel.c | 12 ++++++
tools/perf/tests/shell/stat.sh | 67 ++++++++++++++++++++++++++++++++
tools/perf/util/evlist.c | 16 +++++++-
tools/perf/util/evsel.c | 10 +++++
tools/perf/util/evsel.h | 3 ++
5 files changed, 106 insertions(+), 2 deletions(-)
create mode 100755 tools/perf/tests/shell/stat.sh
--
2.36.0.512.ge40c2bad7a-goog
next reply other threads:[~2022-05-12 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 6:13 Ian Rogers [this message]
2022-05-12 6:13 ` [PATCH v2 1/2] perf evlist: Keep topdown counters in weak group Ian Rogers
2022-05-12 6:13 ` [PATCH v2 2/2] perf test: Add basic stat and topdown group test Ian Rogers
2022-05-13 14:25 ` [PATCH v2 0/2] Fix topdown event weak grouping Liang, Kan
2022-05-13 15:18 ` Ian Rogers
2022-05-13 15:19 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512061308.1152233-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nakamura.shun@fujitsu.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).