From: Leo Yan <leo.yan@linaro.org>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
James Clark <james.clark@arm.com>,
German Gomez <german.gomez@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Eelco Chaudron <echaudro@redhat.com>,
Stephen Brennan <stephen.s.brennan@oracle.com>,
Tanmay Jagdale <tanmay@marvell.com>,
"zengshun . wu" <zengshun.wu@outlook.com>,
Al Grant <al.grant@arm.com>,
coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, Tor Jeremiassen <tor@ti.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v5 2/2] perf scripts python: Support Arm CoreSight trace data disassembly
Date: Mon, 16 May 2022 09:21:21 +0800 [thread overview]
Message-ID: <20220516012121.GA56920@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <CAP-5=fWx1ODacj2H--uH53j-jvcrTUJF2KwAyD65uU34kHYQfg@mail.gmail.com>
On Sun, May 15, 2022 at 02:18:53PM -0700, Ian Rogers wrote:
[...]
> This looks good to me and will run on python 2. The code would be more
> idiomatic in python3 using f-strings. I'd rather the code was
> idiomatic from the beginning, but others may disagree and prefer
> python 2 compatibility (python 2 is now end of life). f-strings are
> python 3.6+ and so have been supported for 5 years.
Using f-string is the right thing for me, will update.
Thanks for reviewing and suggestion!
Leo
prev parent reply other threads:[~2022-05-16 1:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 7:18 [PATCH v5 0/2] perf script python: Add script for CoreSight disassembly Leo Yan
2022-05-15 7:18 ` [PATCH v5 1/2] perf scripting python: Expose dso and map information Leo Yan
2022-05-16 6:51 ` Adrian Hunter
2022-05-15 7:18 ` [PATCH v5 2/2] perf scripts python: Support Arm CoreSight trace data disassembly Leo Yan
2022-05-15 21:18 ` Ian Rogers
2022-05-16 1:21 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516012121.GA56920@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=echaudro@redhat.com \
--cc=german.gomez@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=stephen.s.brennan@oracle.com \
--cc=tanmay@marvell.com \
--cc=tor@ti.com \
--cc=zengshun.wu@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox