From: Ian Rogers <irogers@google.com>
To: Michael Petlan <mpetlan@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, James Clark <james.clark@arm.com>,
Kan Liang <kan.liang@linux.intel.com>,
Quentin Monnet <quentin@isovalent.com>,
Dave Marchevsky <davemarchevsky@fb.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Lv Ruyi <lv.ruyi@zte.com.cn>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH 0/5] perf_counts clean up and perf stat report bug fix
Date: Wed, 18 May 2022 20:20:00 -0700 [thread overview]
Message-ID: <20220519032005.1273691-1-irogers@google.com> (raw)
perf_counts takes a CPU map index as an argument, however, there were
a few places where this hadn't been cleaned up and the index was
called cpu. In part this led to the bug discovered by Michael Petlan in:
https://lore.kernel.org/linux-perf-users/CAP-5=fWQR=sCuiSMktvUtcbOLidEpUJLCybVF6=BRvORcDOq+g@mail.gmail.com/
Fix the bug, tidy up more of the arguments passed to perf_counts, add
a test to ensure the bug isn't reintroduced and add a helper macro to
iterate over just CPU map indices.
Ian Rogers (5):
perf stat: Fix and validate inputs in stat events
perf stat: Add stat record+report test
perf cpumap: Add perf_cpu_map__for_each_idx
perf bpf_counter: Tidy use of CPU map index
perf stat: Make use of index clearer with perf_counts
tools/lib/perf/include/perf/cpumap.h | 3 ++
tools/perf/tests/shell/stat.sh | 13 ++++++
tools/perf/util/bpf_counter.c | 61 ++++++++++++++++------------
tools/perf/util/stat-display.c | 22 +++++-----
tools/perf/util/stat.c | 27 ++++++++----
5 files changed, 81 insertions(+), 45 deletions(-)
--
2.36.1.124.g0e6072fb45-goog
next reply other threads:[~2022-05-19 3:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 3:20 Ian Rogers [this message]
2022-05-19 3:20 ` [PATCH 1/5] perf stat: Fix and validate inputs in stat events Ian Rogers
2022-05-19 3:20 ` [PATCH 2/5] perf stat: Add stat record+report test Ian Rogers
2022-05-19 3:20 ` [PATCH 3/5] perf cpumap: Add perf_cpu_map__for_each_idx Ian Rogers
2022-05-19 3:20 ` [PATCH 4/5] perf bpf_counter: Tidy use of CPU map index Ian Rogers
2022-05-19 3:20 ` [PATCH 5/5] perf stat: Make use of index clearer with perf_counts Ian Rogers
2022-05-23 12:54 ` [PATCH 0/5] perf_counts clean up and perf stat report bug fix Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519032005.1273691-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=eranian@google.com \
--cc=james.clark@arm.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kan.liang@linux.intel.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).