From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC08FC433EF for ; Thu, 26 May 2022 14:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237322AbiEZOzw (ORCPT ); Thu, 26 May 2022 10:55:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232164AbiEZOzu (ORCPT ); Thu, 26 May 2022 10:55:50 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A71A62CD4 for ; Thu, 26 May 2022 07:55:47 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id m1so1651302plx.3 for ; Thu, 26 May 2022 07:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j5JOHDXUI7FQ8JXc4lii8SXeiFfUzVXvQhcvWoaLXbY=; b=wvUwJIxJ8EzyTbR5AOM0+Jfw4VwKYsR8I2VaYthXdLN6jgv9f438bZevsDXKds0eTM 8OUkxIKITmmEyRQtAL1U09ntB0NEjP9OCO9oLzLx64aV3B/2sH1CzofNMwwnsKqA8lZ3 4cE4aIvo4MBVN6bqDiQBOL6sNPShYPnoqgG9E6XyqSCPk7O20+shJJ/hWW7tSReJWXDx zM1lx/5tmTeEmfXaZ9q/Cexu7b+6EcY15O1KfiDdlQEB4L5Msn70IKkjuSosuCtreX5q Kvl279/jNPkDPQd8OcAFkP0/jxX/PNo6il3VdB6FwDrkETaWNwnYg4hvGnTD7pmccTnr O/WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j5JOHDXUI7FQ8JXc4lii8SXeiFfUzVXvQhcvWoaLXbY=; b=WWvXAHjRmMZUDDagT32g92teULfAUVKPatstrxjS1oOHNn+xAtSB7ugaqhNAEo66Jw QpavKW6I/Z6zM5wcDdpw38qEYS9yF8p2i9q2IR9JU1NeaTDaAHIUK4anZpAdvpYK6nVe 6PE4LBRTd6sACF5UIomTGHZWhJlBfnRS3I/jRl1noQhOW9OU5EdpUDwc2VS4mCd9I2RU idWHJpdbre1lZMBOhOzoIsdZjX8kz7DV0tesE4EZlE+08olPT4r5CHPFcYoqZlYPkmmT C2DirQ8zspTJJNbOVmT8PqHG18pVjvy/AUdMLgto61iItcNBSRSMd6gaaKAlfCUzEzt6 5+2A== X-Gm-Message-State: AOAM531UErEPZYgoTj8JKhS6uvQdYmF8zS11/M3778pzklSknn4HEoxw mvIU9kwgWQKkZxoiEeh0aKyNQQ== X-Google-Smtp-Source: ABdhPJxkxE65mjMHVy0QbdI+2D7itKo338sypKD5ahEJqg2dVLkjkGQeaDMhsHUj+4CTX6Uat3Orcw== X-Received: by 2002:a17:903:244c:b0:162:4b19:a0e7 with SMTP id l12-20020a170903244c00b001624b19a0e7mr12637690pls.44.1653576947031; Thu, 26 May 2022 07:55:47 -0700 (PDT) Received: from leoy-ThinkPad-X240s (n058152048195.netvigator.com. [58.152.48.195]) by smtp.gmail.com with ESMTPSA id j2-20020a17090a2a8200b001d92e2e5694sm3875763pjd.1.2022.05.26.07.55.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 07:55:46 -0700 (PDT) Date: Thu, 26 May 2022 22:55:40 +0800 From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Joe Mario , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] perf c2c: Use stdio interface if slang is not supported Message-ID: <20220526145540.GD795802@leoy-ThinkPad-X240s> References: <20220526143917.607928-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526143917.607928-1-leo.yan@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Thu, May 26, 2022 at 10:39:17PM +0800, Leo Yan wrote: > If slang lib is not installed on the system, perf c2c tool disables > TUI mode and roll back to use stdio mode; but the flag 'c2c.use_stdio' > is missed to set true and thus it wrongly applies UI quirks in the > function ui_quirks(). Have sent out v2 for adding fixes and reported tags. Sorry for spamming. Leo