From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4F0C433EF for ; Fri, 3 Jun 2022 03:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbiFCDhJ (ORCPT ); Thu, 2 Jun 2022 23:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbiFCDhH (ORCPT ); Thu, 2 Jun 2022 23:37:07 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AE3760EF for ; Thu, 2 Jun 2022 20:37:06 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id u4so3323424pgk.11 for ; Thu, 02 Jun 2022 20:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8NU2H/rGkzMEGnRhbeP8HcREPvdELz1mjoNpn1J8y28=; b=G5hjpbI7XV6h8rDNmIjZ3hqDfqAkjgI23LJF2iF9Be0olDOfWL9wJpH7ZNZ2WsHoJk +hSDFHSQ92r9u0M2Dch9H5yDGFXl1018AxFQlc7uf6ivvYzp73997ibMFQpQXdODhvDU SmSbCmCc0HydGfuwe92D+n7Qix74SKPAtHSaWkJAuyGOBn7ah3+2Ad2iOzDy0gSxRmdS UY3rGOn9FYQt/MrOLqTpckQDklqFMNXx1b6/0SblGFKTBBPR1roaGarjTmVOTMvdSD+1 N9ascL1nb9KOHUOtoJsWmApn3TRZYZqbgzm+1sekoP3HvbGS3ykPKPNDG6WruQ0+MV5v zE7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8NU2H/rGkzMEGnRhbeP8HcREPvdELz1mjoNpn1J8y28=; b=d6YJb28JmrDYRaCMSERQ34khVgrMWT8plZab+NWru3DxNVZ6xrAWa3vLXdrkomfhGc wc/yRkhAwjI/RIKCCIAwCT+ie8lnvH4XpzrPmhOA2fhx24J5cqVAPjpk2LPK+EZQFKQL LtAWkhzmltVNwj5hNS6OCmqdW/EMAyqsAtvWOiCMoaOt9IHarbOJLjQCsHGYp3pl/fNT zg6WpcfEm1tw8V/iGF62QFPd+vy9NJQ01rzkNdTyF6yKlH6ShqEmu75FfcJfYB5+qSfu eDPuedpruyt+nfnal2HQTWCKyQEurekU9dTOfVQA8SwymYS050Q/Ck2Os7owXIYUbbPi /KCw== X-Gm-Message-State: AOAM531V1v1hPDuYMBVJ+kmVSvteBTd2qb+PzxHBIQbrhEmtrJ2IwE09 e9QJIQi5ZqpaH0VkgW1ajFo9RQ== X-Google-Smtp-Source: ABdhPJzMsOrexH9kVH+VLEwd+tYMcu34iM1PfCuW82bxkvjyz1uRPfZZ/PhcVkUAaPMsjb39aXLaHQ== X-Received: by 2002:a62:d045:0:b0:518:404d:9dc8 with SMTP id p66-20020a62d045000000b00518404d9dc8mr8346001pfg.60.1654227425535; Thu, 02 Jun 2022 20:37:05 -0700 (PDT) Received: from leoy-ThinkPad-X240s (ec2-54-67-95-58.us-west-1.compute.amazonaws.com. [54.67.95.58]) by smtp.gmail.com with ESMTPSA id u6-20020a170902714600b0015e8e7db067sm4271349plm.4.2022.06.02.20.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 20:37:05 -0700 (PDT) Date: Fri, 3 Jun 2022 11:36:57 +0800 From: Leo Yan To: Ian Rogers Cc: Joe Mario , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alyssa Ross , Like Xu , Kajol Jain , Li Huafei , Adam Li , German Gomez , James Clark , Ali Saidi , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/12] perf c2c: Support display for Arm64 Message-ID: <20220603033657.GA41034@leoy-ThinkPad-X240s> References: <20220530114036.3225544-1-leo.yan@linaro.org> <57a826ad-5ceb-ba1d-b80c-452f72720889@redhat.com> <20220601102505.GA408721@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi Ian, On Thu, Jun 02, 2022 at 09:59:29AM -0700, Ian Rogers wrote: [...] > This is great Leo! I've not been able to test the changes but I didn't > have any coding comments (happy to give an Acked-by). Do you think we > can add a test for this? The test can skip when c2c isn't supported. It would be great if recieve your ACK tags :) Yeah, agree that it's good thing to add test for perf c2c. Just note, after rough thinkіng, seems to me the right thing to do is to add a testing shell script in the folder tests/shell and use a tiny multi-threading program for accessing the share cache line from different nodes (or rollback to different CPUs). I would like to use a separate patch for adding the test case, this would be easier for upstreaming current patch set. Please let me know if this is fine for you or not. Thanks for reviewing and suggestions! Leo