From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Kajol Jain <kjain@linux.ibm.com>, Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Rob Herring <robh@kernel.org>
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH 0/4] Tidy user rdpmc documentation and testing
Date: Wed, 8 Jun 2022 15:43:49 -0700 [thread overview]
Message-ID: <20220608224353.1176079-1-irogers@google.com> (raw)
libperf's perf_mmap__read_self and the addition of arm64 support mean
that the perf_event.h and the rdpmc perf test have become
stale. Refresh the documentation in perf_event.h, remove the x86 rdpmc
test and port the libperf test as a non-architecture specific test.
Address sanitizer testing showed libperf leaking fds when the
perf_event_open failed, add error paths to handle this.
A comment is added to perf_event.h to avoid a divide by zero when
scaling counts if the running time is 0. This was previously discussed
in this thread:
https://lore.kernel.org/lkml/CAP-5=fVRdqvswtyQMg5cB+ntTGda+SAYskjTQednEH-AeZo13g@mail.gmail.com/
Ian Rogers (4):
libperf evsel: Open shouldn't leak fd on failure
perf: Align user space counter reading with code
perf test: Remove x86 rdpmc test
perf test: Add user space counter reading tests
include/uapi/linux/perf_event.h | 32 +++--
tools/include/uapi/linux/perf_event.h | 32 +++--
tools/lib/perf/evsel.c | 17 ++-
tools/perf/arch/x86/tests/Build | 1 -
tools/perf/arch/x86/tests/arch-tests.c | 2 -
tools/perf/arch/x86/tests/rdpmc.c | 182 -------------------------
tools/perf/tests/mmap-basic.c | 128 ++++++++++++++++-
7 files changed, 177 insertions(+), 217 deletions(-)
delete mode 100644 tools/perf/arch/x86/tests/rdpmc.c
--
2.36.1.255.ge46751e96f-goog
next reply other threads:[~2022-06-08 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 22:43 Ian Rogers [this message]
2022-06-08 22:43 ` [PATCH 1/4] libperf evsel: Open shouldn't leak fd on failure Ian Rogers
2022-06-09 16:47 ` Arnaldo Carvalho de Melo
2022-06-08 22:43 ` [PATCH 2/4] perf: Align user space counter reading with code Ian Rogers
2022-06-08 23:24 ` Rob Herring
2022-06-09 0:07 ` Ian Rogers
2022-06-08 22:43 ` [PATCH 3/4] perf test: Remove x86 rdpmc test Ian Rogers
2022-06-08 23:29 ` Rob Herring
2022-06-08 23:30 ` Rob Herring
2022-06-08 22:43 ` [PATCH 4/4] perf test: Add user space counter reading tests Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608224353.1176079-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).