Re: [PATCH] perf test: Record only user callchains

[Leo Yan <leo.yan@linaro.org>]

On Tue, Jun 14, 2022 at 12:52:07PM +0200, Michael Petlan wrote:
> The testcase 'Check Arm64 callgraphs are complete in fp mode' wants to
> see the following output:
> 
>     610 leaf
>     62f parent
>     648 main
> 
> However, without excluding user callchains, the output might look like:
> 	ffffc2ff40ef1b5c arch_local_irq_enable
> 	ffffc2ff419d032c __schedule
> 	ffffc2ff419d06c0 schedule
> 	ffffc2ff40e4da30 do_notify_resume
> 	ffffc2ff40e421b0 work_pending
> 	             610 leaf
> 	             62f parent
> 	             648 main
> 
> Adding '--user-callchains' leaves only the wanted symbols in the chain.
> 
> Suggested-by: German Gomez <german.gomez@arm.com>
> Tested-by: Michael Petlan <mpetlan@redhat.com>

Since you are the patch's author, it's not necessary to add your
tested tag.

> Signed-off-by: Michael Petlan <mpetlan@redhat.com>

With addressing German's comment for "excluding kernel callchains":

Reviewed-by: Leo Yan <leo.yan@linaro.org>

> ---
>  tools/perf/tests/shell/test_arm_callgraph_fp.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> index 6ffbb27afaba..ec108d45d3c6 100755
> --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> @@ -43,7 +43,7 @@ CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
>  cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
>  
>  # Add a 1 second delay to skip samples that are not in the leaf() function
> -perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 -- $TEST_PROGRAM 2> /dev/null &
> +perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
>  PID=$!
>  
>  echo " + Recording (PID=$PID)..."
> -- 
> 2.18.4
>