linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
	James Clark <james.clark@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	Kajol Jain <kjain@linux.ibm.com>, Ali Saidi <alisaidi@amazon.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Ian Rogers <irogers@google.com>, Like Xu <likexu@tencent.com>,
	German Gomez <german.gomez@arm.com>,
	Timothy Hayes <timothy.hayes@arm.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v6 06/15] perf c2c: Add dimensions for peer load operations
Date: Thu, 11 Aug 2022 14:24:42 +0800	[thread overview]
Message-ID: <20220811062451.435810-7-leo.yan@linaro.org> (raw)
In-Reply-To: <20220811062451.435810-1-leo.yan@linaro.org>

This patch adds three dimensions for peer load operations of 'lcl_peer',
'rmt_peer' and 'tot_peer'.  These three dimensions will be used in the
shared data cache line table.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Ian Rogers <irogers@google.com>
Tested-by: Ali Saidi <alisaidi@amazon.com>
Reviewed-by: Ali Saidi <alisaidi@amazon.com>
---
 tools/perf/builtin-c2c.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 37bebeb6c11b..99c0c7307a4a 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -650,6 +650,9 @@ __f ## _cmp(struct perf_hpp_fmt *fmt __maybe_unused,			\
 
 STAT_FN(rmt_hitm)
 STAT_FN(lcl_hitm)
+STAT_FN(rmt_peer)
+STAT_FN(lcl_peer)
+STAT_FN(tot_peer)
 STAT_FN(store)
 STAT_FN(st_l1hit)
 STAT_FN(st_l1miss)
@@ -1360,6 +1363,30 @@ static struct c2c_dimension dim_rmt_hitm = {
 	.width		= 7,
 };
 
+static struct c2c_dimension dim_tot_peer = {
+	.header		= HEADER_SPAN("------- Load Peer -------", "Total", 2),
+	.name		= "tot_peer",
+	.cmp		= tot_peer_cmp,
+	.entry		= tot_peer_entry,
+	.width		= 7,
+};
+
+static struct c2c_dimension dim_lcl_peer = {
+	.header		= HEADER_SPAN_LOW("Local"),
+	.name		= "lcl_peer",
+	.cmp		= lcl_peer_cmp,
+	.entry		= lcl_peer_entry,
+	.width		= 7,
+};
+
+static struct c2c_dimension dim_rmt_peer = {
+	.header		= HEADER_SPAN_LOW("Remote"),
+	.name		= "rmt_peer",
+	.cmp		= rmt_peer_cmp,
+	.entry		= rmt_peer_entry,
+	.width		= 7,
+};
+
 static struct c2c_dimension dim_cl_rmt_hitm = {
 	.header		= HEADER_SPAN("----- HITM -----", "Rmt", 1),
 	.name		= "cl_rmt_hitm",
@@ -1672,6 +1699,9 @@ static struct c2c_dimension *dimensions[] = {
 	&dim_tot_hitm,
 	&dim_lcl_hitm,
 	&dim_rmt_hitm,
+	&dim_tot_peer,
+	&dim_lcl_peer,
+	&dim_rmt_peer,
 	&dim_cl_lcl_hitm,
 	&dim_cl_rmt_hitm,
 	&dim_tot_stores,
-- 
2.34.1


  parent reply	other threads:[~2022-08-11  6:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  6:24 [PATCH v6 00/15] perf c2c: Support data source and display for Arm64 Leo Yan
2022-08-11  6:24 ` [PATCH v6 01/15] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Leo Yan
2022-08-11 21:55   ` Arnaldo Carvalho de Melo
2022-08-11  6:24 ` [PATCH v6 02/15] perf mem: Print snoop peer flag Leo Yan
2022-08-11  6:24 ` [PATCH v6 03/15] perf arm-spe: Use SPE data source for neoverse cores Leo Yan
2022-08-11 22:01   ` Arnaldo Carvalho de Melo
2022-08-11  6:24 ` [PATCH v6 04/15] perf mem: Add statistics for peer snooping Leo Yan
2022-08-11  6:24 ` [PATCH v6 05/15] perf c2c: Output " Leo Yan
2022-08-11  6:24 ` Leo Yan [this message]
2022-08-11  6:24 ` [PATCH v6 07/15] perf c2c: Add dimensions of peer metrics for cache line view Leo Yan
2022-08-11  6:24 ` [PATCH v6 08/15] perf c2c: Add mean dimensions for peer operations Leo Yan
2022-08-11  6:24 ` [PATCH v6 09/15] perf c2c: Use explicit names for display macros Leo Yan
2022-08-11  6:24 ` [PATCH v6 10/15] perf c2c: Rename dimension from 'percent_hitm' to 'percent_costly_snoop' Leo Yan
2022-08-11  6:24 ` [PATCH v6 11/15] perf c2c: Refactor node header Leo Yan
2022-08-11  6:24 ` [PATCH v6 12/15] perf c2c: Refactor display string Leo Yan
2022-08-11  6:24 ` [PATCH v6 13/15] perf c2c: Sort on peer snooping for load operations Leo Yan
2022-08-11  6:24 ` [PATCH v6 14/15] perf c2c: Use 'peer' as default display for Arm64 Leo Yan
2022-08-11  6:24 ` [PATCH v6 15/15] perf c2c: Update documentation for new display option 'peer' Leo Yan
2022-08-11 22:25 ` [PATCH v6 00/15] perf c2c: Support data source and display for Arm64 Arnaldo Carvalho de Melo
2022-08-12  1:26   ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811062451.435810-7-leo.yan@linaro.org \
    --to=leo.yan@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alisaidi@amazon.com \
    --cc=anshuman.khandual@arm.com \
    --cc=german.gomez@arm.com \
    --cc=gustavoars@kernel.org \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=kjain@linux.ibm.com \
    --cc=likexu@tencent.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=timothy.hayes@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).