From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6745C25B07 for ; Thu, 11 Aug 2022 06:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234080AbiHKGlc (ORCPT ); Thu, 11 Aug 2022 02:41:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233535AbiHKGlb (ORCPT ); Thu, 11 Aug 2022 02:41:31 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C1C16261 for ; Wed, 10 Aug 2022 23:41:29 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id 130so15691734pfv.13 for ; Wed, 10 Aug 2022 23:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=8Ls4pFvfLJMWwcmLhID1I6I1DLBX05K+UJVFFV9Za6M=; b=vMy0JbabQGaviBO27so/kcHKd/6i1tm8ma6oUqJlmeqnvqIleBB4FN3SZyCTA9oApz JNVMSIbKSiyvqVgKfgwtyb7g072G8H4fScIPRFqpkddCUr04cYfniC5FZ1r/9h4gNa2L jzK2fZVX+eu34dd7p4EjUOlm5GbRQcgAAQ8f5LBgVzVpJ4Bh9OeBEURXBlffgwIDTfC/ 0sbZdEnh3BbofV/dOE/NiLP+0HCBB2k64zNG2AC8CoNKbNMDue3Cjiv6TLFTXVa9duFf VNksgovC8IjiE8CV/i16v4GLtLX4rDL0Cag7P0M/ZTCyRzizPlGJeTmgPEFZHw2Vhnwi 4cOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=8Ls4pFvfLJMWwcmLhID1I6I1DLBX05K+UJVFFV9Za6M=; b=VG5yA4XnsA0boUam6UVgA50ltnNAvcsU80allQYow1n4BnGRQn/R/t+kiXU8ecZKNK gDGjUZFpafeKDbU4SUU9FFf1nvmaeyrWOQ2w5y9ZOz7QZwlg4kiQ8ev/htKm32LF3+qB CyrJWFCybCmURe36IH/coVs6TaqiF3YqMujT52/ASIkQyECqyeC7zUuzp2yuvCWyszx3 YNHHvjcVjkrz1t9TwbjP7oOxIbFyI5kCMvdoqqCeZIO8CuthNghu315Y6tY13gWtqj7X oQKsDuNznAVn/nmqR3/xkPe4cA8YGK/jEgdyb0BQ2NsJdyalFqxIGHctRiLPZzatiP2q fCWg== X-Gm-Message-State: ACgBeo2yjAx0crXyp50JKwUn4CEQ6Tdvaixh/0ieA8Wq65vrQa37jUiZ aYHfKWIo+VY9ilhP6SWFKGek6A== X-Google-Smtp-Source: AA6agR7nKY/UN1mSywz2fbtTnLwsfY0AOBEbt40itndC5bJz8PmSiqPAd8PaShPIGIhT3T81iZYDEw== X-Received: by 2002:a63:4566:0:b0:41d:353:46b4 with SMTP id u38-20020a634566000000b0041d035346b4mr23099189pgk.316.1660200088455; Wed, 10 Aug 2022 23:41:28 -0700 (PDT) Received: from leoy-huanghe.lan (n058152077182.netvigator.com. [58.152.77.182]) by smtp.gmail.com with ESMTPSA id q1-20020a17090a2dc100b001f21f5c81a5sm2795643pjm.19.2022.08.10.23.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 23:41:28 -0700 (PDT) Date: Thu, 11 Aug 2022 14:41:22 +0800 From: Leo Yan To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , Will Deacon , James Clark , German Gomez , Ali Saidi , Joe Mario , Adam Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 00/17] perf c2c: Support data source and display for Arm64 Message-ID: <20220811064122.GA860078@leoy-huanghe.lan> References: <20220604042820.2270916-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Hi Arnaldo, On Wed, Aug 10, 2022 at 10:37:32AM -0300, Arnaldo Carvalho de Melo wrote: > Em Sat, Jun 04, 2022 at 12:28:03PM +0800, Leo Yan escreveu: > > Arm64 Neoverse CPUs supports data source in Arm SPE trace, this allows > > us to detect cache line contention and transfers. > > > > This patch set includes Ali's patch set v9 "perf: arm-spe: Decode SPE > > source and use for perf c2c" [1] and rebased on the latest perf core > > banch with latest commit 1bcca2b1bd67 ("perf vendor events intel: > > Update metrics for Alderlake"). > > > > Patches 01-05 comes from Ali's patch set to support data source for Arm > > SPE for neoverse cores. > > Leo, please remove touching the kernel perf_event.h on the first patch, > I see it doesn't affect the kernel right now as it is done just from > synthesizing perf records from hw trace data, and we haven't received > any review comment from Peter Zijlstra (I think he is in vacations). Done! The new patch set іs in below link, which dropped the patch for kernel perf_event.h: https://lore.kernel.org/lkml/20220811062451.435810-1-leo.yan@linaro.org/ One question: should I later continue to upstream the first patch for syncing the kernel header perf_event.h after Peter.Z comes back? > Also please refresh it: > > ⬢[acme@toolbox perf]$ git am ./v5_20220604_leo_yan_perf_c2c_support_data_source_and_display_for_arm64.mbx > Applying: perf: Add SNOOP_PEER flag to perf mem data struct > Applying: perf tools: sync addition of PERF_MEM_SNOOPX_PEER > Applying: perf mem: Print snoop peer flag > Applying: perf arm-spe: Don't set data source if it's not a memory operation > error: patch failed: tools/perf/util/arm-spe.c:387 > error: tools/perf/util/arm-spe.c: patch does not apply > Patch failed at 0004 perf arm-spe: Don't set data source if it's not a memory operation > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > ⬢[acme@toolbox perf]$ To fix the merging conflict in the new patch set, I also dropped the patch "perf arm-spe: Don't set data source if it's not a memory operation", since this patch has been merged into the mainline kernel. Note, when verified the patch set, I found a compilation error, so I sent a separate patch to fix it: https://lore.kernel.org/lkml/20220811044341.426796-1-leo.yan@linaro.org/ Thanks a lot for continuous tracking this series. Leo