* [PATCH] perf metrics: Variable type completion
@ 2022-08-16 17:38 Xin Gao
2022-08-22 14:15 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Xin Gao @ 2022-08-16 17:38 UTC (permalink / raw)
To: peterz, mingo, acme
Cc: namhyung, irogers, john.garry, linux-perf-users, linux-kernel,
Xin Gao
'unsigned int' is better than 'unsigned'.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index ee8fcfa115e5..8926de9617ef 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -1620,7 +1620,7 @@ int metricgroup__copy_metric_events(struct evlist *evlist, struct cgroup *cgrp,
struct rblist *new_metric_events,
struct rblist *old_metric_events)
{
- unsigned i;
+ unsigned int i;
for (i = 0; i < rblist__nr_entries(old_metric_events); i++) {
struct rb_node *nd;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf metrics: Variable type completion
2022-08-16 17:38 [PATCH] perf metrics: Variable type completion Xin Gao
@ 2022-08-22 14:15 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-08-22 14:15 UTC (permalink / raw)
To: Xin Gao
Cc: peterz, mingo, namhyung, irogers, john.garry, linux-perf-users,
linux-kernel
Em Wed, Aug 17, 2022 at 01:38:04AM +0800, Xin Gao escreveu:
> 'unsigned int' is better than 'unsigned'.
Thanks, applied.
- Arnaldo
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> tools/perf/util/metricgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index ee8fcfa115e5..8926de9617ef 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -1620,7 +1620,7 @@ int metricgroup__copy_metric_events(struct evlist *evlist, struct cgroup *cgrp,
> struct rblist *new_metric_events,
> struct rblist *old_metric_events)
> {
> - unsigned i;
> + unsigned int i;
>
> for (i = 0; i < rblist__nr_entries(old_metric_events); i++) {
> struct rb_node *nd;
> --
> 2.30.2
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-22 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-16 17:38 [PATCH] perf metrics: Variable type completion Xin Gao
2022-08-22 14:15 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).