From: Sean Christopherson <seanjc@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Like Xu <like.xu.linux@gmail.com>
Subject: [PATCH v4 0/5] KVM: x86: Intel LBR related perf cleanups
Date: Thu, 1 Sep 2022 17:32:53 +0000 [thread overview]
Message-ID: <20220901173258.925729-1-seanjc@google.com> (raw)
Fix a bug where KVM incorrectly advertises PMU_CAP_LBR_FMT to userspace if
perf has disabled LBRs, e.g. because probing one or more LBR MSRs during
setup hit a #GP.
The non-KVM patches remove unnecessary stubs and unreachable error paths,
which allows for a cleaner fix for said bug (backporting is unlikely to be
necessary/requested).
v4
- Make vmx_get_perf_capabilities() non-inline to avoid references to
x86_perf_get_lbr() when CPU_SUP_INTEL=n. [kernel test robot]
v3:
- https://lore.kernel.org/all/20220831000051.4015031-1-seanjc@google.com
- Drop patches for bug #1 (already merged).
- Drop misguided "clean up the capability check" patch. [Like]
v2:
- https://lore.kernel.org/all/20220803192658.860033-1-seanjc@google.com
- Add patches to fix bug #2. [Like]
- Add a patch to clean up the capability check.
- Tweak the changelog for the PMU refresh bug fix to call out that
KVM should disallow changing feature MSRs after KVM_RUN. [Like]
v1: https://lore.kernel.org/all/20220727233424.2968356-1-seanjc@google.com
Sean Christopherson (5):
perf/x86/core: Remove unnecessary stubs provided for KVM-only helpers
perf/x86/core: Drop the unnecessary return value from
x86_perf_get_lbr()
KVM: VMX: Move vmx_get_perf_capabilities() definition to vmx.c
KVM: VMX: Fold vmx_supported_debugctl() into vcpu_supported_debugctl()
KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs
arch/x86/events/intel/lbr.c | 6 +---
arch/x86/include/asm/perf_event.h | 55 ++++++++-----------------------
arch/x86/kvm/vmx/capabilities.h | 39 ++--------------------
arch/x86/kvm/vmx/vmx.c | 37 ++++++++++++++++++---
4 files changed, 49 insertions(+), 88 deletions(-)
base-commit: 372d07084593dc7a399bf9bee815711b1fb1bcf2
--
2.37.2.789.g6183377224-goog
next reply other threads:[~2022-09-01 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 17:32 Sean Christopherson [this message]
2022-09-01 17:32 ` [PATCH v4 1/5] perf/x86/core: Remove unnecessary stubs provided for KVM-only helpers Sean Christopherson
2022-09-02 2:39 ` kernel test robot
2022-09-02 2:53 ` kernel test robot
2022-09-02 2:54 ` kernel test robot
2022-09-01 17:32 ` [PATCH v4 2/5] perf/x86/core: Drop the unnecessary return value from x86_perf_get_lbr() Sean Christopherson
2022-09-01 17:32 ` [PATCH v4 3/5] KVM: VMX: Move vmx_get_perf_capabilities() definition to vmx.c Sean Christopherson
2022-09-01 17:32 ` [PATCH v4 4/5] KVM: VMX: Fold vmx_supported_debugctl() into vcpu_supported_debugctl() Sean Christopherson
2022-09-01 17:32 ` [PATCH v4 5/5] KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs Sean Christopherson
2022-09-08 13:45 ` [PATCH v4 0/5] KVM: x86: Intel LBR related perf cleanups Peter Zijlstra
2022-09-17 1:11 ` Sean Christopherson
2022-10-03 17:22 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901173258.925729-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).