* [PATCH] perf inject: Clarify build-id options a little bit
@ 2022-09-14 4:08 Namhyung Kim
2022-09-14 5:11 ` Adrian Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2022-09-14 4:08 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jiri Olsa
Cc: Ingo Molnar, Peter Zijlstra, LKML, Ian Rogers, Adrian Hunter,
linux-perf-users
Update the documentation of --build-id and --buildid-all options to
clarify the difference between them. The former requires full sample
processing to find which DSOs are actually used. While the latter simply
injects every DSO's build-id from MMAP{,2} records, skipping SAMPLEs.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/Documentation/perf-inject.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Documentation/perf-inject.txt b/tools/perf/Documentation/perf-inject.txt
index 70e2ac3cc91a..c972032f4ca0 100644
--- a/tools/perf/Documentation/perf-inject.txt
+++ b/tools/perf/Documentation/perf-inject.txt
@@ -25,10 +25,12 @@ OPTIONS
-------
-b::
--build-ids::
- Inject build-ids into the output stream
+ Inject build-ids of DSOs hit by samples into the output stream.
+ This means it needs to process all SAMPLE records to find the DSOs.
--buildid-all::
- Inject build-ids of all DSOs into the output stream
+ Inject build-ids of all DSOs into the output stream regardless of hits
+ and skip SAMPLE processing.
--known-build-ids=::
Override build-ids to inject using these comma-separated pairs of
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf inject: Clarify build-id options a little bit
2022-09-14 4:08 [PATCH] perf inject: Clarify build-id options a little bit Namhyung Kim
@ 2022-09-14 5:11 ` Adrian Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Hunter @ 2022-09-14 5:11 UTC (permalink / raw)
To: Namhyung Kim, Arnaldo Carvalho de Melo, Jiri Olsa
Cc: Ingo Molnar, Peter Zijlstra, LKML, Ian Rogers, linux-perf-users
On 14/09/22 07:08, Namhyung Kim wrote:
> Update the documentation of --build-id and --buildid-all options to
> clarify the difference between them. The former requires full sample
> processing to find which DSOs are actually used. While the latter simply
> injects every DSO's build-id from MMAP{,2} records, skipping SAMPLEs.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/Documentation/perf-inject.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-inject.txt b/tools/perf/Documentation/perf-inject.txt
> index 70e2ac3cc91a..c972032f4ca0 100644
> --- a/tools/perf/Documentation/perf-inject.txt
> +++ b/tools/perf/Documentation/perf-inject.txt
> @@ -25,10 +25,12 @@ OPTIONS
> -------
> -b::
> --build-ids::
> - Inject build-ids into the output stream
> + Inject build-ids of DSOs hit by samples into the output stream.
> + This means it needs to process all SAMPLE records to find the DSOs.
>
> --buildid-all::
> - Inject build-ids of all DSOs into the output stream
> + Inject build-ids of all DSOs into the output stream regardless of hits
> + and skip SAMPLE processing.
>
> --known-build-ids=::
> Override build-ids to inject using these comma-separated pairs of
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-14 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-14 4:08 [PATCH] perf inject: Clarify build-id options a little bit Namhyung Kim
2022-09-14 5:11 ` Adrian Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).