From: Ian Rogers <irogers@google.com>
To: Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
perry.taylor@intel.com, caleb.biggers@intel.com,
kshipra.bopardikar@intel.com, samantha.alt@intel.com,
ahmad.yasin@intel.com, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>,
James Clark <james.clark@arm.com>,
Kajol Jain <kjain@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Miaoqian Lin <linmq006@gmail.com>,
Florian Fischer <florian.fischer@muhq.space>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v3 02/23] perf test: Adjust case of test metrics
Date: Mon, 3 Oct 2022 19:15:51 -0700 [thread overview]
Message-ID: <20221004021612.325521-3-irogers@google.com> (raw)
In-Reply-To: <20221004021612.325521-1-irogers@google.com>
Icelake and later architectures have slots events and SLOTS metrics
meaning case sensitivity is important. Make the test metrics case
agree with the name of the metrics.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json | 6 +++---
tools/perf/pmu-events/empty-pmu-events.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json b/tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json
index 42d9b5242fd7..70ec8caaaf6f 100644
--- a/tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json
+++ b/tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json
@@ -34,15 +34,15 @@
"MetricName": "DCache_L2_All_Miss"
},
{
- "MetricExpr": "dcache_l2_all_hits + dcache_l2_all_miss",
+ "MetricExpr": "DCache_L2_All_Hits + DCache_L2_All_Miss",
"MetricName": "DCache_L2_All"
},
{
- "MetricExpr": "d_ratio(dcache_l2_all_hits, dcache_l2_all)",
+ "MetricExpr": "d_ratio(DCache_L2_All_Hits, DCache_L2_All)",
"MetricName": "DCache_L2_Hits"
},
{
- "MetricExpr": "d_ratio(dcache_l2_all_miss, dcache_l2_all)",
+ "MetricExpr": "d_ratio(DCache_L2_All_Miss, DCache_L2_All)",
"MetricName": "DCache_L2_Misses"
},
{
diff --git a/tools/perf/pmu-events/empty-pmu-events.c b/tools/perf/pmu-events/empty-pmu-events.c
index 5ed8c0aa4817..480e8f0d30c8 100644
--- a/tools/perf/pmu-events/empty-pmu-events.c
+++ b/tools/perf/pmu-events/empty-pmu-events.c
@@ -142,15 +142,15 @@ static const struct pmu_event pme_test_soc_cpu[] = {
.metric_name = "DCache_L2_All_Miss",
},
{
- .metric_expr = "dcache_l2_all_hits + dcache_l2_all_miss",
+ .metric_expr = "DCache_L2_All_Hits + DCache_L2_All_Miss",
.metric_name = "DCache_L2_All",
},
{
- .metric_expr = "d_ratio(dcache_l2_all_hits, dcache_l2_all)",
+ .metric_expr = "d_ratio(DCache_L2_All_Hits, DCache_L2_All)",
.metric_name = "DCache_L2_Hits",
},
{
- .metric_expr = "d_ratio(dcache_l2_all_miss, dcache_l2_all)",
+ .metric_expr = "d_ratio(DCache_L2_All_Miss, DCache_L2_All)",
.metric_name = "DCache_L2_Misses",
},
{
--
2.38.0.rc1.362.ged0d419d3c-goog
next prev parent reply other threads:[~2022-10-04 2:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 2:15 [PATCH v3 00/23] Improvements to Intel perf metrics Ian Rogers
2022-10-04 2:15 ` [PATCH v3 01/23] perf expr: Allow a double if expression Ian Rogers
2022-10-04 2:15 ` Ian Rogers [this message]
2022-10-04 2:15 ` [PATCH v3 03/23] perf expr: Remove jevents case workaround Ian Rogers
2022-10-04 2:15 ` [PATCH v3 04/23] perf metrics: Don't scale counts going into metrics Ian Rogers
2022-10-04 2:15 ` [PATCH v3 07/23] perf vendor events: Update Intel broadwell Ian Rogers
2022-10-04 2:15 ` [PATCH v3 10/23] perf vendor events: Update elkhartlake cpuids Ian Rogers
2022-10-04 2:16 ` [PATCH v3 11/23] perf vendor events: Update Intel haswell Ian Rogers
2022-10-04 2:16 ` [PATCH v3 13/23] perf vendor events: Update Intel icelake Ian Rogers
2022-10-04 2:16 ` [PATCH v3 15/23] perf vendor events: Update Intel ivybridge Ian Rogers
2022-10-04 2:16 ` [PATCH v3 17/23] perf vendor events: Update Intel jaketown Ian Rogers
2022-10-04 2:16 ` [PATCH v3 18/23] perf vendor events: Update Intel sandybridge Ian Rogers
2022-10-04 2:16 ` [PATCH v3 20/23] perf vendor events: Update silvermont cpuids Ian Rogers
2022-10-04 2:16 ` [PATCH v3 22/23] perf vendor events: Update Intel tigerlake Ian Rogers
2022-10-04 2:16 ` [PATCH v3 23/23] perf vendor events: Update Intel broadwellde Ian Rogers
2022-10-04 3:43 ` [PATCH v3 00/23] Improvements to Intel perf metrics Ian Rogers
2022-10-04 17:28 ` Andi Kleen
2022-10-04 17:55 ` Ian Rogers
2022-10-04 18:09 ` Arnaldo Carvalho de Melo
2022-10-04 18:15 ` Andi Kleen
2022-10-04 18:26 ` Arnaldo Carvalho de Melo
2022-10-04 12:09 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004021612.325521-3-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=ahmad.yasin@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kshipra.bopardikar@intel.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=tmricht@linux.ibm.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).