* [PATCH] perf list: Fix title message
@ 2022-10-04 19:26 Andi Kleen
2022-10-14 15:22 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2022-10-04 19:26 UTC (permalink / raw)
To: acme; +Cc: jolsa, linux-perf-users, Andi Kleen
perf list metricgroups
gives
List of pre-defined events (to be used in -e):
Metric Groups:
Backend
Bad
BadSpec
But that's incorrect of course because metric groups or metrics can only
be specified with -M. So fix the message to say -e or -M
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/builtin-list.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
index 744dd3520584..58e1ec1654ef 100644
--- a/tools/perf/builtin-list.c
+++ b/tools/perf/builtin-list.c
@@ -60,7 +60,7 @@ int cmd_list(int argc, const char **argv)
setup_pager();
if (!raw_dump && pager_in_use())
- printf("\nList of pre-defined events (to be used in -e):\n\n");
+ printf("\nList of pre-defined events (to be used in -e or -M):\n\n");
if (hybrid_type) {
pmu_name = perf_pmu__hybrid_type_to_pmu(hybrid_type);
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf list: Fix title message
2022-10-04 19:26 [PATCH] perf list: Fix title message Andi Kleen
@ 2022-10-14 15:22 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-10-14 15:22 UTC (permalink / raw)
To: Andi Kleen; +Cc: jolsa, linux-perf-users
Em Tue, Oct 04, 2022 at 12:26:34PM -0700, Andi Kleen escreveu:
> perf list metricgroups
>
> gives
>
> List of pre-defined events (to be used in -e):
>
> Metric Groups:
>
> Backend
> Bad
> BadSpec
>
> But that's incorrect of course because metric groups or metrics can only
> be specified with -M. So fix the message to say -e or -M
Thanks, applied.
- Arnaldo
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/builtin-list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index 744dd3520584..58e1ec1654ef 100644
> --- a/tools/perf/builtin-list.c
> +++ b/tools/perf/builtin-list.c
> @@ -60,7 +60,7 @@ int cmd_list(int argc, const char **argv)
> setup_pager();
>
> if (!raw_dump && pager_in_use())
> - printf("\nList of pre-defined events (to be used in -e):\n\n");
> + printf("\nList of pre-defined events (to be used in -e or -M):\n\n");
>
> if (hybrid_type) {
> pmu_name = perf_pmu__hybrid_type_to_pmu(hybrid_type);
> --
> 2.37.2
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-14 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-04 19:26 [PATCH] perf list: Fix title message Andi Kleen
2022-10-14 15:22 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).