linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org,
	Kan Liang <kan.liang@linux.intel.com>,
	Leo Yan <leo.yan@linaro.org>, Andi Kleen <ak@linux.intel.com>,
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	James Clark <james.clark@arm.com>,
	Xing Zhengjun <zhengjun.xing@linux.intel.com>
Subject: [PATCH] perf stat: Init aggr_map when reporting per-process stat
Date: Thu, 13 Oct 2022 13:56:55 -0700	[thread overview]
Message-ID: <20221013205655.401525-1-namhyung@kernel.org> (raw)
In-Reply-To: <CAM9d7cjnAPhOPont3GHSwa9BhAsAFVvqAhFPsyAfQBR8ajrvag@mail.gmail.com>

I'll merge this into the problematic commit.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-stat.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 4cb3ceeb7ba4..9d35a3338976 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1355,7 +1355,11 @@ static struct aggr_cpu_id perf_stat__get_cpu(struct perf_stat_config *config __m
 static struct aggr_cpu_id perf_stat__get_aggr(struct perf_stat_config *config,
 					      aggr_get_id_t get_id, struct perf_cpu cpu)
 {
-	struct aggr_cpu_id id = aggr_cpu_id__empty();
+	struct aggr_cpu_id id;
+
+	/* per-process mode - should use global aggr mode */
+	if (cpu.cpu == -1)
+		return get_id(config, cpu);
 
 	if (aggr_cpu_id__is_empty(&config->cpus_aggr_map->map[cpu.cpu]))
 		config->cpus_aggr_map->map[cpu.cpu] = get_id(config, cpu);
@@ -2120,11 +2124,9 @@ int process_stat_config_event(struct perf_session *session,
 	if (perf_cpu_map__empty(st->cpus)) {
 		if (st->aggr_mode != AGGR_UNSET)
 			pr_warning("warning: processing task data, aggregation mode not set\n");
-		return 0;
-	}
-
-	if (st->aggr_mode != AGGR_UNSET)
+	} else if (st->aggr_mode != AGGR_UNSET) {
 		stat_config.aggr_mode = st->aggr_mode;
+	}
 
 	if (perf_stat.data.is_pipe)
 		perf_stat_init_aggr_mode();
-- 
2.38.0.413.g74048e4d9e-goog


  reply	other threads:[~2022-10-13 20:57 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  5:35 [RFC/PATCHSET 00/19] perf stat: Cleanup counter aggregation (v1) Namhyung Kim
2022-10-10  5:35 ` [PATCH 01/19] perf tools: Save evsel->pmu in parse_events() Namhyung Kim
2022-10-10 22:21   ` Ian Rogers
2022-10-10  5:35 ` [PATCH 02/19] perf tools: Use pmu info in evsel__is_hybrid() Namhyung Kim
2022-10-10 22:31   ` Ian Rogers
2022-10-11  5:10     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 03/19] perf stat: Use evsel__is_hybrid() more Namhyung Kim
2022-10-10 22:32   ` Ian Rogers
2022-10-10  5:35 ` [PATCH 04/19] perf stat: Add aggr id for global mode Namhyung Kim
2022-10-10 22:46   ` Ian Rogers
2022-10-11 23:08     ` Namhyung Kim
2022-10-12 10:55   ` Jiri Olsa
2022-10-12 16:31     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 05/19] perf stat: Add cpu aggr id for no aggregation mode Namhyung Kim
2022-10-10 22:49   ` Ian Rogers
2022-10-12 10:40   ` Jiri Olsa
2022-10-12 16:27     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 06/19] perf stat: Add 'needs_sort' argument to cpu_aggr_map__new() Namhyung Kim
2022-10-10 22:53   ` Ian Rogers
2022-10-11 23:32     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 07/19] perf stat: Add struct perf_stat_aggr to perf_stat_evsel Namhyung Kim
2022-10-10 23:00   ` Ian Rogers
2022-10-11 23:37     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 08/19] perf stat: Allocate evsel->stats->aggr properly Namhyung Kim
2022-10-10 23:03   ` Ian Rogers
2022-10-11 23:38     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 09/19] perf stat: Aggregate events using evsel->stats->aggr Namhyung Kim
2022-10-10 23:11   ` Ian Rogers
2022-10-11 23:44     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 10/19] perf stat: Aggregate per-thread stats " Namhyung Kim
2022-10-10 23:17   ` Ian Rogers
2022-10-11 23:46     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 11/19] perf stat: Allocate aggr counts for recorded data Namhyung Kim
2022-10-10 23:18   ` Ian Rogers
2022-10-10  5:35 ` [PATCH 12/19] perf stat: Reset aggr counts for each interval Namhyung Kim
2022-10-10 23:20   ` Ian Rogers
2022-10-11 23:48     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 13/19] perf stat: Split process_counters() Namhyung Kim
2022-10-10 23:21   ` Ian Rogers
2022-10-10  5:35 ` [PATCH 14/19] perf stat: Add perf_stat_merge_counters() Namhyung Kim
2022-10-10 23:31   ` Ian Rogers
2022-10-11 23:55     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 15/19] perf stat: Add perf_stat_process_percore() Namhyung Kim
2022-10-10 23:32   ` Ian Rogers
2022-10-11 23:59     ` Namhyung Kim
2022-10-10  5:35 ` [PATCH 16/19] perf stat: Add perf_stat_process_shadow_stats() Namhyung Kim
2022-10-10 23:36   ` Ian Rogers
2022-10-10  5:35 ` [PATCH 17/19] perf stat: Display event stats using aggr counts Namhyung Kim
2022-10-10 23:38   ` Ian Rogers
2022-10-10  5:35 ` [PATCH 18/19] perf stat: Display percore events properly Namhyung Kim
2022-10-10 23:39   ` Ian Rogers
2022-10-10  5:36 ` [PATCH 19/19] perf stat: Remove unused perf_counts.aggr field Namhyung Kim
2022-10-10 23:40   ` Ian Rogers
2022-10-12  8:41   ` Jiri Olsa
2022-10-12 16:26     ` Namhyung Kim
2022-10-13 20:56       ` Namhyung Kim [this message]
2022-10-11  0:25 ` [RFC/PATCHSET 00/19] perf stat: Cleanup counter aggregation (v1) Andi Kleen
2022-10-11  5:38   ` Namhyung Kim
2022-10-11  6:13     ` Ian Rogers
2022-10-12  3:55       ` Namhyung Kim
2022-10-11 11:57     ` Andi Kleen
2022-10-12  3:58       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221013205655.401525-1-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).