From: Nikita Shubin <nikita.shubin@maquefel.me>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: acme@redhat.com, linux@yadro.com, anup@brainfault.org,
n.shubin@yadro.com, aou@eecs.berkeley.edu,
alexander.shishkin@linux.intel.com, mingo@redhat.com,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org, mark.rutland@arm.com,
namhyung@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
peterz@infradead.org, Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH v6 0/3] RISC-V: Create unique identification for SoC PMU
Date: Mon, 17 Oct 2022 09:19:48 +0300 [thread overview]
Message-ID: <20221017091948.1961294e@redslave.neermore.group> (raw)
In-Reply-To: <mhng-a8eaa55b-16b0-4b17-b202-881e75a65eaf@palmer-ri-x1c9>
Hello Arnaldo!
On Mon, 03 Oct 2022 19:54:40 -0700 (PDT)
Palmer Dabbelt <palmer@dabbelt.com> wrote:
> On Mon, 15 Aug 2022 06:22:37 PDT (-0700), nikita.shubin@maquefel.me
> wrote:
> > From: Nikita Shubin <n.shubin@yadro.com>
> >
> > This series aims to provide matching vendor SoC with corresponded
> > JSON bindings.
> >
> > The ID string is proposed to be in form of
> > MVENDORID-MARCHID-MIMPID, for example for Sifive Unmatched the
> > corresponding string will be:
> >
> > 0x489-0x8000000000000007-0x[[:xdigit:]]+,v1,sifive/u74,core
> >
> > Where MIMPID can vary as all impl supported the same number of
> > events, this might not be true for all future SoC however.
> >
> > Also added SBI firmware events pretty names, as any firmware that
> > supports SBI PMU should also support firmare events [1].
> >
> > Series depends on patch by Anup Patel, exposing mvendor, marchid
> > and mimpid to "/proc/cpuinfo" [2].
> >
> > [1]
> > https://github.com/riscv-non-isa/riscv-sbi-doc/blob/master/riscv-sbi.adoc
> > [2] https://lkml.org/lkml/2022/7/27/23
> >
> > Link to previous version:
> > https://patchwork.kernel.org/project/linux-riscv/list/?series=653649
> >
> > See original cover letter by João Mário Domingos:
> > https://patchwork.kernel.org/project/linux-riscv/cover/20211116154812.17008-1-joao.mario@tecnico.ulisboa.pt/
> >
> > Tested with the following OpenSBI device tree bindings:
> >
> > ```
> > pmu {
> > compatible = "riscv,pmu";
> > riscv,event-to-mhpmcounters =
> > <0x03 0x06 0x18
> > 0x10001 0x10002 0x18
> > 0x10009 0x10009 0x18
> > 0x10011 0x10011 0x18
> > 0x10019 0x10019 0x18
> > 0x10021 0x10021 0x18>;
> > riscv,event-to-mhpmevent =
> > <0x03 0x00000000 0x1801
> > 0x04 0x00000000 0x0302
> > 0x05 0x00000000 0x4000
> > 0x06 0x00000000 0x6001
> > 0x10001 0x00000000 0x0202
> > 0x10002 0x00000000 0x0402
> > 0x10009 0x00000000 0x0102
> > 0x10011 0x00000000 0x2002
> > 0x10019 0x00000000 0x1002
> > 0x10021 0x00000000 0x0802>;
> > riscv,raw-event-to-mhpmcounters =
> > <0x00000000 0x03ffff00 0x0 0x0 0x18
> > 0x00000000 0x0007ff01 0x0 0x1 0x18
> > 0x00000000 0x00003f02 0x0 0x2 0x18>;
> > };
> > ```
> > ---
> > v5->v6:
> > Will Deacon:
> > - dropped first patch from v5 series it has been merged
> > into master Mayuresh Chitale:
> > - fixed FW_SFENCE_VMA_SENT event code
> >
> > - added Tested-by tags
> > ---
> >
> > Nikita Shubin (3):
> > perf arch events: riscv sbi firmware std event files
> > perf vendor events riscv: add Sifive U74 JSON file
> > RISC-V: Added Syntacore SCR7 PMU events
> >
> > tools/perf/pmu-events/arch/riscv/mapfile.csv | 18 +++
> > .../arch/riscv/riscv-sbi-firmware.json | 134
> > ++++++++++++++++++ .../arch/riscv/sifive/u74/firmware.json |
> > 68 +++++++++ .../arch/riscv/sifive/u74/instructions.json | 92
> > ++++++++++++ .../arch/riscv/sifive/u74/memory.json | 32
> > +++++ .../arch/riscv/sifive/u74/microarch.json | 57 ++++++++
> > .../arch/riscv/syntacore/scr7/L1D_cache.json | 102 +++++++++++++
> > .../arch/riscv/syntacore/scr7/L1I_cache.json | 67 +++++++++
> > .../arch/riscv/syntacore/scr7/exceptions.json | 67 +++++++++
> > .../arch/riscv/syntacore/scr7/execution.json | 97 +++++++++++++
> > .../arch/riscv/syntacore/scr7/firmware.json | 68 +++++++++
> > .../arch/riscv/syntacore/scr7/general.json | 47 ++++++
> > .../arch/riscv/syntacore/scr7/interrupts.json | 32 +++++
> > .../arch/riscv/syntacore/scr7/prediction.json | 52 +++++++
> > 14 files changed, 933 insertions(+)
> > create mode 100644 tools/perf/pmu-events/arch/riscv/mapfile.csv
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/riscv-sbi-firmware.json create
> > mode 100644
> > tools/perf/pmu-events/arch/riscv/sifive/u74/firmware.json create
> > mode 100644
> > tools/perf/pmu-events/arch/riscv/sifive/u74/instructions.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/sifive/u74/memory.json create mode
> > 100644 tools/perf/pmu-events/arch/riscv/sifive/u74/microarch.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/L1D_cache.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/L1I_cache.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/exceptions.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/execution.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/firmware.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/general.json create
> > mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/interrupts.json
> > create mode 100644
> > tools/perf/pmu-events/arch/riscv/syntacore/scr7/prediction.json
>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> not sure if you're looking for this via the RISC-V tree, it looks
> like usually these get merged via a perf tree? That's OK with me,
> but I'm also OK taking them through the RISC-V tree. Note that
> cpuinfo dependency seems to be triggering kasan failures, so we'll at
> least need to sort that out.
As i remember correctly you were willing to take these patches into 6.0
=).
Well they are acked by Palmer and [2] series, which my series depends
on, also have been accepted.
I can resend if it helps you.
Yours,
Nikita Shubin.
next prev parent reply other threads:[~2022-10-17 6:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 13:22 [PATCH v6 0/3] RISC-V: Create unique identification for SoC PMU Nikita Shubin
2022-08-15 13:22 ` [PATCH v6 1/3] perf tools riscv: Add support for get_cpuid_str function Nikita Shubin
2022-08-15 13:22 ` [PATCH v6 2/3] perf arch events: riscv sbi firmware std event files Nikita Shubin
2022-08-15 13:22 ` [PATCH v6 3/3] perf vendor events riscv: add Sifive U74 JSON file Nikita Shubin
2022-10-04 2:54 ` [PATCH v6 0/3] RISC-V: Create unique identification for SoC PMU Palmer Dabbelt
2022-10-17 6:19 ` Nikita Shubin [this message]
2022-10-17 12:24 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017091948.1961294e@redslave.neermore.group \
--to=nikita.shubin@maquefel.me \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@yadro.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=n.shubin@yadro.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).