* [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events
@ 2022-10-20 13:45 James Clark
2022-10-21 10:47 ` John Garry
2022-11-10 10:52 ` Nick Forrington
0 siblings, 2 replies; 5+ messages in thread
From: James Clark @ 2022-10-20 13:45 UTC (permalink / raw)
To: linux-perf-users, john.garry, acme
Cc: linux-kernel, nick.forrington, al.grant, James Clark, Will Deacon,
Mike Leach, Leo Yan, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-arm-kernel
Rename the neoverse-n2 folder to make it clear that it includes V2, and
add V2 to mapfile.csv. V2 has the same events as N2, visible by running
the following command in the ARM-software/data github repo [1]:
diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code
Testing:
$ perf test pmu
10: PMU events :
10.1: PMU event table sanity : Ok
10.2: PMU event map aliases : Ok
10.3: Parsing of PMU event table metrics : Ok
10.4: Parsing of PMU event table metrics with fake PMUs : Ok
[1]: https://github.com/ARM-software/data
Signed-off-by: James Clark <james.clark@arm.com>
---
.../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/branch.json | 0
.../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/bus.json | 0
.../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/cache.json | 0
.../arm64/arm/{neoverse-n2 => neoverse-n2-v2}/exception.json | 0
.../arm64/arm/{neoverse-n2 => neoverse-n2-v2}/instruction.json | 0
.../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/memory.json | 0
.../arm64/arm/{neoverse-n2 => neoverse-n2-v2}/pipeline.json | 0
.../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/spe.json | 0
.../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/trace.json | 0
tools/perf/pmu-events/arch/arm64/mapfile.csv | 3 ++-
10 files changed, 2 insertions(+), 1 deletion(-)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/branch.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/bus.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/cache.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/exception.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/instruction.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/memory.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/pipeline.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/spe.json (100%)
rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/trace.json (100%)
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/branch.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/branch.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/branch.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/branch.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/bus.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/bus.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/bus.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/bus.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/cache.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/cache.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/cache.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/cache.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/exception.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/exception.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/exception.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/exception.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/instruction.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/instruction.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/instruction.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/instruction.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/memory.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/memory.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/pipeline.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/pipeline.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/spe.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/spe.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/spe.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/spe.json
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/trace.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/trace.json
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/trace.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/trace.json
diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
index ad502d00f460..f134e833c069 100644
--- a/tools/perf/pmu-events/arch/arm64/mapfile.csv
+++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
@@ -34,7 +34,8 @@
0x00000000410fd460,v1,arm/cortex-a510,core
0x00000000410fd470,v1,arm/cortex-a710,core
0x00000000410fd480,v1,arm/cortex-x2,core
-0x00000000410fd490,v1,arm/neoverse-n2,core
+0x00000000410fd490,v1,arm/neoverse-n2-v2,core
+0x00000000410fd4f0,v1,arm/neoverse-n2-v2,core
0x00000000420f5160,v1,cavium/thunderx2,core
0x00000000430f0af0,v1,cavium/thunderx2,core
0x00000000460f0010,v1,fujitsu/a64fx,core
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events
2022-10-20 13:45 [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events James Clark
@ 2022-10-21 10:47 ` John Garry
2022-10-21 10:59 ` James Clark
2022-11-10 10:52 ` Nick Forrington
1 sibling, 1 reply; 5+ messages in thread
From: John Garry @ 2022-10-21 10:47 UTC (permalink / raw)
To: James Clark, linux-perf-users, acme
Cc: linux-kernel, nick.forrington, al.grant, Will Deacon, Mike Leach,
Leo Yan, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-arm-kernel
On 20/10/2022 14:45, James Clark wrote:
> Rename the neoverse-n2 folder to make it clear that it includes V2, and
> add V2 to mapfile.csv. V2 has the same events as N2, visible by running
> the following command in the ARM-software/data github repo [1]:
>
> diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code
>
> Testing:
>
> $ perf test pmu
>
> 10: PMU events :
> 10.1: PMU event table sanity : Ok
> 10.2: PMU event map aliases : Ok
> 10.3: Parsing of PMU event table metrics : Ok
> 10.4: Parsing of PMU event table metrics with fake PMUs : Ok
>
> [1]:https://github.com/ARM-software/data
>
> Signed-off-by: James Clark<james.clark@arm.com>
> ---
This looks ok. Out of curiosity, do you know how the naming works for
these neoverse cores? Were "n" a predecessor to "v"?
thanks,
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events
2022-10-21 10:47 ` John Garry
@ 2022-10-21 10:59 ` James Clark
0 siblings, 0 replies; 5+ messages in thread
From: James Clark @ 2022-10-21 10:59 UTC (permalink / raw)
To: John Garry
Cc: linux-kernel, nick.forrington, al.grant, Will Deacon, Mike Leach,
Leo Yan, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-arm-kernel,
linux-perf-users, acme
On 21/10/2022 11:47, John Garry wrote:
> On 20/10/2022 14:45, James Clark wrote:
>> Rename the neoverse-n2 folder to make it clear that it includes V2, and
>> add V2 to mapfile.csv. V2 has the same events as N2, visible by running
>> the following command in the ARM-software/data github repo [1]:
>>
>> diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code
>>
>> Testing:
>>
>> $ perf test pmu
>>
>> 10: PMU events :
>> 10.1: PMU event table sanity : Ok
>> 10.2: PMU event map aliases : Ok
>> 10.3: Parsing of PMU event table metrics : Ok
>> 10.4: Parsing of PMU event table metrics with fake PMUs : Ok
>>
>> [1]:https://github.com/ARM-software/data
>>
>> Signed-off-by: James Clark<james.clark@arm.com>
>> ---
>
> This looks ok. Out of curiosity, do you know how the naming works for
> these neoverse cores? Were "n" a predecessor to "v"?
Thanks for the review. No, they're more like different product lines
than predecessors. From the image on this article [1], N are focused on
performance per watt and V are high performance.
[1]:
https://www.arm.com/company/news/2022/09/redefining-the-global-computing-infrastructure-with-next-generation-arm-neoverse-platforms
>
> thanks,
> John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events
2022-10-20 13:45 [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events James Clark
2022-10-21 10:47 ` John Garry
@ 2022-11-10 10:52 ` Nick Forrington
2022-11-10 18:41 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 5+ messages in thread
From: Nick Forrington @ 2022-11-10 10:52 UTC (permalink / raw)
To: James Clark, linux-perf-users, john.garry, acme
Cc: linux-kernel, al.grant, Will Deacon, Mike Leach, Leo Yan,
Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, linux-arm-kernel
On 20/10/2022 14:45, James Clark wrote:
> Rename the neoverse-n2 folder to make it clear that it includes V2, and
> add V2 to mapfile.csv. V2 has the same events as N2, visible by running
> the following command in the ARM-software/data github repo [1]:
>
> diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code
>
> Testing:
>
> $ perf test pmu
>
> 10: PMU events :
> 10.1: PMU event table sanity : Ok
> 10.2: PMU event map aliases : Ok
> 10.3: Parsing of PMU event table metrics : Ok
> 10.4: Parsing of PMU event table metrics with fake PMUs : Ok
>
> [1]: https://github.com/ARM-software/data
>
> Signed-off-by: James Clark <james.clark@arm.com>
Reviewed-by: Nick Forrington <nick.forrington@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events
2022-11-10 10:52 ` Nick Forrington
@ 2022-11-10 18:41 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-11-10 18:41 UTC (permalink / raw)
To: Nick Forrington
Cc: James Clark, linux-perf-users, john.garry, linux-kernel, al.grant,
Will Deacon, Mike Leach, Leo Yan, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
linux-arm-kernel
Em Thu, Nov 10, 2022 at 10:52:44AM +0000, Nick Forrington escreveu:
> On 20/10/2022 14:45, James Clark wrote:
> > Rename the neoverse-n2 folder to make it clear that it includes V2, and
> > add V2 to mapfile.csv. V2 has the same events as N2, visible by running
> > the following command in the ARM-software/data github repo [1]:
> >
> > diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code
> >
> > Testing:
> >
> > $ perf test pmu
> >
> > 10: PMU events :
> > 10.1: PMU event table sanity : Ok
> > 10.2: PMU event map aliases : Ok
> > 10.3: Parsing of PMU event table metrics : Ok
> > 10.4: Parsing of PMU event table metrics with fake PMUs : Ok
> >
> > [1]: https://github.com/ARM-software/data
> >
> > Signed-off-by: James Clark <james.clark@arm.com>
> Reviewed-by: Nick Forrington <nick.forrington@arm.com>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-10 18:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 13:45 [PATCH] perf vendor events: Add Arm Neoverse V2 PMU events James Clark
2022-10-21 10:47 ` John Garry
2022-10-21 10:59 ` James Clark
2022-11-10 10:52 ` Nick Forrington
2022-11-10 18:41 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).