From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org,
Kan Liang <kan.liang@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
James Clark <james.clark@arm.com>
Subject: [PATCH 11/11] perf stat: Add missing separator in the CSV header
Date: Fri, 11 Nov 2022 19:22:44 -0800 [thread overview]
Message-ID: <20221112032244.1077370-12-namhyung@kernel.org> (raw)
In-Reply-To: <20221112032244.1077370-1-namhyung@kernel.org>
It should have a comma after 'cpus' for socket and die aggregation mode.
The output of the following command shows the issue.
$ sudo perf stat -a --per-socket -x, --metric-only -I1 true
Before:
+--- here
V
time,socket,cpusGhz,insn per cycle,branch-misses of all branches,
0.000908461,S0,8,0.950,1.65,1.21,
After:
time,socket,cpus,GHz,insn per cycle,branch-misses of all branches,
0.000683094,S0,8,0.593,2.00,0.60,
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/stat-display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 96bb7a42fd41..a316807255cd 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -828,8 +828,8 @@ static int aggr_header_lens[] = {
static const char *aggr_header_csv[] = {
[AGGR_CORE] = "core,cpus,",
- [AGGR_DIE] = "die,cpus",
- [AGGR_SOCKET] = "socket,cpus",
+ [AGGR_DIE] = "die,cpus,",
+ [AGGR_SOCKET] = "socket,cpus,",
[AGGR_NONE] = "cpu,",
[AGGR_THREAD] = "comm-pid,",
[AGGR_NODE] = "node,",
--
2.38.1.493.g58b659f92b-goog
next prev parent reply other threads:[~2022-11-12 3:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 3:22 [PATCHSET 00/11] perf stat: Cleanup perf stat output display (v2) Namhyung Kim
2022-11-12 3:22 ` [PATCH 01/11] perf stat: Fix crash with --per-node --metric-only in CSV mode Namhyung Kim
2022-11-14 18:17 ` Ian Rogers
2022-11-12 3:22 ` [PATCH 02/11] perf stat: Move common code in print_metric_headers() Namhyung Kim
2022-11-12 3:22 ` [PATCH 03/11] perf stat: Fix --metric-only --json output Namhyung Kim
2022-11-14 18:18 ` Ian Rogers
2022-11-12 3:22 ` [PATCH 04/11] perf stat: Increase metric length to align outputs Namhyung Kim
2022-11-12 3:22 ` [PATCH 05/11] perf stat: Clear screen only if output file is a tty Namhyung Kim
2022-11-14 18:19 ` Ian Rogers
2022-11-12 3:22 ` [PATCH 06/11] perf stat: Do not indent headers for JSON Namhyung Kim
2022-11-12 3:22 ` [PATCH 07/11] perf stat: Add header for interval in JSON output Namhyung Kim
2022-11-12 3:22 ` [PATCH 08/11] perf stat: Fix condition in print_interval() Namhyung Kim
2022-11-12 3:22 ` [PATCH 09/11] perf stat: Consolidate condition to print metrics Namhyung Kim
2022-11-12 3:22 ` [PATCH 10/11] perf stat: Fix summary output in CSV with --metric-only Namhyung Kim
2022-11-14 18:20 ` Ian Rogers
2022-11-12 3:22 ` Namhyung Kim [this message]
2022-11-14 18:21 ` [PATCH 11/11] perf stat: Add missing separator in the CSV header Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221112032244.1077370-12-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).