[PATCH] perf test: Fix "all PMU test" to skip parametrized events

[PATCH] perf test: Fix "all PMU test" to skip parametrized events

[Michael Petlan]

Parametrized events are not only a powerpc domain. They occur on other
platforms too (e.g. aarch64). They should be ignored in this testcase,
since proper setup of the parameters is out of scope of this script.

Let's not filter them out by PMU name, but rather based on the fact
that they expect a parameter.

Fixes: 451ed8058c69 ("perf test: Fix "all PMU test" to skip hv_24x7/hv_gpci tests on powerpc")

Signed-off-by: Michael Petlan <mpetlan@redhat.com>
---
 tools/perf/tests/shell/stat_all_pmu.sh | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
index 9c9ef33e0b3c..c77955419173 100755
--- a/tools/perf/tests/shell/stat_all_pmu.sh
+++ b/tools/perf/tests/shell/stat_all_pmu.sh
@@ -4,17 +4,8 @@
 
 set -e
 
-for p in $(perf list --raw-dump pmu); do
-  # In powerpc, skip the events for hv_24x7 and hv_gpci.
-  # These events needs input values to be filled in for
-  # core, chip, partition id based on system.
-  # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
-  # hv_gpci/event,partition_id=?/
-  # Hence skip these events for ppc.
-  if echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then
-    echo "Skipping: Event '$p' in powerpc"
-    continue
-  fi
+# Test all PMU events; however exclude parametrized ones (name contains '?')
+for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
   echo "Testing $p"
   result=$(perf stat -e "$p" true 2>&1)
   if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
-- 
2.18.4

Re: [PATCH] perf test: Fix "all PMU test" to skip parametrized events

[Arnaldo Carvalho de Melo]

Em Mon, Dec 19, 2022 at 05:30:08PM +0100, Michael Petlan escreveu:
> Parametrized events are not only a powerpc domain. They occur on other
> platforms too (e.g. aarch64). They should be ignored in this testcase,
> since proper setup of the parameters is out of scope of this script.
> 
> Let's not filter them out by PMU name, but rather based on the fact
> that they expect a parameter.

Looks ok, applied.

Thanks,

- Arnaldo
 
> Fixes: 451ed8058c69 ("perf test: Fix "all PMU test" to skip hv_24x7/hv_gpci tests on powerpc")
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> ---
>  tools/perf/tests/shell/stat_all_pmu.sh | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
> index 9c9ef33e0b3c..c77955419173 100755
> --- a/tools/perf/tests/shell/stat_all_pmu.sh
> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
> @@ -4,17 +4,8 @@
>  
>  set -e
>  
> -for p in $(perf list --raw-dump pmu); do
> -  # In powerpc, skip the events for hv_24x7 and hv_gpci.
> -  # These events needs input values to be filled in for
> -  # core, chip, partition id based on system.
> -  # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
> -  # hv_gpci/event,partition_id=?/
> -  # Hence skip these events for ppc.
> -  if echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then
> -    echo "Skipping: Event '$p' in powerpc"
> -    continue
> -  fi
> +# Test all PMU events; however exclude parametrized ones (name contains '?')
> +for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
>    echo "Testing $p"
>    result=$(perf stat -e "$p" true 2>&1)
>    if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
> -- 
> 2.18.4

-- 

- Arnaldo