From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
"Steinar H. Gunderson" <sesse@google.com>,
Kim Phillips <kim.phillips@amd.com>,
Florian Fischer <florian.fischer@muhq.space>,
James Clark <james.clark@arm.com>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
Sean Christopherson <seanjc@google.com>,
Leo Yan <leo.yan@linaro.org>,
John Garry <john.g.garry@oracle.com>,
Kajol Jain <kjain@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v4 01/11] libperf evlist: Avoid a use of evsel idx
Date: Wed, 8 Mar 2023 14:59:02 -0800 [thread overview]
Message-ID: <20230308225912.1960990-2-irogers@google.com> (raw)
In-Reply-To: <20230308225912.1960990-1-irogers@google.com>
Setting the leader iterates the list, so rather than use idx (which
may be changed through list reordering) just count the elements and
set afterwards.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/lib/perf/evlist.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c
index 61b637f29b82..2d6121e89ccb 100644
--- a/tools/lib/perf/evlist.c
+++ b/tools/lib/perf/evlist.c
@@ -687,15 +687,14 @@ perf_evlist__next_mmap(struct perf_evlist *evlist, struct perf_mmap *map,
void __perf_evlist__set_leader(struct list_head *list, struct perf_evsel *leader)
{
- struct perf_evsel *first, *last, *evsel;
-
- first = list_first_entry(list, struct perf_evsel, node);
- last = list_last_entry(list, struct perf_evsel, node);
-
- leader->nr_members = last->idx - first->idx + 1;
+ struct perf_evsel *evsel;
+ int n = 0;
- __perf_evlist__for_each_entry(list, evsel)
+ __perf_evlist__for_each_entry(list, evsel) {
evsel->leader = leader;
+ n++;
+ }
+ leader->nr_members = n;
}
void perf_evlist__set_leader(struct perf_evlist *evlist)
--
2.40.0.rc0.216.gc4246ad0f0-goog
next prev parent reply other threads:[~2023-03-08 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 22:59 [PATCH v4 00/11] Better fixes for grouping of events Ian Rogers
2023-03-08 22:59 ` Ian Rogers [this message]
2023-03-08 22:59 ` [PATCH v4 02/11] perf stat: Don't remove all grouped events when CPU maps disagree Ian Rogers
2023-03-08 22:59 ` [PATCH v4 03/11] perf pmu: Earlier PMU auxtrace initialization Ian Rogers
2023-03-10 7:30 ` Adrian Hunter
2023-03-08 22:59 ` [PATCH v4 04/11] perf stat: Modify the group test Ian Rogers
2023-03-08 22:59 ` [PATCH v4 05/11] perf evsel: Allow const evsel for certain accesses Ian Rogers
2023-03-08 22:59 ` [PATCH v4 06/11] perf evsel: Add function to compute group PMU name Ian Rogers
2023-03-13 20:41 ` Arnaldo Carvalho de Melo
2023-03-13 20:58 ` Ian Rogers
2023-03-08 22:59 ` [PATCH v4 07/11] perf parse-events: Pass ownership of the group name Ian Rogers
2023-03-08 22:59 ` [PATCH v4 08/11] perf parse-events: Sort and group parsed events Ian Rogers
2023-03-08 22:59 ` [PATCH v4 09/11] perf evsel: Remove use_uncore_alias Ian Rogers
2023-03-08 22:59 ` [PATCH v4 10/11] perf evlist: Remove nr_groups Ian Rogers
2023-03-08 22:59 ` [PATCH v4 11/11] perf parse-events: Warn when events are regrouped Ian Rogers
2023-03-10 7:29 ` Adrian Hunter
2023-03-12 2:04 ` Ian Rogers
2023-03-09 15:29 ` [PATCH v4 00/11] Better fixes for grouping of events Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308225912.1960990-2-irogers@google.com \
--to=irogers@google.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=seanjc@google.com \
--cc=sesse@google.com \
--cc=suzuki.poulose@arm.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).