From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
"Steinar H. Gunderson" <sesse@google.com>,
Kim Phillips <kim.phillips@amd.com>,
Florian Fischer <florian.fischer@muhq.space>,
James Clark <james.clark@arm.com>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
Sean Christopherson <seanjc@google.com>,
Leo Yan <leo.yan@linaro.org>,
John Garry <john.g.garry@oracle.com>,
Kajol Jain <kjain@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v5 04/11] perf stat: Modify the group test
Date: Sat, 11 Mar 2023 18:15:36 -0800 [thread overview]
Message-ID: <20230312021543.3060328-5-irogers@google.com> (raw)
In-Reply-To: <20230312021543.3060328-1-irogers@google.com>
Currently nr_members is 0 for an event with no group, however, they
are always a leader of their own group. A later change will make that
count 1 because the event is its own leader. Make the find_stat logic
consistent with this, an improvement suggested by Namhyung Kim.
Suggested-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/stat-shadow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index ef85f1ae1ab2..eeccab6751d7 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -163,7 +163,7 @@ static double find_stat(const struct evsel *evsel, int aggr_idx, enum stat_type
continue;
/* Ignore evsels that are part of different groups. */
- if (evsel->core.leader->nr_members &&
+ if (evsel->core.leader->nr_members > 1 &&
evsel->core.leader != cur->core.leader)
continue;
/* Ignore evsels with mismatched modifiers. */
--
2.40.0.rc1.284.g88254d51c5-goog
next prev parent reply other threads:[~2023-03-12 2:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 2:15 [PATCH v5 00/11] Better fixes for grouping of events Ian Rogers
2023-03-12 2:15 ` [PATCH v5 01/11] libperf evlist: Avoid a use of evsel idx Ian Rogers
2023-03-12 2:15 ` [PATCH v5 02/11] perf stat: Don't remove all grouped events when CPU maps disagree Ian Rogers
2023-03-12 2:15 ` [PATCH v5 03/11] perf pmu: Earlier PMU auxtrace initialization Ian Rogers
2023-03-12 2:15 ` Ian Rogers [this message]
2023-03-12 2:15 ` [PATCH v5 05/11] perf evsel: Allow const evsel for certain accesses Ian Rogers
2023-03-12 2:15 ` [PATCH v5 06/11] perf evsel: Add function to compute group PMU name Ian Rogers
2023-03-12 2:15 ` [PATCH v5 07/11] perf parse-events: Pass ownership of the group name Ian Rogers
2023-03-12 2:15 ` [PATCH v5 08/11] perf parse-events: Sort and group parsed events Ian Rogers
2023-03-12 2:15 ` [PATCH v5 09/11] perf evsel: Remove use_uncore_alias Ian Rogers
2023-03-12 2:15 ` [PATCH v5 10/11] perf evlist: Remove nr_groups Ian Rogers
2023-03-12 2:15 ` [PATCH v5 11/11] perf parse-events: Warn when events are regrouped Ian Rogers
2023-03-13 18:25 ` [PATCH v5 00/11] Better fixes for grouping of events Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230312021543.3060328-5-irogers@google.com \
--to=irogers@google.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=seanjc@google.com \
--cc=sesse@google.com \
--cc=suzuki.poulose@arm.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).