From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFDAC61DA4 for ; Mon, 13 Mar 2023 11:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230408AbjCMLkq (ORCPT ); Mon, 13 Mar 2023 07:40:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjCMLko (ORCPT ); Mon, 13 Mar 2023 07:40:44 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA7656485F for ; Mon, 13 Mar 2023 04:40:41 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id fy10-20020a17090b020a00b0023b4bcf0727so3889085pjb.0 for ; Mon, 13 Mar 2023 04:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678707641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EfFwm9/whD1jR/5n6DKKR8V6Fa945UAISwsDPx5HLJU=; b=UKMSaTwrX/iAEgtNVLYK1CXWlwTqjnwE629XOSX71tKhB6T3cAOlOXRTt3LvlrWi5X FqlTeRl98HKQVTHqKqa29/tAnEmIxP09oGP9/8q3Gu/uMR3E1dnVkTr0nDcF/SOpIkoP K1tgzxVrbtc398A2UEIShZ3XaBB3OyZkCx12EVsY2GMx99hts27vPZWdKGe1VXBA+1u6 DikXAAaaBuGfS5cSKOLPHhi/GvbKi1EyuN0dErkJI4ai+P/eewM/XyDHcbX41FIesMjC bUSF2i+E4x58EQP94dSS6NFDlKbrBcYM7VPl7vL5Hx53Uoj3uCKZWCJSVqDlOx0icC9N HmzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678707641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EfFwm9/whD1jR/5n6DKKR8V6Fa945UAISwsDPx5HLJU=; b=UdgHHT7bOurrxGk7vDzG0PQH8kK6NcYRrYQXjDzlFhVWqFfwVLNjLUfG9SD2NtWHR7 UXyE4Ey0BiR5lwGksYsc1FNiL36PrZ7mbt3lwnxkY5g/bFE4QyRPuxfHzJhNwmOdM4Kb PhI3G+jgyqjsfbfcXbFIT3mp63AK+Pir1jtpcw9t4HdZ9KCiG9X3KzNqmfSzx7Ghapp6 t4gRcuobGCTy5DmNzjwrM62xKtcTb+Dz5hbh8rfZlkPqlDBSOdSTarvCbZMYS5M25lf4 t30aqtgp38nV9LdDu926G9ycwItlKVKrPk6PU0iEslK2RtB9aFFcxx3Jij8SSjs6pmq0 QL4g== X-Gm-Message-State: AO0yUKVR8++Ld3BPUVHUjKHS0rgVdhuXVTFWV2YvUCibr2shxMkQG62h HwpkVZJSNzMbm5ZjjqIDUsCppw== X-Google-Smtp-Source: AK7set9Qn3N/Y7oeDr4/exTQKdkEWr0ZNpz0BljQKMTsO0FQUS1zMkn4oSsJkGhlLxsW10/KuXmQFQ== X-Received: by 2002:a17:902:a986:b0:19d:297:f30b with SMTP id bh6-20020a170902a98600b0019d0297f30bmr26907234plb.19.1678707641163; Mon, 13 Mar 2023 04:40:41 -0700 (PDT) Received: from leoy-huanghe.lan ([156.59.236.112]) by smtp.gmail.com with ESMTPSA id q21-20020a17090a2e1500b0022335f1dae2sm4281625pjd.22.2023.03.13.04.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 04:40:40 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , James Clark , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan Subject: [PATCH v4 01/16] perf kvm: Refactor overall statistics Date: Mon, 13 Mar 2023 19:40:03 +0800 Message-Id: <20230313114018.543254-2-leo.yan@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230313114018.543254-1-leo.yan@linaro.org> References: <20230313114018.543254-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Currently the tool computes overall statistics when sort the results. This patch refactors overall statistics during events processing, therefore, the function update_total_coun() is not needed anymore, an extra benefit is we can de-couple code between the statistics and the sorting. This patch is not expected any functionality changes. Signed-off-by: Leo Yan Reviewed-by: James Clark --- tools/perf/builtin-kvm.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index 641e739c717c..0172e5b0d26e 100644 --- a/tools/perf/builtin-kvm.c +++ b/tools/perf/builtin-kvm.c @@ -278,9 +278,14 @@ static double kvm_event_rel_stddev(int vcpu_id, struct kvm_event *event) avg_stats(&kvm_stats->stats)); } -static bool update_kvm_event(struct kvm_event *event, int vcpu_id, +static bool update_kvm_event(struct perf_kvm_stat *kvm, + struct kvm_event *event, int vcpu_id, u64 time_diff) { + /* Update overall statistics */ + kvm->total_count++; + kvm->total_time += time_diff; + if (vcpu_id == -1) { kvm_update_event_stats(&event->total, time_diff); return true; @@ -399,7 +404,7 @@ static bool handle_end_event(struct perf_kvm_stat *kvm, } } - return update_kvm_event(event, vcpu, time_diff); + return update_kvm_event(kvm, event, vcpu, time_diff); } static @@ -526,15 +531,6 @@ static void insert_to_result(struct rb_root *result, struct kvm_event *event, rb_insert_color(&event->rb, result); } -static void -update_total_count(struct perf_kvm_stat *kvm, struct kvm_event *event) -{ - int vcpu = kvm->trace_vcpu; - - kvm->total_count += get_event_count(event, vcpu); - kvm->total_time += get_event_time(event, vcpu); -} - static bool event_is_valid(struct kvm_event *event, int vcpu) { return !!get_event_count(event, vcpu); @@ -549,7 +545,6 @@ static void sort_result(struct perf_kvm_stat *kvm) for (i = 0; i < EVENTS_CACHE_SIZE; i++) { list_for_each_entry(event, &kvm->kvm_events_cache[i], hash_entry) { if (event_is_valid(event, vcpu)) { - update_total_count(kvm, event); insert_to_result(&kvm->result, event, kvm->compare, vcpu); } -- 2.34.1