linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	John Garry <john.g.garry@oracle.com>,
	James Clark <james.clark@arm.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics
Date: Mon, 13 Mar 2023 19:40:06 +0800	[thread overview]
Message-ID: <20230313114018.543254-5-leo.yan@linaro.org> (raw)
In-Reply-To: <20230313114018.543254-1-leo.yan@linaro.org>

Currently the metrics comparison uses greater operator (>), it returns
the boolean value (0 or 1).

This patch changes to use subtraction as comparison result, which can
be used by histograms sorting.  Since the subtraction result is u64
type, we change the function return type from int to int64_t to avoid
overflow.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 tools/perf/builtin-kvm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 62c097a37da9..4e9519390da6 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -63,10 +63,10 @@ static u64 get_event_ ##func(struct kvm_event *event, int vcpu)		\
 
 #define COMPARE_EVENT_KEY(func, field)					\
 GET_EVENT_KEY(func, field)						\
-static int cmp_event_ ## func(struct kvm_event *one,			\
+static int64_t cmp_event_ ## func(struct kvm_event *one,		\
 			      struct kvm_event *two, int vcpu)		\
 {									\
-	return get_event_ ##func(one, vcpu) >				\
+	return get_event_ ##func(one, vcpu) -				\
 	       get_event_ ##func(two, vcpu);				\
 }
 
@@ -523,7 +523,7 @@ static void insert_to_result(struct rb_root *result, struct kvm_event *event,
 		p = container_of(*rb, struct kvm_event, rb);
 		parent = *rb;
 
-		if (bigger(event, p, vcpu))
+		if (bigger(event, p, vcpu) > 0)
 			rb = &(*rb)->rb_left;
 		else
 			rb = &(*rb)->rb_right;
-- 
2.34.1


  parent reply	other threads:[~2023-03-13 11:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 11:40 [PATCH v4 00/16] perf kvm: Support histograms and TUI mode Leo Yan
2023-03-13 11:40 ` [PATCH v4 01/16] perf kvm: Refactor overall statistics Leo Yan
2023-03-13 11:40 ` [PATCH v4 02/16] perf kvm: Add pointer to 'perf_kvm_stat' in kvm event Leo Yan
2023-03-13 11:40 ` [PATCH v4 03/16] perf kvm: Move up metrics helpers Leo Yan
2023-03-13 11:40 ` Leo Yan [this message]
2023-03-13 17:58   ` [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics Arnaldo Carvalho de Melo
2023-03-14  0:26     ` Leo Yan
2023-03-13 11:40 ` [PATCH v4 05/16] perf kvm: Use macro to replace variable 'decode_str_len' Leo Yan
2023-03-13 11:40 ` [PATCH v4 06/16] perf kvm: Introduce histograms data structures Leo Yan
2023-03-13 11:40 ` [PATCH v4 07/16] perf kvm: Pass argument 'sample' to kvm_alloc_init_event() Leo Yan
2023-03-13 11:40 ` [PATCH v4 08/16] perf kvm: Parse address location for samples Leo Yan
2023-03-13 11:40 ` [PATCH v4 09/16] perf hist: Add 'kvm_info' field in histograms entry Leo Yan
2023-03-13 11:40 ` [PATCH v4 10/16] perf kvm: Add dimensions for KVM event statistics Leo Yan
2023-03-13 11:40 ` [PATCH v4 11/16] perf kvm: Use histograms list to replace cached list Leo Yan
2023-03-13 11:40 ` [PATCH v4 12/16] perf kvm: Polish sorting key Leo Yan
2023-03-13 11:40 ` [PATCH v4 13/16] perf kvm: Support printing attributions for dimensions Leo Yan
2023-03-13 11:40 ` [PATCH v4 14/16] perf kvm: Add dimensions for percentages Leo Yan
2023-03-13 11:40 ` [PATCH v4 15/16] perf kvm: Add TUI mode for stat report Leo Yan
2023-03-13 11:40 ` [PATCH v4 16/16] perf kvm: Update documentation to reflect new changes Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313114018.543254-5-leo.yan@linaro.org \
    --to=leo.yan@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).