linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	John Garry <john.g.garry@oracle.com>,
	James Clark <james.clark@arm.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v4 06/16] perf kvm: Introduce histograms data structures
Date: Mon, 13 Mar 2023 19:40:08 +0800	[thread overview]
Message-ID: <20230313114018.543254-7-leo.yan@linaro.org> (raw)
In-Reply-To: <20230313114018.543254-1-leo.yan@linaro.org>

This is a preparation to support histograms in perf kvm tool.  As first
step, this patch defines histograms data structures and initialize them.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Reviewed-by: James Clark <james.clark@arm.com>
---
 tools/perf/builtin-kvm.c   | 18 ++++++++++++++++++
 tools/perf/util/kvm-stat.h |  1 +
 2 files changed, 19 insertions(+)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index d400434aa137..384992c8a01a 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -85,6 +85,20 @@ static struct kvm_event_key keys[] = {
 	{ NULL, NULL }
 };
 
+struct kvm_hists {
+	struct hists		hists;
+	struct perf_hpp_list	list;
+};
+
+static struct kvm_hists kvm_hists;
+
+static int kvm_hists__init(void)
+{
+	__hists__init(&kvm_hists.hists, &kvm_hists.list);
+	perf_hpp_list__init(&kvm_hists.list);
+	return 0;
+}
+
 static const char *get_filename_for_perf_kvm(void)
 {
 	const char *filename;
@@ -957,6 +971,8 @@ static int kvm_events_live_report(struct perf_kvm_stat *kvm)
 	set_term_quiet_input(&save);
 	init_kvm_event_record(kvm);
 
+	kvm_hists__init();
+
 	signal(SIGINT, sig_handler);
 	signal(SIGTERM, sig_handler);
 
@@ -1152,6 +1168,8 @@ static int kvm_events_report_vcpu(struct perf_kvm_stat *kvm)
 	init_kvm_event_record(kvm);
 	setup_pager();
 
+	kvm_hists__init();
+
 	ret = read_events(kvm);
 	if (ret)
 		goto exit;
diff --git a/tools/perf/util/kvm-stat.h b/tools/perf/util/kvm-stat.h
index e84f1cdcfe05..a53cebe519b3 100644
--- a/tools/perf/util/kvm-stat.h
+++ b/tools/perf/util/kvm-stat.h
@@ -5,6 +5,7 @@
 #ifdef HAVE_KVM_STAT_SUPPORT
 
 #include "tool.h"
+#include "sort.h"
 #include "stat.h"
 #include "record.h"
 
-- 
2.34.1


  parent reply	other threads:[~2023-03-13 11:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 11:40 [PATCH v4 00/16] perf kvm: Support histograms and TUI mode Leo Yan
2023-03-13 11:40 ` [PATCH v4 01/16] perf kvm: Refactor overall statistics Leo Yan
2023-03-13 11:40 ` [PATCH v4 02/16] perf kvm: Add pointer to 'perf_kvm_stat' in kvm event Leo Yan
2023-03-13 11:40 ` [PATCH v4 03/16] perf kvm: Move up metrics helpers Leo Yan
2023-03-13 11:40 ` [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics Leo Yan
2023-03-13 17:58   ` Arnaldo Carvalho de Melo
2023-03-14  0:26     ` Leo Yan
2023-03-13 11:40 ` [PATCH v4 05/16] perf kvm: Use macro to replace variable 'decode_str_len' Leo Yan
2023-03-13 11:40 ` Leo Yan [this message]
2023-03-13 11:40 ` [PATCH v4 07/16] perf kvm: Pass argument 'sample' to kvm_alloc_init_event() Leo Yan
2023-03-13 11:40 ` [PATCH v4 08/16] perf kvm: Parse address location for samples Leo Yan
2023-03-13 11:40 ` [PATCH v4 09/16] perf hist: Add 'kvm_info' field in histograms entry Leo Yan
2023-03-13 11:40 ` [PATCH v4 10/16] perf kvm: Add dimensions for KVM event statistics Leo Yan
2023-03-13 11:40 ` [PATCH v4 11/16] perf kvm: Use histograms list to replace cached list Leo Yan
2023-03-13 11:40 ` [PATCH v4 12/16] perf kvm: Polish sorting key Leo Yan
2023-03-13 11:40 ` [PATCH v4 13/16] perf kvm: Support printing attributions for dimensions Leo Yan
2023-03-13 11:40 ` [PATCH v4 14/16] perf kvm: Add dimensions for percentages Leo Yan
2023-03-13 11:40 ` [PATCH v4 15/16] perf kvm: Add TUI mode for stat report Leo Yan
2023-03-13 11:40 ` [PATCH v4 16/16] perf kvm: Update documentation to reflect new changes Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313114018.543254-7-leo.yan@linaro.org \
    --to=leo.yan@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).