From: Paran Lee <p4ranlee@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Paran Lee <p4ranlee@gmail.com>
Subject: [RESEND PATCH] perf tools: Add levenshtein ENOMEM check
Date: Wed, 15 Mar 2023 15:11:33 +0900 [thread overview]
Message-ID: <20230315061132.25165-1-p4ranlee@gmail.com> (raw)
The levenshtein algorithm requires exception handling
when making dynamic allocations strings.
Signed-off-by: Paran Lee <p4ranlee@gmail.com>
---
tools/perf/util/help-unknown-cmd.c | 6 +++++-
tools/perf/util/levenshtein.c | 16 ++++++++++------
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/help-unknown-cmd.c b/tools/perf/util/help-unknown-cmd.c
index ab9e16123626..a70ef339b8af 100644
--- a/tools/perf/util/help-unknown-cmd.c
+++ b/tools/perf/util/help-unknown-cmd.c
@@ -74,10 +74,14 @@ const char *help_unknown_cmd(const char *cmd)
if (main_cmds.cnt) {
/* This reuses cmdname->len for similarity index */
- for (i = 0; i < main_cmds.cnt; ++i)
+ for (i = 0; i < main_cmds.cnt; ++i) {
main_cmds.names[i]->len =
levenshtein(cmd, main_cmds.names[i]->name, 0, 2, 1, 4);
+ if(main_cmds.names[i]->len == -ENOMEM)
+ goto end;
+ }
+
qsort(main_cmds.names, main_cmds.cnt,
sizeof(*main_cmds.names), levenshtein_compare);
diff --git a/tools/perf/util/levenshtein.c b/tools/perf/util/levenshtein.c
index 6a6712635aa4..0f0f244f142b 100644
--- a/tools/perf/util/levenshtein.c
+++ b/tools/perf/util/levenshtein.c
@@ -45,11 +45,17 @@ int levenshtein(const char *string1, const char *string2,
int w, int s, int a, int d)
{
int len1 = strlen(string1), len2 = strlen(string2);
- int *row0 = malloc(sizeof(int) * (len2 + 1));
- int *row1 = malloc(sizeof(int) * (len2 + 1));
- int *row2 = malloc(sizeof(int) * (len2 + 1));
+ int *rows, *row0, *row1, *row2;
int i, j;
+ rows = malloc(3 * sizeof(int) * (len2 + 1));
+ if(!rows)
+ return -ENOMEM;
+
+ row0 = &rows[0];
+ row1 = &rows[1];
+ row2 = &rows[2];
+
for (j = 0; j <= len2; j++)
row1[j] = j * a;
for (i = 0; i < len1; i++) {
@@ -79,9 +85,7 @@ int levenshtein(const char *string1, const char *string2,
}
i = row1[len2];
- free(row0);
- free(row1);
- free(row2);
+ free(rows);
return i;
}
--
2.34.1
next reply other threads:[~2023-03-15 6:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 6:11 Paran Lee [this message]
2023-03-15 8:33 ` [RESEND PATCH] perf tools: Add levenshtein ENOMEM check Paran Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315061132.25165-1-p4ranlee@gmail.com \
--to=p4ranlee@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).