From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
John Garry <john.g.garry@oracle.com>,
James Clark <james.clark@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v5 00/16] perf kvm: Support histograms and TUI mode
Date: Wed, 15 Mar 2023 22:50:56 +0800 [thread overview]
Message-ID: <20230315145112.186603-1-leo.yan@linaro.org> (raw)
This patch set is to enable histograms and (partially) TUI mode in perf
kvm tool; patch set v1 [1] gives brief introduction for the change.
We can use below commands for testing this series:
In a terminal, you could launch a virtual machine with qemu command; in
below case, I downloaded a Ubuntu (or Debian) iso file and used it as
the file system image:
$ qemu-system-x86_64 -M pc -enable-kvm -cpu host -m 4096 -hda ubuntu-22.04-desktop-amd64.iso
Then in another terminal, I can use below command to capture KVM trace
data and report the result:
# cd linux/tools/perf
# ./perf kvm stat record
# ./perf kvm stat report => Output in TUI mode
# ./perf kvm stat report --stdio => Output in stdio mode
Changes from v4:
* Fixed building failure in patch 04; compiled successfully for every
patch to ensure bisection.
Changes from v3:
* Updated patch 04 to change comparison function return type from int to
int64_t to avoid overflow;
* Added a refactoring patch 05 "perf kvm: Use macro to replace variable
'decode_str_len'";
* Refined to use hists__add_entry_ops() and hist_entry__cmp() to compare
hist entry and add new entries, to support comparison between hist
entry, added a new patch 09; (Namhyung Kim)
* Updated patch 10 for comparison event name; (Namhyung Kim)
* Refined patch 11 to move init_stats() and hists__inc_nr_samples()
into kvm_he_zalloc(); (Namhyung Kim)
* Minor refactoring for sort_result() and kvm_hists__init() in patch 15.
Changes from v2:
* Found building failure with command 'make VF=1 DEBUG=1 NO_SLANG=1',
fixed it in the patch 13. (James Clark)
Changes from v1:
* Updated the patch 13 'perf kvm: Add TUI mode for stat report' to avoid
building failure if no support HAVE_SLANG_SUPPORT.
[1] https://lore.kernel.org/lkml/20230226042053.1492409-1-leo.yan@linaro.org/
Leo Yan (16):
perf kvm: Refactor overall statistics
perf kvm: Add pointer to 'perf_kvm_stat' in kvm event
perf kvm: Move up metrics helpers
perf kvm: Use subtraction for comparison metrics
perf kvm: Use macro to replace variable 'decode_str_len'
perf kvm: Introduce histograms data structures
perf kvm: Pass argument 'sample' to kvm_alloc_init_event()
perf kvm: Parse address location for samples
perf hist: Add 'kvm_info' field in histograms entry
perf kvm: Add dimensions for KVM event statistics
perf kvm: Use histograms list to replace cached list
perf kvm: Polish sorting key
perf kvm: Support printing attributions for dimensions
perf kvm: Add dimensions for percentages
perf kvm: Add TUI mode for stat report
perf kvm: Update documentation to reflect new changes
tools/perf/Documentation/perf-kvm.txt | 9 +-
tools/perf/arch/arm64/util/kvm-stat.c | 1 -
tools/perf/arch/powerpc/util/kvm-stat.c | 3 +-
tools/perf/arch/s390/util/kvm-stat.c | 1 -
tools/perf/arch/x86/util/kvm-stat.c | 7 +-
tools/perf/builtin-annotate.c | 2 +-
tools/perf/builtin-c2c.c | 4 +-
tools/perf/builtin-diff.c | 4 +-
tools/perf/builtin-kvm.c | 859 +++++++++++++++++++-----
tools/perf/tests/hists_link.c | 4 +-
tools/perf/util/hist.c | 19 +-
tools/perf/util/hist.h | 3 +
tools/perf/util/kvm-stat.h | 33 +-
tools/perf/util/sort.h | 1 +
14 files changed, 745 insertions(+), 205 deletions(-)
--
2.34.1
next reply other threads:[~2023-03-15 14:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 14:50 Leo Yan [this message]
2023-03-15 14:50 ` [PATCH v5 01/16] perf kvm: Refactor overall statistics Leo Yan
2023-03-15 14:50 ` [PATCH v5 02/16] perf kvm: Add pointer to 'perf_kvm_stat' in kvm event Leo Yan
2023-03-15 14:50 ` [PATCH v5 03/16] perf kvm: Move up metrics helpers Leo Yan
2023-03-15 19:44 ` Arnaldo Carvalho de Melo
2023-03-15 14:51 ` [PATCH v5 04/16] perf kvm: Use subtraction for comparison metrics Leo Yan
2023-03-15 14:51 ` [PATCH v5 05/16] perf kvm: Use macro to replace variable 'decode_str_len' Leo Yan
2023-03-15 14:51 ` [PATCH v5 06/16] perf kvm: Introduce histograms data structures Leo Yan
2023-03-15 19:45 ` Arnaldo Carvalho de Melo
2023-03-16 3:02 ` Leo Yan
2023-03-15 14:51 ` [PATCH v5 07/16] perf kvm: Pass argument 'sample' to kvm_alloc_init_event() Leo Yan
2023-03-15 14:51 ` [PATCH v5 08/16] perf kvm: Parse address location for samples Leo Yan
2023-03-15 14:51 ` [PATCH v5 09/16] perf hist: Add 'kvm_info' field in histograms entry Leo Yan
2023-03-15 14:51 ` [PATCH v5 10/16] perf kvm: Add dimensions for KVM event statistics Leo Yan
2023-03-15 14:51 ` [PATCH v5 11/16] perf kvm: Use histograms list to replace cached list Leo Yan
2023-03-16 7:42 ` Namhyung Kim
2023-03-16 9:04 ` Leo Yan
2023-03-16 10:13 ` Arnaldo Carvalho de Melo
2023-03-16 15:14 ` Leo Yan
2023-03-15 14:51 ` [PATCH v5 12/16] perf kvm: Polish sorting key Leo Yan
2023-03-15 14:51 ` [PATCH v5 13/16] perf kvm: Support printing attributions for dimensions Leo Yan
2023-03-15 14:51 ` [PATCH v5 14/16] perf kvm: Add dimensions for percentages Leo Yan
2023-03-15 14:51 ` [PATCH v5 15/16] perf kvm: Add TUI mode for stat report Leo Yan
2023-03-15 14:51 ` [PATCH v5 16/16] perf kvm: Update documentation to reflect new changes Leo Yan
2023-03-15 19:35 ` [PATCH v5 00/16] perf kvm: Support histograms and TUI mode Arnaldo Carvalho de Melo
2023-03-16 3:10 ` Leo Yan
2023-03-16 10:11 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315145112.186603-1-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).