From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@arm.com>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linaro.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Raul Silvera" <rsilvera@google.com>,
"Athira Rajeev" <atrajeev@linux.vnet.ibm.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Florian Fischer" <florian.fischer@muhq.space>,
"Rob Herring" <robh@kernel.org>,
"Xing Zhengjun" <zhengjun.xing@linux.intel.com>,
"Sean Christopherson" <seanjc@google.com>,
"Chengdong Li" <chengdongli@tencent.com>,
"Denis Nikitin" <denik@chromium.org>,
"Martin Liška" <mliska@suse.cz>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org
Subject: [PATCH v1 0/6] Simplify linking against tools/perf code
Date: Mon, 27 Mar 2023 18:40:52 -0700 [thread overview]
Message-ID: <20230328014058.870413-1-irogers@google.com> (raw)
When fuzzing something like parse-events, having the main function in
perf.c alongside global variables like input_name means that
input_name must be redeclared with the fuzzer function's
main. However, as the fuzzer is using the tools/perf code as a library
this causes backward linking reference that the linker may warn
about. Reorganize perf.c and perf.h to avoid potential backward
references, or so that the declaration/definition locations are more
consistent.
Ian Rogers (6):
perf ui: Move window resize signal functions
perf usage: Move usage strings
perf header: Move perf_version_string declaration
perf version: Use regular verbose flag
perf util: Move input_name to util
perf util: Move perf_guest/host declarations
tools/perf/builtin-annotate.c | 2 +-
tools/perf/builtin-buildid-list.c | 2 +-
tools/perf/builtin-c2c.c | 2 +-
tools/perf/builtin-data.c | 2 +-
tools/perf/builtin-diff.c | 2 +-
tools/perf/builtin-evlist.c | 2 +-
tools/perf/builtin-help.c | 1 +
tools/perf/builtin-kmem.c | 2 +-
tools/perf/builtin-kvm.c | 1 +
tools/perf/builtin-kwork.c | 2 +-
tools/perf/builtin-mem.c | 2 +-
tools/perf/builtin-sched.c | 2 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-timechart.c | 2 +-
tools/perf/builtin-version.c | 7 +++----
tools/perf/builtin.h | 3 ---
tools/perf/perf.c | 27 +--------------------------
tools/perf/perf.h | 9 ---------
tools/perf/ui/browsers/hists.c | 2 +-
tools/perf/ui/hist.c | 2 +-
tools/perf/ui/setup.c | 19 +++++++++++++++++++
tools/perf/ui/tui/setup.c | 1 -
tools/perf/ui/ui.h | 3 +++
tools/perf/util/cs-etm.c | 1 +
tools/perf/util/event.c | 2 +-
tools/perf/util/evlist.c | 1 +
tools/perf/util/header.h | 2 ++
tools/perf/util/parse-events.c | 2 +-
tools/perf/util/session.c | 2 +-
tools/perf/util/top.c | 2 +-
tools/perf/util/usage.c | 6 ++++++
tools/perf/util/util.c | 2 ++
tools/perf/util/util.h | 8 ++++++++
33 files changed, 66 insertions(+), 61 deletions(-)
--
2.40.0.348.gf938b09366-goog
next reply other threads:[~2023-03-28 1:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 1:40 Ian Rogers [this message]
2023-03-28 1:40 ` [PATCH v1 1/6] perf ui: Move window resize signal functions Ian Rogers
2023-03-28 1:40 ` [PATCH v1 2/6] perf usage: Move usage strings Ian Rogers
2023-03-28 1:40 ` [PATCH v1 3/6] perf header: Move perf_version_string declaration Ian Rogers
2023-03-28 1:40 ` [PATCH v1 4/6] perf version: Use regular verbose flag Ian Rogers
2023-03-28 1:40 ` [PATCH v1 5/6] perf util: Move input_name to util Ian Rogers
2023-03-28 1:40 ` [PATCH v1 6/6] perf util: Move perf_guest/host declarations Ian Rogers
2023-03-28 13:24 ` [PATCH v1 0/6] Simplify linking against tools/perf code Adrian Hunter
2023-03-28 16:14 ` Ian Rogers
2023-03-28 17:11 ` Adrian Hunter
2023-03-28 17:42 ` Ian Rogers
2023-03-30 5:39 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328014058.870413-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=chengdongli@tencent.com \
--cc=coresight@lists.linaro.org \
--cc=denik@chromium.org \
--cc=florian.fischer@muhq.space \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=robh@kernel.org \
--cc=rsilvera@google.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).