From: tinghao.zhang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, adrian.hunter@intel.com
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
irogers@google.com, kan.liang@linux.intel.com,
Tinghao Zhang <tinghao.zhang@intel.com>,
Yi Ammy <ammy.yi@intel.com>
Subject: [PATCH] perf tests: Fix tests in 'Parse event definition strings'
Date: Tue, 11 Apr 2023 02:43:30 -0700 [thread overview]
Message-ID: <20230411094330.653965-1-tinghao.zhang@intel.com> (raw)
From: Tinghao Zhang <tinghao.zhang@intel.com>
The 'Test event parsing' test set under 'Parse event definion strings'
does not apply to hybrid events. Since hybrid events have a dedicated
test set 'Test parsing of hybrid CPU events', skip these tests on hybrid
platforms.
Fixes: 7741e03e808a ("perf test: Parse events break apart tests")
Reported-by: Yi Ammy <ammy.yi@intel.com>
Signed-off-by: Tinghao Zhang <tinghao.zhang@intel.com>
---
tools/perf/tests/parse-events.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 71a5cb343311..c6949e458e61 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -2146,6 +2146,9 @@ static int test_events(const struct evlist_test *events, int cnt)
static int test__events2(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
{
+ if (perf_pmu__has_hybrid())
+ return TEST_SKIP;
+
return test_events(test__events, ARRAY_SIZE(test__events));
}
@@ -2421,7 +2424,7 @@ static int test__pmu_events_alias2(struct test_suite *test __maybe_unused,
static struct test_case tests__parse_events[] = {
TEST_CASE_REASON("Test event parsing",
events2,
- "permissions"),
+ "permissions or hybrid"),
TEST_CASE_REASON("Test parsing of \"hybrid\" CPU events",
hybrid,
"not hybrid"),
--
2.34.1
next reply other threads:[~2023-04-11 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 9:43 tinghao.zhang [this message]
2023-04-11 13:33 ` [PATCH] perf tests: Fix tests in 'Parse event definition strings' Liang, Kan
[not found] ` <CAP-5=fVWx7F9D0MvU=tCJ4nQ3QjaB7fVaCjvD8j4F-1yo5piDA@mail.gmail.com>
[not found] ` <edd1d807-b28d-f6a3-d6fb-af39e7909744@intel.com>
2023-04-12 16:35 ` Ian Rogers
2023-04-12 20:39 ` Liang, Kan
2023-04-12 21:36 ` Ian Rogers
2023-04-13 11:31 ` Zhang, Tinghao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411094330.653965-1-tinghao.zhang@intel.com \
--to=tinghao.zhang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ammy.yi@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).