linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Liang Kan <kan.liang@linux.intel.com>,
	<linux-cxl@vger.kernel.org>, <peterz@infradead.org>,
	<mark.rutland@arm.com>, <will@kernel.org>
Cc: <mingo@redhat.com>, <acme@kernel.org>, <dan.j.williams@intel.com>,
	<linuxarm@huawei.com>, <linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>
Subject: [PATCH v6 1/5] perf: Allow a PMU to have a parent
Date: Thu, 13 Apr 2023 15:26:13 +0100	[thread overview]
Message-ID: <20230413142617.15995-2-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20230413142617.15995-1-Jonathan.Cameron@huawei.com>

Some PMUs have well defined parents such as PCI devices.
As the device_initialize() and device_add() are all within
pmu_dev_alloc() which is called from perf_pmu_register()
there is no opportunity to set the parent from within a driver.

Add a struct device *parent field to struct pmu and use that
to set the parent.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
v6: No change
v5: Move to head of series as may merge as part of:
https://lore.kernel.org/all/20230404134225.13408-1-Jonathan.Cameron@huawei.com/
---
 include/linux/perf_event.h | 1 +
 kernel/events/core.c       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index d5628a7b5eaa..b99db1eda72c 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -303,6 +303,7 @@ struct pmu {
 
 	struct module			*module;
 	struct device			*dev;
+	struct device			*parent;
 	const struct attribute_group	**attr_groups;
 	const struct attribute_group	**attr_update;
 	const char			*name;
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 435815d3be3f..32079a332480 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -11367,6 +11367,7 @@ static int pmu_dev_alloc(struct pmu *pmu)
 
 	dev_set_drvdata(pmu->dev, pmu);
 	pmu->dev->bus = &pmu_bus;
+	pmu->dev->parent = pmu->parent;
 	pmu->dev->release = pmu_dev_release;
 
 	ret = dev_set_name(pmu->dev, "%s", pmu->name);
-- 
2.37.2


  reply	other threads:[~2023-04-13 14:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13 14:26 [PATCH v6 0/5] perf: CXL 3.0 Performance Monitoring Unit support Jonathan Cameron
2023-04-13 14:26 ` Jonathan Cameron [this message]
2023-04-14  8:20   ` [PATCH v6 1/5] perf: Allow a PMU to have a parent Peter Zijlstra
2023-04-13 14:26 ` [PATCH v6 2/5] cxl: Add functions to get an instance of / count regblocks of a given type Jonathan Cameron
2023-04-13 14:26 ` [PATCH v6 3/5] cxl/pci: Find and register CXL PMU devices Jonathan Cameron
2023-04-13 14:26 ` [PATCH v6 4/5] perf: CXL Performance Monitoring Unit driver Jonathan Cameron
2023-04-22 22:31   ` Dan Williams
2023-04-23 13:48     ` Jonathan Cameron
2023-05-19 11:53       ` Will Deacon
2023-05-26  1:06   ` Namhyung Kim
2023-05-26  1:18     ` Stephane Eranian
2023-05-26  9:24       ` Jonathan Cameron
2023-05-27  5:45         ` Namhyung Kim
2023-05-26  9:27     ` Jonathan Cameron
2023-04-13 14:26 ` [PATCH v6 5/5] docs: perf: Minimal introduction the the CXL PMU device and driver Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413142617.15995-2-Jonathan.Cameron@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=acme@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).