From: Douglas Anderson <dianders@chromium.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Sumit Garg <sumit.garg@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: ito-yuichi@fujitsu.com, kgdb-bugreport@lists.sourceforge.net,
"Chen-Yu Tsai" <wens@csie.org>,
"Masayoshi Mizuma" <msys.mizuma@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
linux-arm-kernel@lists.infradead.org,
"Stephen Boyd" <swboyd@chromium.org>,
"Lecopzer Chen" <lecopzer.chen@mediatek.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-perf-users@vger.kernel.org,
"Douglas Anderson" <dianders@chromium.org>,
"Alexandru Elisei" <alexandru.elisei@arm.com>,
"Andrey Konovalov" <andreyknvl@gmail.com>,
"Ben Dooks" <ben-linux@fluff.org>,
"Borislav Petkov" <bp@alien8.de>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Darrick J. Wong" <djwong@kernel.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Gaosheng Cui" <cuigaosheng1@huawei.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Guo Ren" <guoren@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Jason Wessel" <jason.wessel@windriver.com>,
"Jianmin Lv" <lvjianmin@loongson.cn>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Jinyang He" <hejinyang@loongson.cn>,
"Joey Gouly" <joey.gouly@arm.com>,
"Kees Cook" <keescook@chromium.org>,
"Laurent Dufour" <ldufour@linux.ibm.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Masayoshi Mizuma" <m.mizuma@jp.fujitsu.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Pierre Gondois" <Pierre.Gondois@arm.com>,
"Qing Zhang" <zhangqing@loongson.cn>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"WANG Xuerui" <kernel@xen0n.name>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: [PATCH v8 00/10] arm64: Add framework to turn an IPI as NMI
Date: Wed, 19 Apr 2023 15:55:54 -0700 [thread overview]
Message-ID: <20230419225604.21204-1-dianders@chromium.org> (raw)
This is an attempt to resurrect Sumit's old patch series [1] that
allowed us to use the arm64 pseudo-NMI to get backtraces of CPUs and
also to round up CPUs in kdb/kgdb. The last post from Sumit that I
could find was v7, so I called this series v8. I haven't copied all of
his old changelongs here, but you can find them from the link.
Since v7, I have:
* Addressed the small amount of feedback that was there for v7.
* Rebased.
* Added a new patch that prevents us from spamming the logs with idle
tasks.
* Added an extra patch to gracefully fall back to regular IPIs if
pseudo-NMIs aren't there.
Since there appear to be a few different patches series related to
being able to use NMIs to get stack traces of crashed systems, let me
try to organize them to the best of my understanding:
a) This series. On its own, a) will (among other things) enable stack
traces of all running processes with the soft lockup detector if
you've enabled the sysctl "kernel.softlockup_all_cpu_backtrace". On
its own, a) doesn't give a hard lockup detector.
b) A different recently-posted series [2] that adds a hard lockup
detector based on perf. On its own, b) gives a stack crawl of the
locked up CPU but no stack crawls of other CPUs (even if they're
locked too). Together with a) + b) we get everything (full lockup
detect, full ability to get stack crawls).
c) The old Android "buddy" hard lockup detector [3] that I'm
considering trying to upstream. If b) lands then I believe c) would
be redundant (at least for arm64). c) on its own is really only
useful on arm64 for platforms that can print CPU_DBGPCSR somehow
(see [4]). a) + c) is roughly as good as a) + b).
[1] https://lore.kernel.org/linux-arm-kernel/1604317487-14543-1-git-send-email-sumit.garg@linaro.org/
[2] https://lore.kernel.org/linux-arm-kernel/20220903093415.15850-1-lecopzer.chen@mediatek.com/
[3] https://issuetracker.google.com/172213097
[4] https://issuetracker.google.com/172213129
Changes in v8:
- dynamic_ipi_setup() and dynamic_ipi_teardown() no longer take cpu param
- dynamic_ipi_setup() and dynamic_ipi_teardown() no longer take cpu param
- Add loongarch support, too
- Removed "#ifdef CONFIG_SMP" since arm64 is always SMP
- "Tag the arm64 idle functions as __cpuidle" new for v8
- "Provide a stub kgdb_nmicallback() if !CONFIG_KGDB" new for v8
- "Fallback to a regular IPI if NMI isn't enabled" new for v8
Douglas Anderson (3):
arm64: idle: Tag the arm64 idle functions as __cpuidle
kgdb: Provide a stub kgdb_nmicallback() if !CONFIG_KGDB
arm64: ipi_nmi: Fallback to a regular IPI if NMI isn't enabled
Sumit Garg (7):
arm64: Add framework to turn IPI as NMI
irqchip/gic-v3: Enable support for SGIs to act as NMIs
arm64: smp: Assign and setup an IPI as NMI
nmi: backtrace: Allow runtime arch specific override
arm64: ipi_nmi: Add support for NMI backtrace
kgdb: Expose default CPUs roundup fallback mechanism
arm64: kgdb: Roundup cpus using IPI as NMI
arch/arm/include/asm/irq.h | 2 +-
arch/arm/kernel/smp.c | 3 +-
arch/arm64/include/asm/irq.h | 4 ++
arch/arm64/include/asm/nmi.h | 17 +++++
arch/arm64/kernel/Makefile | 2 +-
arch/arm64/kernel/idle.c | 4 +-
arch/arm64/kernel/ipi_nmi.c | 103 +++++++++++++++++++++++++++++++
arch/arm64/kernel/kgdb.c | 18 ++++++
arch/arm64/kernel/smp.c | 8 +++
arch/loongarch/include/asm/irq.h | 2 +-
arch/loongarch/kernel/process.c | 3 +-
arch/mips/include/asm/irq.h | 2 +-
arch/mips/kernel/process.c | 3 +-
arch/powerpc/include/asm/nmi.h | 2 +-
arch/powerpc/kernel/stacktrace.c | 3 +-
arch/sparc/include/asm/irq_64.h | 2 +-
arch/sparc/kernel/process_64.c | 4 +-
arch/x86/include/asm/irq.h | 2 +-
arch/x86/kernel/apic/hw_nmi.c | 3 +-
drivers/irqchip/irq-gic-v3.c | 29 ++++++---
include/linux/kgdb.h | 13 ++++
include/linux/nmi.h | 12 ++--
kernel/debug/debug_core.c | 8 ++-
23 files changed, 217 insertions(+), 32 deletions(-)
create mode 100644 arch/arm64/include/asm/nmi.h
create mode 100644 arch/arm64/kernel/ipi_nmi.c
--
2.40.0.634.g4ca3ef3211-goog
next reply other threads:[~2023-04-19 22:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 22:55 Douglas Anderson [this message]
2023-04-19 22:55 ` [PATCH v8 01/10] arm64: Add framework to turn IPI as NMI Douglas Anderson
2023-04-19 22:55 ` [PATCH v8 02/10] irqchip/gic-v3: Enable support for SGIs to act as NMIs Douglas Anderson
2023-04-19 22:55 ` [PATCH v8 03/10] arm64: smp: Assign and setup an IPI as NMI Douglas Anderson
2023-04-24 17:53 ` Doug Anderson
2023-04-19 22:55 ` [PATCH v8 04/10] nmi: backtrace: Allow runtime arch specific override Douglas Anderson
2023-04-19 22:55 ` [PATCH v8 05/10] arm64: ipi_nmi: Add support for NMI backtrace Douglas Anderson
2023-04-19 22:56 ` [PATCH v8 06/10] arm64: idle: Tag the arm64 idle functions as __cpuidle Douglas Anderson
2023-05-10 16:43 ` Mark Rutland
2023-05-10 21:13 ` Doug Anderson
2023-04-19 22:56 ` [PATCH v8 07/10] kgdb: Expose default CPUs roundup fallback mechanism Douglas Anderson
2023-05-12 13:48 ` Daniel Thompson
2023-05-15 23:21 ` Doug Anderson
2023-06-01 21:47 ` Doug Anderson
2023-04-19 22:56 ` [PATCH v8 08/10] kgdb: Provide a stub kgdb_nmicallback() if !CONFIG_KGDB Douglas Anderson
2023-05-11 14:34 ` Doug Anderson
2023-05-12 13:52 ` Daniel Thompson
2023-04-19 22:56 ` [PATCH v8 09/10] arm64: kgdb: Roundup cpus using IPI as NMI Douglas Anderson
2023-05-12 14:00 ` Daniel Thompson
2023-05-15 23:11 ` Doug Anderson
2023-04-19 22:56 ` [PATCH v8 10/10] arm64: ipi_nmi: Fallback to a regular IPI if NMI isn't enabled Douglas Anderson
2023-05-10 15:28 ` [PATCH v8 00/10] arm64: Add framework to turn an IPI as NMI Doug Anderson
2023-05-10 16:30 ` Mark Rutland
2023-05-10 16:42 ` Doug Anderson
2023-05-16 10:09 ` Sumit Garg
2023-06-01 21:46 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419225604.21204-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=Jason@zx2c4.com \
--cc=Pierre.Gondois@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=andreyknvl@gmail.com \
--cc=ardb@kernel.org \
--cc=ben-linux@fluff.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=cuigaosheng1@huawei.com \
--cc=daniel.thompson@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=djwong@kernel.org \
--cc=ebiederm@xmission.com \
--cc=f4bug@amsat.org \
--cc=frederic@kernel.org \
--cc=gautham.shenoy@amd.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=hejinyang@loongson.cn \
--cc=hpa@zytor.com \
--cc=ito-yuichi@fujitsu.com \
--cc=jason.wessel@windriver.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joey.gouly@arm.com \
--cc=keescook@chromium.org \
--cc=kernel@xen0n.name \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=ldufour@linux.ibm.com \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=m.mizuma@jp.fujitsu.com \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=maz@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=msys.mizuma@gmail.com \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sparclinux@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).