linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Clark <james.clark@arm.com>
To: linux-perf-users@vger.kernel.org, coresight@lists.linaro.org,
	shy828301@gmail.com
Cc: denik@google.com, James Clark <james.clark@arm.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] perf: cs-etm: Use bool type for boolean values
Date: Mon, 24 Apr 2023 14:47:46 +0100	[thread overview]
Message-ID: <20230424134748.228137-7-james.clark@arm.com> (raw)
In-Reply-To: <20230424134748.228137-1-james.clark@arm.com>

Using u8 for boolean values makes the code a bit more difficult to read
so be more explicit by using bool.

Signed-off-by: James Clark <james.clark@arm.com>
---
 tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 8 ++++----
 tools/perf/util/cs-etm.c                        | 8 ++++----
 tools/perf/util/cs-etm.h                        | 4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
index 92a855fbe5b8..21d403f55d96 100644
--- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
+++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
@@ -60,10 +60,10 @@ struct cs_etm_decoder_params {
 	int operation;
 	void (*packet_printer)(const char *msg);
 	cs_etm_mem_cb_type mem_acc_cb;
-	u8 formatted;
-	u8 fsyncs;
-	u8 hsyncs;
-	u8 frame_aligned;
+	bool formatted;
+	bool fsyncs;
+	bool hsyncs;
+	bool frame_aligned;
 	void *data;
 };
 
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index 50593289d53c..e048949bf655 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -50,10 +50,10 @@ struct cs_etm_auxtrace {
 	struct thread *unknown_thread;
 	struct perf_tsc_conversion tc;
 
-	u8 timeless_decoding;
-	u8 snapshot_mode;
-	u8 data_queued;
-	u8 has_virtual_ts; /* Virtual/Kernel timestamps in the trace. */
+	bool timeless_decoding;
+	bool snapshot_mode;
+	bool data_queued;
+	bool has_virtual_ts; /* Virtual/Kernel timestamps in the trace. */
 
 	int num_cpu;
 	u64 latest_kernel_timestamp;
diff --git a/tools/perf/util/cs-etm.h b/tools/perf/util/cs-etm.h
index 16333d35bed4..70cac0375b34 100644
--- a/tools/perf/util/cs-etm.h
+++ b/tools/perf/util/cs-etm.h
@@ -179,8 +179,8 @@ struct cs_etm_packet {
 	u32 last_instr_subtype;
 	u32 flags;
 	u32 exception_number;
-	u8 last_instr_cond;
-	u8 last_instr_taken_branch;
+	bool last_instr_cond;
+	bool last_instr_taken_branch;
 	u8 last_instr_size;
 	u8 trace_chan_id;
 	int cpu;
-- 
2.34.1


  parent reply	other threads:[~2023-04-24 13:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 13:47 [PATCH 0/7] perf: cs-etm: Fixes around timestamped and timeless decoding James Clark
2023-04-24 13:47 ` [PATCH 1/7] perf: cs-etm: Fix timeless decode mode detection James Clark
2023-04-24 15:14   ` Suzuki K Poulose
2023-04-26  5:42     ` Denis Nikitin
2023-04-24 13:47 ` [PATCH 2/7] perf tools: Add util function for overriding user set config values James Clark
2023-04-24 15:36   ` Adrian Hunter
2023-04-24 16:43     ` James Clark
2023-04-24 17:45     ` Arnaldo Carvalho de Melo
2023-04-25 11:03       ` James Clark
2023-04-24 13:47 ` [PATCH 3/7] perf: cs-etm: Don't test full_auxtrace because it's always set James Clark
2023-04-24 13:47 ` [PATCH 4/7] perf: cs-etm: Validate options after applying them James Clark
2023-04-27 15:12   ` [PATCH 4/7] perf: cs-etm: Validate options after applying themperf_pmu__format_bits Leo Yan
2023-04-27 15:52     ` James Clark
2023-04-27 22:10       ` Leo Yan
2023-04-28 12:33         ` James Clark
2023-05-01  7:34           ` Leo Yan
2023-04-24 13:47 ` [PATCH 5/7] perf: cs-etm: Allow user to override timestamp and contextid settings James Clark
2023-04-24 13:47 ` James Clark [this message]
2023-04-24 13:47 ` [PATCH 7/7] perf: cs-etm: Add separate decode paths for timeless and per-thread modes James Clark
2023-04-26  3:16 ` [PATCH 0/7] perf: cs-etm: Fixes around timestamped and timeless decoding Denis Nikitin
2023-04-26 16:06 ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230424134748.228137-7-james.clark@arm.com \
    --to=james.clark@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=denik@google.com \
    --cc=irogers@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shy828301@gmail.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).