From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B96A7C77B60 for ; Fri, 28 Apr 2023 07:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345550AbjD1Hif (ORCPT ); Fri, 28 Apr 2023 03:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345556AbjD1Hie (ORCPT ); Fri, 28 Apr 2023 03:38:34 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07AC84487 for ; Fri, 28 Apr 2023 00:38:33 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-556f4e20131so37651387b3.1 for ; Fri, 28 Apr 2023 00:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682667512; x=1685259512; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=n8p/C4BL6ztuAn+meFB+SfP0NDlKL/GOWeX5v3wZKBY=; b=WbUD/G+NoyBE4ZNcZOWOYvELY8fEfERVFoEoLjmm+dlKOc0PNEoYF/pZEySdFr3Gmp AaSG3gRxQRXXjXibbXzgyRwoRZnvl3tCRHFoxlVIjFohuhmwEpDEkoKZOAZYz+8gH+az d9+p43sn2EO7aPZimMkfoBlFm7gqn60x52pRzJhKiVUCBEQdhsrHcLYJ7ZHpIwu+P327 Rhxi5MFWs+bOe4NifHyKANuz1n5oPxbwDEIKInLEWSnoy2OxDDE2//sJJ02vkWyvmhSW 84unIUGDhshoy02zW/lQykPRZQYXSeTWPzR6ECFO0zHvXDeRG2CAZ/21D+0RqRNAVOaH EbJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682667512; x=1685259512; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n8p/C4BL6ztuAn+meFB+SfP0NDlKL/GOWeX5v3wZKBY=; b=bXp7Ykw1aNpdh7CR8Be6fGQwi0kIJ9P322L6FcXKhACCnLVeHMP2iPe9+IAAhjlfzJ kvO+Qlb20mwWEZVAN85xIbau7pOBG8Jk+q5MFBCasfY+8U2zKTDblPA0Ysv/x1nP5Rra NOKd86ATP/4u4Hw3aHLW7cH8QSxjMokIU7SYNYGZ9Qlw875h4GiuW7c84nKTykme3wlK pfZMJQ7lOy2KtprWXpNRrcO2rVoMX4qv9mjh4S89MwKmXBf2YpkWzhkRS2TxDFb/MlhB 4Jejq2UBBY5pt/Z/OqxWLYgmFhjt0FBxLeDCLL5MhLnw90uEM/Z99+3Es/85LpqMyDOA FpWg== X-Gm-Message-State: AC+VfDwMuF11BZ+g0lUHlKeoX4PkymsVysr+YA9YS0nM3CNnSomLPS3r KjLPMDOPYspLY/9CdqHZbKLlw5AVMlew X-Google-Smtp-Source: ACHHUZ480F+EYUumT0eT6vvzWWopJX04BRu3pGc/beyzV+fRguhM2asLOQayNsOWsmk1Rx2BwnZljCi2Qjgp X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:24a7:aeb5:5de4:c29b]) (user=irogers job=sendgmr) by 2002:a81:b145:0:b0:552:f777:88ce with SMTP id p66-20020a81b145000000b00552f77788cemr2689258ywh.3.1682667512197; Fri, 28 Apr 2023 00:38:32 -0700 (PDT) Date: Fri, 28 Apr 2023 00:37:27 -0700 In-Reply-To: <20230428073809.1803624-1-irogers@google.com> Message-Id: <20230428073809.1803624-2-irogers@google.com> Mime-Version: 1.0 References: <20230428073809.1803624-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Subject: [PATCH v2 01/43] perf stat: Disable TopdownL1 on hybrid From: Ian Rogers To: Arnaldo Carvalho de Melo , Kan Liang , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Stephane Eranian , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Bugs with event parsing, event grouping and metrics causes the TopdownL1 metricgroup to crash the perf command. Temporarily disable the group if no events/metrics are spcecified. Signed-off-by: Ian Rogers --- tools/perf/builtin-stat.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index efda63f6bf32..be9677aa642f 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -1885,7 +1885,12 @@ static int add_default_attributes(void) * Add TopdownL1 metrics if they exist. To minimize * multiplexing, don't request threshold computation. */ - if (metricgroup__has_metric("TopdownL1") && + /* + * TODO: TopdownL1 is disabled on hybrid CPUs to avoid a crashes + * caused by exposing latent bugs. This is fixed properly in: + * https://lore.kernel.org/lkml/bff481ba-e60a-763f-0aa0-3ee53302c480@linux.intel.com/ + */ + if (metricgroup__has_metric("TopdownL1") && !perf_pmu__has_hybrid() && metricgroup__parse_groups(evsel_list, "TopdownL1", /*metric_no_group=*/false, /*metric_no_merge=*/false, @@ -1894,6 +1899,7 @@ static int add_default_attributes(void) stat_config.system_wide, &stat_config.metric_events) < 0) return -1; + /* Platform specific attrs */ if (evlist__add_default_attrs(evsel_list, default_null_attrs) < 0) return -1; -- 2.40.1.495.gc816e09b53d-goog