From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D41C77B7E for ; Sat, 29 Apr 2023 05:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347256AbjD2Fhw (ORCPT ); Sat, 29 Apr 2023 01:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347134AbjD2Fhm (ORCPT ); Sat, 29 Apr 2023 01:37:42 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C71A44B3 for ; Fri, 28 Apr 2023 22:37:08 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-b9a7553f95dso995006276.2 for ; Fri, 28 Apr 2023 22:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682746625; x=1685338625; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=qq4G/Esc0Oue6FYAx7cV0j1FiAAwFCfIaU2APuStCt4=; b=zF7VN5xIg/Xls/P70nXNmlMvwt8It/YyYoobszVrtva9rBrXtP8z0xKGNoEL5pr/nD 9Oy3Iog+9mZWB3p1ESqM6eWUvXDmIBsWKnyGod3Q3zoJQWxEDnMuR/04H+dmYquUuakQ mfHoNvPS+fM6Nzf7/E1D9SI//wIrjEQnucNbh+4RqnkbRmu7Sp1PvF0xfQUJwDNamR+Q MsIGsX6L033DKxskwa47W82x+ONRhTo0Uo/ZLNZ3Moy4XVUB+w1bNYtayA574gp9apa4 93jp6VBkV3qQsixhuHr4rX6akTEasJgFK7RIJHQa41s1kiT8iB2Uljv6SF3FQZk8qYxV XVFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682746625; x=1685338625; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qq4G/Esc0Oue6FYAx7cV0j1FiAAwFCfIaU2APuStCt4=; b=K+WbTZgt18sJPs5pseQs7DyTVbJc2ByrxaxTFDaKJkv3xF9pSDNAhKc1olZUwd6si3 Kg5Ige+czH+BHI1pjbeWMus8UpoCRZu6gZTsfRTvJwGeKbVRXXb4Nn475bXcDxLQgwVR 2cpI/UNQSs2Oe+5WFfEWQaXoMudcVgtjRCqHLY8kr7vWmzMq9G8uqHuPGs9saxLodm4C ODNUoDICpM4VU7Mg4EuTPdzQi7GouJZRcphsEtOw1i0FNb5HitT2NmgzfJawPqNZX/JT jji8g9gN77AQbacWZS4MEvoZ56lH8q9KgTGf1gPtElh/cmQjzri2RjcLwpZiIgo5qy6y Aznw== X-Gm-Message-State: AC+VfDyaYGMN1c7JS/jsvvFrlmifByQEPR3CO3sXfwUQkU3bsjKLMm9S 5bAhFiLPi5sfYL3/gz1Ba6oUaB733P+J X-Google-Smtp-Source: ACHHUZ5n59FgbcH2rhCiSNafqEqAfWsNzgQwBKfmroVvhkKjF7s6+OraaFq9NKh3lNG5yJBUOs+dCsZdR6Gh X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:c563:7e28:fb7c:bce3]) (user=irogers job=sendgmr) by 2002:a25:aea5:0:b0:b9a:78bf:1a4d with SMTP id b37-20020a25aea5000000b00b9a78bf1a4dmr4022294ybj.10.1682746625479; Fri, 28 Apr 2023 22:37:05 -0700 (PDT) Date: Fri, 28 Apr 2023 22:34:33 -0700 In-Reply-To: <20230429053506.1962559-1-irogers@google.com> Message-Id: <20230429053506.1962559-14-irogers@google.com> Mime-Version: 1.0 References: <20230429053506.1962559-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Subject: [PATCH v3 13/46] perf test: Use valid for PMU tests From: Ian Rogers To: Arnaldo Carvalho de Melo , Kan Liang , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Stephane Eranian , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Rather than skip all tests in test__events_pmu if PMU cpu isn't present, use the per-test valid test. This allows the running of software PMU tests on hybrid and arm systems. Reviewed-by: Kan Liang Signed-off-by: Ian Rogers --- tools/perf/tests/parse-events.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c index 35b35a5c795c..767b296b91e4 100644 --- a/tools/perf/tests/parse-events.c +++ b/tools/perf/tests/parse-events.c @@ -1430,6 +1430,11 @@ static int test__checkevent_config_cache(struct evlist *evlist) return TEST_OK; } +static bool test__pmu_cpu_valid(void) +{ + return !!perf_pmu__find("cpu"); +} + static bool test__intel_pt_valid(void) { return !!perf_pmu__find("intel_pt"); @@ -1979,21 +1984,25 @@ static const struct evlist_test test__events[] = { static const struct evlist_test test__events_pmu[] = { { .name = "cpu/config=10,config1,config2=3,period=1000/u", + .valid = test__pmu_cpu_valid, .check = test__checkevent_pmu, /* 0 */ }, { .name = "cpu/config=1,name=krava/u,cpu/config=2/u", + .valid = test__pmu_cpu_valid, .check = test__checkevent_pmu_name, /* 1 */ }, { .name = "cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/", + .valid = test__pmu_cpu_valid, .check = test__checkevent_pmu_partial_time_callgraph, /* 2 */ }, { .name = "cpu/name='COMPLEX_CYCLES_NAME:orig=cycles,desc=chip-clock-ticks',period=0x1,event=0x2/ukp", + .valid = test__pmu_cpu_valid, .check = test__checkevent_complex_name, /* 3 */ }, @@ -2209,21 +2218,6 @@ static int test__terms2(struct test_suite *test __maybe_unused, int subtest __ma return test_terms(test__terms, ARRAY_SIZE(test__terms)); } -static int test_pmu(void) -{ - struct stat st; - char path[PATH_MAX]; - int ret; - - snprintf(path, PATH_MAX, "%s/bus/event_source/devices/cpu/format/", - sysfs__mountpoint()); - - ret = stat(path, &st); - if (ret) - pr_debug("omitting PMU cpu tests\n"); - return !ret; -} - static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest __maybe_unused) { struct perf_pmu *pmu; @@ -2307,9 +2301,6 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest static int test__pmu_events2(struct test_suite *test __maybe_unused, int subtest __maybe_unused) { - if (!test_pmu()) - return TEST_SKIP; - return test_events(test__events_pmu, ARRAY_SIZE(test__events_pmu)); } -- 2.40.1.495.gc816e09b53d-goog