From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E151CC77B60 for ; Sat, 29 Apr 2023 05:35:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbjD2Ffa (ORCPT ); Sat, 29 Apr 2023 01:35:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbjD2Ff3 (ORCPT ); Sat, 29 Apr 2023 01:35:29 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D41E271C for ; Fri, 28 Apr 2023 22:35:28 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-b9a7d92d0f7so943754276.1 for ; Fri, 28 Apr 2023 22:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682746527; x=1685338527; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pRvWpupBHy9tpG1G52m6JU3o8mpqbbJS8gI2fZtfwrc=; b=iiPk0TX2SJqBQ3Cus3Tq630vqKhHPWCoPQnTKEooFo7XOHnwkZGorPthHPhjuy7LJ9 1bWhc2YGJimK5+jfhOleoSfUqiyVxsvYCNjC1umUZA6Kza6h6Zqho1bheUVmhrmkuRyU mUCQmaGW4IYgAjxZkOQveiFRYnmplqeX6uyD/HRllZQljm5SfN/Kl+MqspKrvmG+OcA/ 0JbSl0vB/ul2rXk9RmCkY2pEJIruGlVdptEPsUFkrGFRlvRONp206CQLznwzAD2oqDOY K9woGOlY69hwCA6xdH1/8rKH72eKtUgXALO634qxDwOGgfRKPES9qvcxIHCneelcO3yc S1iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682746527; x=1685338527; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pRvWpupBHy9tpG1G52m6JU3o8mpqbbJS8gI2fZtfwrc=; b=ktyXX2AI25H60l7/yELTcl8Z9EBZKuA3gvIOUbJw0V5kMvzUH38cqje6y/45fnZwCg OOFlkE9zjPFVIDrntMVZ1bQ8lO//Sc3TUt6Oe5UFv1oZ032lJxethtUcOVUDnvA/JIxP 8FNB1bCghkcrkZXxPrUX4UMKxu7YpBiPO5cqLMfEKxJGLj+ioG+iAYEtNK5tDxLRBdp6 ODsIkDL/8MtrPIbOMKu1kcE+0nf2VmqrOq27bPkEOJ8SfZikALU99K2Cgs5m0EO9rDJN rSOYQTL1vIoYXj1de56KyPLHhmtNUn4OzvJY6K2pnJfx/feDju89Q27t+it8443eyoIq 8YkA== X-Gm-Message-State: AC+VfDyfUq9iurI28KGn29/93nD3tnE9tPaVK35uM+S2c7uYkkZzeiRF jJUu61/Dc7vjmy4XM010p3YPPB+CafBx X-Google-Smtp-Source: ACHHUZ5nAIUs8wh/8rmf2rg+uh74WEsY/tVD4MDCg1iDPt+S2qJ3542QGocRCmfWoN2bRaaTc/Ksro7WJbIY X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:c563:7e28:fb7c:bce3]) (user=irogers job=sendgmr) by 2002:a25:ab24:0:b0:b9a:65b0:b39 with SMTP id u33-20020a25ab24000000b00b9a65b00b39mr2753356ybi.10.1682746527295; Fri, 28 Apr 2023 22:35:27 -0700 (PDT) Date: Fri, 28 Apr 2023 22:34:21 -0700 In-Reply-To: <20230429053506.1962559-1-irogers@google.com> Message-Id: <20230429053506.1962559-2-irogers@google.com> Mime-Version: 1.0 References: <20230429053506.1962559-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Subject: [PATCH v3 01/46] perf stat: Disable TopdownL1 on hybrid From: Ian Rogers To: Arnaldo Carvalho de Melo , Kan Liang , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Stephane Eranian , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Bugs with event parsing, event grouping and metrics causes the TopdownL1 metricgroup to crash the perf command. Temporarily disable the group if no events/metrics are spcecified. Reviewed-by: Kan Liang Signed-off-by: Ian Rogers --- tools/perf/builtin-stat.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index efda63f6bf32..be9677aa642f 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -1885,7 +1885,12 @@ static int add_default_attributes(void) * Add TopdownL1 metrics if they exist. To minimize * multiplexing, don't request threshold computation. */ - if (metricgroup__has_metric("TopdownL1") && + /* + * TODO: TopdownL1 is disabled on hybrid CPUs to avoid a crashes + * caused by exposing latent bugs. This is fixed properly in: + * https://lore.kernel.org/lkml/bff481ba-e60a-763f-0aa0-3ee53302c480@linux.intel.com/ + */ + if (metricgroup__has_metric("TopdownL1") && !perf_pmu__has_hybrid() && metricgroup__parse_groups(evsel_list, "TopdownL1", /*metric_no_group=*/false, /*metric_no_merge=*/false, @@ -1894,6 +1899,7 @@ static int add_default_attributes(void) stat_config.system_wide, &stat_config.metric_events) < 0) return -1; + /* Platform specific attrs */ if (evlist__add_default_attrs(evsel_list, default_null_attrs) < 0) return -1; -- 2.40.1.495.gc816e09b53d-goog