linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Richter <tmricht@linux.ibm.com>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	acme@kernel.org
Cc: svens@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com,
	hca@linux.ibm.com, Thomas Richter <tmricht@linux.ibm.com>
Subject: [PATCH] Fix perf test probe libc's inet_pton on x86_64
Date: Wed,  3 May 2023 10:12:55 +0200	[thread overview]
Message-ID: <20230503081255.3372986-1-tmricht@linux.ibm.com> (raw)

The test case probe libc's inet_pton & backtrace it with ping
fails with Fedora 38 on x86_64.

Function getaddrinfo() does not show up in the call chain anymore:
 # ./perf script
 ping  1803 [000] 728.567146: probe_libc:inet_pton: (7f5275afc840)
           133840 __GI___inet_pton+0x0 (/usr/lib64/libc.so.6)
            27b4a __libc_start_call_main+0x7a (/usr/lib64/libc.so.6)
            27c0b __libc_start_main@@GLIBC_2.34+0x8b (/usr/lib64/libc.so.6)

 ping  1803 [000]   728.567184: probe_libc:inet_pton: (7f5275afc840)
           133840 __GI___inet_pton+0x0 (/usr/lib64/libc.so.6)
             493e main+0xcde (/usr/bin/ping)
            27b4a __libc_start_call_main+0x7a (/usr/lib64/libc.so.6)

 #
which causes the test case to fail. Remove function getaddrinfo()
from list of expected functions.

Output before:
 # ./perf test 'libc'
 91: probe libc's inet_pton & backtrace it with ping    : FAILED!
 #

Output after:
 # ./perf test 'libc'
 91: probe libc's inet_pton & backtrace it with ping    : Ok
 #

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
---
 tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
index b4149b2db4c6..8d5915d3ad6f 100755
--- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
+++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
@@ -51,7 +51,6 @@ trace_libc_inet_pton_backtrace() {
 		;;
 	*)
 		eventattr='max-stack=3'
-		echo "getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\($libc\)$" >> $expected
 		echo ".*(\+0x[[:xdigit:]]+|\[unknown\])[[:space:]]\(.*/bin/ping.*\)$" >> $expected
 		;;
 	esac
-- 
2.40.1


             reply	other threads:[~2023-05-03  8:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  8:12 Thomas Richter [this message]
2023-05-03 14:15 ` [PATCH] Fix perf test probe libc's inet_pton on x86_64 Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503081255.3372986-1-tmricht@linux.ibm.com \
    --to=tmricht@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sumanthk@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).