* [PATCH v1] perf arm: Fix include path
@ 2023-05-08 21:31 Ian Rogers
2023-05-09 2:58 ` Leo Yan
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2023-05-08 21:31 UTC (permalink / raw)
To: Mathieu Poirier, Suzuki K Poulose, Mike Leach, Leo Yan,
John Garry, Will Deacon, James Clark, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Ian Rogers, Adrian Hunter, coresight,
linux-arm-kernel, linux-perf-users, linux-kernel
Change "../cs-etm.h" to just "cs-etm.h" as ../cs-etm.h doesn't exist.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/arch/arm/util/pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/arm/util/pmu.c b/tools/perf/arch/arm/util/pmu.c
index 860a8b42b4b5..46154c226fbb 100644
--- a/tools/perf/arch/arm/util/pmu.c
+++ b/tools/perf/arch/arm/util/pmu.c
@@ -12,7 +12,7 @@
#include "arm-spe.h"
#include "hisi-ptt.h"
#include "../../../util/pmu.h"
-#include "../cs-etm.h"
+#include "cs-etm.h"
struct perf_event_attr
*perf_pmu__get_default_config(struct perf_pmu *pmu __maybe_unused)
--
2.40.1.521.gf1e218fcd8-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] perf arm: Fix include path
2023-05-08 21:31 [PATCH v1] perf arm: Fix include path Ian Rogers
@ 2023-05-09 2:58 ` Leo Yan
0 siblings, 0 replies; 2+ messages in thread
From: Leo Yan @ 2023-05-09 2:58 UTC (permalink / raw)
To: Ian Rogers
Cc: Mathieu Poirier, Suzuki K Poulose, Mike Leach, John Garry,
Will Deacon, James Clark, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Adrian Hunter, coresight,
linux-arm-kernel, linux-perf-users, linux-kernel
Hi Ian,
On Mon, May 08, 2023 at 02:31:28PM -0700, Ian Rogers wrote:
> Change "../cs-etm.h" to just "cs-etm.h" as ../cs-etm.h doesn't exist.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/arch/arm/util/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/arm/util/pmu.c b/tools/perf/arch/arm/util/pmu.c
> index 860a8b42b4b5..46154c226fbb 100644
> --- a/tools/perf/arch/arm/util/pmu.c
> +++ b/tools/perf/arch/arm/util/pmu.c
> @@ -12,7 +12,7 @@
> #include "arm-spe.h"
> #include "hisi-ptt.h"
> #include "../../../util/pmu.h"
> -#include "../cs-etm.h"
This code is a bit tricky. Here it deliberately uses "../cs-etm.h" to
avoid including the header file in the same folder, alternatively, the
compiler option "-I/home/leoy/Work/linux/tools/perf/util/include" will
lead the C file to include "tools/perf/util/include/../cs-etm.h".
> +#include "cs-etm.h"
So with this change, perf will fail to build actually :)
We need to change to:
#include "../../../util/cs-etm.h"
With above change:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Thanks for code improvement!
> struct perf_event_attr
> *perf_pmu__get_default_config(struct perf_pmu *pmu __maybe_unused)
> --
> 2.40.1.521.gf1e218fcd8-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-09 2:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-08 21:31 [PATCH v1] perf arm: Fix include path Ian Rogers
2023-05-09 2:58 ` Leo Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).