From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72208C77B7A for ; Fri, 26 May 2023 19:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242168AbjEZTos (ORCPT ); Fri, 26 May 2023 15:44:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230322AbjEZTor (ORCPT ); Fri, 26 May 2023 15:44:47 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D45BD for ; Fri, 26 May 2023 12:44:46 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-babb79a17b8so1534328276.0 for ; Fri, 26 May 2023 12:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685130286; x=1687722286; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=Ao0iXi5t0xlQzOCpiGrMaghimyku8bQxK75df2szPg8=; b=bDkloEG0Rnw1JsC3vOV7ZxpKphAXsXrNTAi+MuZ+WeHz8dO7ziObIIR2rTuqtCZsKB 7iiymEgNUxbRZD0TjfDMZUdoLVzdV9SGBEfwfBpfmK8Q86MmkNeuetfImWPlMMNqDp7Z 6Fc0sYzpiQ/vlaz3IfjMCmk7BMyybUCz3FedhrzoPEv9g9P58M9ikGMhvE/GVZg8w0fw VeUHinS9P8mOHNZJCVgnyVHn3KnA3Uy2rYW+kW3vBDGoVYF3UNhfAKju0E33wUPz2lff SgXzHjAyV0xqUz4/QjKIIPeKPi4o8ZxGvA6CRubu4RP+fQEiB9egSAyH6MFcFTNuHXd1 KIuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685130286; x=1687722286; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ao0iXi5t0xlQzOCpiGrMaghimyku8bQxK75df2szPg8=; b=lkbfblz9RAX25SI2c9qqF3OYn0dllopE9DYBCJ/Ha91rSlFAHtpdztQMjJh7UUjd1H jrveYnjtCnchDZq1YXBG/7Fcli/WIiIQ//L1HCl8FnUXEghKbLVn72ej7CYbJnOpi9DM /YYde/MLAkTL8IzRIhcMEgAkDcONFh/M3OdV5XMzZxEQu45f+qYIAxwX+KtvlW1MbOZF 3qJQaAYqqtc/Hif69l8TyvM18uGG7z7zZDy4vueaA4ifQQxUU/CZRYYOrLPyFk9PkJmp wFjUgLFn7pcitbMhzRJIZjinWWT+qUEppxybKZN5dborImr6Va9+Y2/MdISnGANLcCIq 0GHQ== X-Gm-Message-State: AC+VfDxo1mC7xrFU4XlnQSn54YMBcApMBYtGiDTJYql9zq6WP3OzIXLY LjTs/C9i0nNt+1YjB+PYhGMRaQ3fT6Cr X-Google-Smtp-Source: ACHHUZ4QPxMg2MEKujpTlVEQB8eOlGqGBxBCiCGE4MUqS4avAb2neblRB5Vf4a39srNyN6USuHERbzQDoNaI X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3b4e:312c:644:a642]) (user=irogers job=sendgmr) by 2002:a05:6902:4ef:b0:ba8:2e69:9e06 with SMTP id w15-20020a05690204ef00b00ba82e699e06mr1530393ybs.1.1685130286062; Fri, 26 May 2023 12:44:46 -0700 (PDT) Date: Fri, 26 May 2023 12:44:40 -0700 Message-Id: <20230526194442.2355872-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v3 0/2] Fixes from evsel__group_pmu_name asan error From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kan Liang , Sandipan Das , James Clark , Dmitrii Dolgov <9erthalion6@gmail.com>, Changbin Du , Rob Herring , Xing Zhengjun , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org evsel__group_pmu_name triggered an asan error as a list_head was cast to an evsel, when it was the head, and the accessed as if it were a full evsel. Further investigation showed problematic list iteration for evsel__group_pmu_name whilst the list was being sorted so switch to pre-computation. v3: Rebase on perf-tools-next (branch getting ready for 6.5) rather than perf-tools (fixes for 6.4). v2: Address review comments/feedback from Adrian Hunter . Ian Rogers (2): perf evsel: evsel__group_pmu_name fixes perf evsel: for_each_group fixes tools/perf/util/evsel.c | 31 ++++----------- tools/perf/util/evsel.h | 26 +++++++----- tools/perf/util/evsel_fprintf.c | 1 + tools/perf/util/parse-events.c | 70 +++++++++++++++++++++++++++------ 4 files changed, 84 insertions(+), 44 deletions(-) -- 2.41.0.rc0.172.g3f132b7071-goog