From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7099C7EE2F for ; Wed, 7 Jun 2023 01:46:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240697AbjFGBqb (ORCPT ); Tue, 6 Jun 2023 21:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240622AbjFGBo5 (ORCPT ); Tue, 6 Jun 2023 21:44:57 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EA871FE2 for ; Tue, 6 Jun 2023 18:44:49 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-bb397723627so2369252276.1 for ; Tue, 06 Jun 2023 18:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686102288; x=1688694288; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=yOIINORTn0PFJFSJlhKwC+O6Tqe9UX93OtBkr06o1MI=; b=Wa0jHgYu7yo6yDbvDMoChgMV4Y/i3gAhc51C7Y/1Zp4qXLse4hCqY1eFCW8jXhZAeh wVF1lTpIU5m54nO3wa3E4cFY++lS1ESwVmUNBEQV22QkrsV9fPoB0L0YGJtsB92UCjZo VNSS0+rTT7I+GOgWUHqmZOSJjnWWqLzyUwasAanqINU2E7LRBlfYN1DhvY8G1nu08lVv uNaD3E7u6lcFaI8kIuzI5iat8BjY815NhGDQlsZuVPdo0PipMa9wrwJ+OM92XjhB373w VGRvpWwaOSp9/mPj+UTdhsKi4LX9iPjemg84hvvbIdNxJVE2qdStqIAh4n2NzoAV00oQ I8yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686102288; x=1688694288; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yOIINORTn0PFJFSJlhKwC+O6Tqe9UX93OtBkr06o1MI=; b=can5hqje2vVs03kaqjAM1qXK8WSISWvmREOhIBoVIMFHXFea1DU/9k9/shg4pazknS F2u3X1AaiocONgJcBnOzXe3f4t5/Gy+kGBCDY6Xc1SQF7kFsSHxzvsCcL9nc4YBLXRaC iSAQTmsMRu5zc/s+VfOyBVF2ALf5Y0IsvOlKdGhr6RMtkEHJjRJTs35eK1mafIMvdGO4 Hn4wIyI39UzGCjiKeL+IcZOPsFhZGD/nkRar7FlYC4Z8GRLgihBm4Ytdry8szIchX62u 4LhQeVg9mjRlZHsDcMSAqURQkg79nok6aJPfM4STkFZnIPhWM2z4Uv0999GT1YxvjQMa YFoA== X-Gm-Message-State: AC+VfDx5qaeO3BlDLEkgnjqnFXe+RK3CKUqTNUfezrorc+53IG+g2jTS 0VcmUXQiOw0SX+UT0JLytAjc7E2TTl+x X-Google-Smtp-Source: ACHHUZ6bhSqGSNTPX7PPLeAh4LDoJ50x15oKgeKxKdgw6QbIsf0UJ97hv8l0FaRESJRHlzcYJw/vhj9Npw4v X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3c35:209f:5d38:b7a1]) (user=irogers job=sendgmr) by 2002:a05:6902:124f:b0:bab:9391:470a with SMTP id t15-20020a056902124f00b00bab9391470amr1478491ybu.0.1686102288644; Tue, 06 Jun 2023 18:44:48 -0700 (PDT) Date: Tue, 6 Jun 2023 18:43:50 -0700 In-Reply-To: <20230607014353.3172466-1-irogers@google.com> Message-Id: <20230607014353.3172466-18-irogers@google.com> Mime-Version: 1.0 References: <20230607014353.3172466-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v1 17/20] perf maps: Fix overlapping memory leak From: Ian Rogers To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Suzuki K Poulose , "Naveen N. Rao" , Kan Liang , German Gomez , Ali Saidi , Jing Zhang , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Athira Rajeev , Miguel Ojeda , ye xingchen , Liam Howlett , Dmitrii Dolgov <9erthalion6@gmail.com>, "Shawn M. Chapla" , Yang Jihong , K Prateek Nayak , Changbin Du , Ravi Bangoria , Sean Christopherson , Raul Silvera , Andi Kleen , "Steinar H. Gunderson" , Yuan Can , Brian Robbins , liuwenyu , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, coresight@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Add a missed free detected by leak sanitizer. Signed-off-by: Ian Rogers --- tools/perf/util/maps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/maps.c b/tools/perf/util/maps.c index 5206a6433117..233438c95b53 100644 --- a/tools/perf/util/maps.c +++ b/tools/perf/util/maps.c @@ -374,6 +374,7 @@ int maps__fixup_overlappings(struct maps *maps, struct map *map, FILE *fp) } put_map: map__put(pos->map); + free(pos); } up_write(maps__lock(maps)); return err; -- 2.41.0.rc0.172.g3f132b7071-goog