From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@kernel.org, irogers@google.com,
namhyung@kernel.org, ravi.bangoria@amd.com,
john.g.garry@oracle.com
Cc: linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com
Subject: [PATCH 10/22] tools/perf/tests: Fix shellcheck issues in tests/shell/stat+shadow_stat.sh tetscase
Date: Wed, 21 Jun 2023 14:00:09 +0530 [thread overview]
Message-ID: <20230621083021.71203-11-atrajeev@linux.vnet.ibm.com> (raw)
In-Reply-To: <20230621083021.71203-1-atrajeev@linux.vnet.ibm.com>
Running shellcheck on stat+shadow_stat.sh generates below
warning:
In tests/shell/stat+shadow_stat.sh line 48:
while read cpu num evt hash ipc rest
^--^ SC2034 (warning): hash appears unused. Verify use (or export if used externally).
This variable is intentioanlly unused since it is
needed to parse through the output. Use "_" as a
prefix for this throw away variable.
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
---
tools/perf/tests/shell/stat+shadow_stat.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/shell/stat+shadow_stat.sh b/tools/perf/tests/shell/stat+shadow_stat.sh
index 0e9cba84e757..a1918a15e36a 100755
--- a/tools/perf/tests/shell/stat+shadow_stat.sh
+++ b/tools/perf/tests/shell/stat+shadow_stat.sh
@@ -14,7 +14,7 @@ test_global_aggr()
{
perf stat -a --no-big-num -e cycles,instructions sleep 1 2>&1 | \
grep -e cycles -e instructions | \
- while read num evt hash ipc rest
+ while read num evt _hash ipc rest
do
# skip not counted events
if [ "$num" = "<not" ]; then
@@ -45,7 +45,7 @@ test_no_aggr()
{
perf stat -a -A --no-big-num -e cycles,instructions sleep 1 2>&1 | \
grep ^CPU | \
- while read cpu num evt hash ipc rest
+ while read cpu num evt _hash ipc rest
do
# skip not counted events
if [ "$num" = "<not" ]; then
--
2.39.1
next prev parent reply other threads:[~2023-06-21 8:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:29 [PATCH 00/22] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts Athira Rajeev
2023-06-21 8:30 ` [PATCH 01/22] tools/perf/tests: Fix shellcheck warnings for trace+probe_vfs_getname.sh Athira Rajeev
2023-06-21 8:30 ` [PATCH 02/22] tools/perf/tests: Fix shellcheck warning for probe_vfs_getname.sh testcase Athira Rajeev
2023-06-21 8:30 ` [PATCH 03/22] tools/perf/tests: Fix shellcheck warning for record_offcpu.sh testcase Athira Rajeev
2023-06-21 8:30 ` [PATCH 04/22] tools/perf/tests: Fix shellcheck issue for lock_contention.sh testcase Athira Rajeev
2023-06-21 8:30 ` [PATCH 05/22] tools/perf/tests: Fix shellcheck issue for stat_bpf_counters_cgrp.sh testcase Athira Rajeev
2023-06-21 8:30 ` [PATCH 06/22] tools/perf/tests: fix test_arm_spe_fork.sh signal case issues Athira Rajeev
2023-06-21 8:30 ` [PATCH 07/22] tools/perf/tests: Fix unused variable references in stat+csv_summary.sh testcase Athira Rajeev
2023-06-21 8:30 ` [PATCH 08/22] tools/perf/tests: fix shellcheck warning for test_perf_data_converter_json.sh testcase Athira Rajeev
2023-06-21 8:30 ` [PATCH 09/22] tools/perf/tests: Fix shellcheck issue for stat_bpf_counters.sh testcase Athira Rajeev
2023-06-21 8:30 ` Athira Rajeev [this message]
2023-06-21 8:30 ` [PATCH 11/22] tools/perf/tests: Fix shellcheck warning for asm_pure_loop.sh shell script Athira Rajeev
2023-06-21 8:30 ` [PATCH 12/22] tools/perf/tests: Fix shellcheck warning for memcpy_thread_16k_10.sh " Athira Rajeev
2023-06-21 8:30 ` [PATCH 13/22] tools/perf/tests: Fix shellcheck warning for coresight.sh " Athira Rajeev
2023-06-27 7:52 ` James Clark
2023-06-21 8:30 ` [PATCH 14/22] tools/perf/tests: Fix shellcheck warning for probe.sh " Athira Rajeev
2023-06-21 8:30 ` [PATCH 15/22] tools/perf/trace: Fix shellcheck issue for arch_errno_names.sh script Athira Rajeev
2023-06-21 8:30 ` [PATCH 16/22] tools/perf: Fix shellcheck issue for check-headers.sh script Athira Rajeev
2023-06-21 8:30 ` [PATCH 17/22] tools/perf/tests: Fix shellcheck warnings for thread_loop_check_tid_10.sh Athira Rajeev
2023-06-21 8:30 ` [PATCH 18/22] tools/perf/tests: Fix shellcheck warnings for unroll_loop_thread_10.sh Athira Rajeev
2023-06-21 8:30 ` [PATCH 19/22] tools/perf/tests: Fix shellcheck warnings for lib/probe_vfs_getname.sh Athira Rajeev
2023-06-21 8:30 ` [PATCH 20/22] tools/perf/tests: Fix the shellcheck wanrings in lib/waiting.sh Athira Rajeev
2023-06-21 8:30 ` [PATCH 21/22] tools/perf/trace: Fix x86_arch_prctl.sh to address shellcheck warnings Athira Rajeev
2023-06-21 8:30 ` [PATCH 22/22] tools/perf/arch/x86: Fix syscalltbl.sh " Athira Rajeev
2023-06-23 23:40 ` [PATCH 00/22] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts Namhyung Kim
2023-06-27 7:12 ` Athira Rajeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621083021.71203-11-atrajeev@linux.vnet.ibm.com \
--to=atrajeev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).