From: Jakub Kicinski <kuba@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Matthieu Baerts <matthieu.baerts@tessares.net>,
David Howells <dhowells@redhat.com>,
netdev@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Matthew Wilcox <willy@infradead.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tools: Fix MSG_SPLICE_PAGES build error in trace tools
Date: Mon, 26 Jun 2023 14:53:53 -0700 [thread overview]
Message-ID: <20230626145353.468fd133@kernel.org> (raw)
In-Reply-To: <CAM9d7ch_mWUQGW8G221bZmCPn3wB2mjZm=ZdmhDkczhich9xZA@mail.gmail.com>
On Mon, 26 Jun 2023 14:31:39 -0700 Namhyung Kim wrote:
> Right, we want to keep the headers files in the tools in sync with
> the kernel ones. And they are used to generate some tables.
> Full explanation from Arnaldo below.
>
> So I'm ok for the msg_flags.c changes, but please refrain from
> changing the header directly. We will update it later.
>
> With that,
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Ah, missed this email, sounds like this is preferred to Matthieu's
fix, we'll take this one.
> Also I wonder if the tool needs to keep the original flag
> (SENDPAGE_NOTLAST) for the older kernels.
That's a bit unclear, because it's just a kernel-internal flag.
Future kernels may well use that bit for something else.
Better long term solution would be to use an enum so that the values
are included in debuginfo and perf can read them at runtime :(
next prev parent reply other threads:[~2023-06-26 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 13:20 [PATCH net-next] tools: Fix MSG_SPLICE_PAGES build error in trace tools David Howells
2023-06-26 13:47 ` Matthieu Baerts
2023-06-26 13:50 ` David Howells
2023-06-26 13:56 ` Matthieu Baerts
2023-06-26 21:31 ` Namhyung Kim
2023-06-26 21:53 ` Jakub Kicinski [this message]
2023-06-26 21:59 ` Namhyung Kim
2023-06-27 9:53 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626145353.468fd133@kernel.org \
--to=kuba@kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthieu.baerts@tessares.net \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).