From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6B7EB64D9 for ; Mon, 26 Jun 2023 21:58:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbjFZV66 (ORCPT ); Mon, 26 Jun 2023 17:58:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231949AbjFZV6p (ORCPT ); Mon, 26 Jun 2023 17:58:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 369C92957; Mon, 26 Jun 2023 14:55:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AC3C860F83; Mon, 26 Jun 2023 21:53:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65F39C433C0; Mon, 26 Jun 2023 21:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687816435; bh=E5V6C3Cy2abGlilAmJAR5VqMNIsaaUZD3xWjkT72NbU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pUmi7PrIMMiicJTrzrPcl2cjxsPjGBBu2KQB61vcBxhvXujZeQYeJADuuODmlPTSH fj7Cy36hY3pRiAMAwnM9027wLGM93TeCyVdUKFJDZ0bpisG6Y2EZV7VLJuaXBilwXF FIuI+ZaCqVVtKwjyJHq3JHdgDWACHRwDMN9fz0AgMIixYWZlQUgw5eyv9WyR9D3dkf lVzgjTUceF5D3nPycgZ0FxzW2Plvrl33i4C0kWTGOamu8ugMHAfrhkDVpPx9PzUSF5 yOWno71ZE1XBeBGbKISuMZyE8qduWv0+usircmk0Byyj+MhhCthydRMH1sj8V9d+im n4DX/2IHSUBiA== Date: Mon, 26 Jun 2023 14:53:53 -0700 From: Jakub Kicinski To: Namhyung Kim Cc: Matthieu Baerts , David Howells , netdev@vger.kernel.org, Arnaldo Carvalho de Melo , David Miller , Eric Dumazet , Paolo Abeni , Jens Axboe , Matthew Wilcox , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] tools: Fix MSG_SPLICE_PAGES build error in trace tools Message-ID: <20230626145353.468fd133@kernel.org> In-Reply-To: References: <5791ec06-7174-9ae5-4fe4-6969ed110165@tessares.net> <3065880.1687785614@warthog.procyon.org.uk> <3067876.1687787456@warthog.procyon.org.uk> <2cb3b411-9010-a44b-ebee-1914e7fd7b9c@tessares.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Mon, 26 Jun 2023 14:31:39 -0700 Namhyung Kim wrote: > Right, we want to keep the headers files in the tools in sync with > the kernel ones. And they are used to generate some tables. > Full explanation from Arnaldo below. > > So I'm ok for the msg_flags.c changes, but please refrain from > changing the header directly. We will update it later. > > With that, > Acked-by: Namhyung Kim Ah, missed this email, sounds like this is preferred to Matthieu's fix, we'll take this one. > Also I wonder if the tool needs to keep the original flag > (SENDPAGE_NOTLAST) for the older kernels. That's a bit unclear, because it's just a kernel-internal flag. Future kernels may well use that bit for something else. Better long term solution would be to use an enum so that the values are included in debuginfo and perf can read them at runtime :(