From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@kernel.org, irogers@google.com,
namhyung@kernel.org
Cc: linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com
Subject: [PATCH V2 22/26] tools/perf/tests/shell: Fix the shellcheck warnings in record+zstd_comp_decomp.sh
Date: Sun, 9 Jul 2023 23:57:56 +0530 [thread overview]
Message-ID: <20230709182800.53002-23-atrajeev@linux.vnet.ibm.com> (raw)
In-Reply-To: <20230709182800.53002-1-atrajeev@linux.vnet.ibm.com>
Running shellcheck on record+zstd_comp_decomp.sh testcases
throws below warning:
In tests/shell/record+zstd_comp_decomp.sh line 16:
$perf_tool record -o $trace_file $gflag -z -F 5000 -- \
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
$perf_tool record -o "$trace_file" $gflag -z -F 5000 -- \
In tests/shell/record+zstd_comp_decomp.sh line 22:
$perf_tool report -i $trace_file --header --stats | \
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Added double quote around file names to fix these
shellcheck reported issues.
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
---
tools/perf/tests/shell/record+zstd_comp_decomp.sh | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
index 49bd875d5122..8929046e9057 100755
--- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
+++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
@@ -13,25 +13,25 @@ skip_if_no_z_record() {
collect_z_record() {
echo "Collecting compressed record file:"
[ "$(uname -m)" != s390x ] && gflag='-g'
- $perf_tool record -o $trace_file $gflag -z -F 5000 -- \
+ $perf_tool record -o "$trace_file" $gflag -z -F 5000 -- \
dd count=500 if=/dev/urandom of=/dev/null
}
check_compressed_stats() {
echo "Checking compressed events stats:"
- $perf_tool report -i $trace_file --header --stats | \
+ $perf_tool report -i "$trace_file" --header --stats | \
grep -E "(# compressed : Zstd,)|(COMPRESSED events:)"
}
check_compressed_output() {
- $perf_tool inject -i $trace_file -o $trace_file.decomp &&
- $perf_tool report -i $trace_file --stdio -F comm,dso,sym | head -n -3 > $trace_file.comp.output &&
- $perf_tool report -i $trace_file.decomp --stdio -F comm,dso,sym | head -n -3 > $trace_file.decomp.output &&
- diff $trace_file.comp.output $trace_file.decomp.output
+ $perf_tool inject -i "$trace_file" -o "$trace_file.decomp" &&
+ $perf_tool report -i "$trace_file" --stdio -F comm,dso,sym | head -n -3 > "$trace_file.comp.output" &&
+ $perf_tool report -i "$trace_file.decomp" --stdio -F comm,dso,sym | head -n -3 > "$trace_file.decomp.output" &&
+ diff "$trace_file.comp.output" "$trace_file.decomp.output"
}
skip_if_no_z_record || exit 2
collect_z_record && check_compressed_stats && check_compressed_output
err=$?
-rm -f $trace_file*
+rm -f "$trace_file*"
exit $err
--
2.39.1
next prev parent reply other threads:[~2023-07-09 18:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 18:27 [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 01/26] tools/perf/tests: Fix shellcheck warnings for trace+probe_vfs_getname.sh Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 02/26] tools/perf/tests: Fix shellcheck warning for probe_vfs_getname.sh testcase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 03/26] tools/perf/tests: Fix shellcheck warning for record_offcpu.sh testcase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 04/26] tools/perf/tests: Fix shellcheck issue for lock_contention.sh testcase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 05/26] tools/perf/tests: Fix shellcheck issue for stat_bpf_counters_cgrp.sh testcase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 06/26] tools/perf/tests: fix test_arm_spe_fork.sh signal case issues Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 07/26] tools/perf/tests: Fix unused variable references in stat+csv_summary.sh testcase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 08/26] tools/perf/tests: fix shellcheck warning for test_perf_data_converter_json.sh testcase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 09/26] tools/perf/tests: Fix shellcheck issue for stat_bpf_counters.sh testcase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 10/26] tools/perf/tests: Fix shellcheck issues in tests/shell/stat+shadow_stat.sh tetscase Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 11/26] tools/perf/tests: Fix shellcheck warning for asm_pure_loop.sh shell script Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 12/26] tools/perf/tests: Fix shellcheck warning for memcpy_thread_16k_10.sh " Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 13/26] tools/perf/tests: Fix shellcheck warning for probe.sh " Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 14/26] tools/perf/trace: Fix shellcheck issue for arch_errno_names.sh script Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 15/26] tools/perf: Fix shellcheck issue for check-headers.sh script Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 16/26] tools/perf/tests: Fix shellcheck warnings for thread_loop_check_tid_10.sh Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 17/26] tools/perf/tests: Fix shellcheck warnings for unroll_loop_thread_10.sh Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 18/26] tools/perf/tests: Fix shellcheck warnings for lib/probe_vfs_getname.sh Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 19/26] tools/perf/tests: Fix the shellcheck warnings in lib/waiting.sh Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 20/26] tools/perf/trace: Fix x86_arch_prctl.sh to address shellcheck warnings Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 21/26] tools/perf/arch/x86: Fix syscalltbl.sh " Athira Rajeev
2023-07-09 18:27 ` Athira Rajeev [this message]
2023-07-09 18:27 ` [PATCH V2 23/26] tools/shell/coresight: Fix shellcheck warning for thread_loop_check_tid_2.sh shell script Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 24/26] tools/perf/tests/shell/lib: Fix shellcheck warning for stat_output.sh " Athira Rajeev
2023-07-09 18:27 ` [PATCH V2 25/26] tools/perf/tests/shell: Fix shellcheck warning for stat+std_output.sh testcase Athira Rajeev
2023-07-09 18:28 ` [PATCH V2 26/26] tools/perf/tests: " Athira Rajeev
2023-07-19 6:17 ` [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts kajoljain
2023-07-19 17:46 ` Ian Rogers
2023-07-20 5:12 ` Athira Rajeev
2023-07-20 5:18 ` kajoljain
2023-07-25 5:50 ` Athira Rajeev
2023-07-28 19:04 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230709182800.53002-23-atrajeev@linux.vnet.ibm.com \
--to=atrajeev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=disgoel@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).