linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ze Gao <zegao2021@gmail.com>
Cc: acme@kernel.org, adrian.hunter@intel.com,
	alexander.shishkin@linux.intel.com, irogers@google.com,
	jolsa@kernel.org, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, mark.rutland@arm.com,
	mhiramat@kernel.org, mingo@redhat.com, namhyung@kernel.org,
	peterz@infradead.org, zegao@tencent.com
Subject: Re: [PATCH] perf sched: parse task state from tracepoint print format
Date: Fri, 11 Aug 2023 13:28:11 -0400	[thread overview]
Message-ID: <20230811132811.28b9b766@gandalf.local.home> (raw)
In-Reply-To: <20230810055023.67529-2-zegao@tencent.com>

On Thu, 10 Aug 2023 01:50:24 -0400
Ze Gao <zegao2021@gmail.com> wrote:

> Hi Steven,
> 
> I managed to build task state char map dynamically by parsing
> the tracepoint print format from data recorded by perf. And
> likewise for libtraceevent.
> 
> FYI, I tried TEP_PRINT_INFO but no shot. It turns out TEP_PRINT_INFO
> stills relies on libtraceevent (i.e., sched_switch_handler() in 
> plugin_sched_switch.c) and we need to parse the print format on our own.

There is a way to unload plugins:

	tep_unload_plugins(t->plugin_list, tep);

Hmm, I should add:

	tep_unload_plugin(tep, t->plugin_list, "plugin-name");

To unload a single plugin.

I it can also just override what the plugin does by calling:

static int sched_switch_handler(struct trace_seq *s,
				struct tep_record *record,
				struct tep_event *event, void *context)
{
	// do whatever you want.
}

	tep_register_event_handler(tep, -1, "sched", "sched_switch",
				   sched_switch_handler, NULL);

> 
> Anyway, it works now and I've tested on some perf.data in old formats
> but not cover all the kernel releases.
> 
> Thoughts?

I don't maintain the perf code. You'll have to talk with the perf
maintainers.

-- Steve

  parent reply	other threads:[~2023-08-11 17:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  8:33 [RFC PATCH v6 0/5] fix task state report from sched tracepoint Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 1/5] perf sched: sync state char array with the kernel Ze Gao
2023-08-03  9:09   ` Steven Rostedt
2023-08-03 10:29     ` Ze Gao
2023-08-03 12:25       ` Ze Gao
2023-08-03 12:39     ` Ze Gao
2023-08-03 15:10   ` Steven Rostedt
2023-08-04  2:21     ` Ze Gao
2023-08-04  2:38       ` Ze Gao
2023-08-04  3:19         ` Ze Gao
2023-08-04  3:41           ` Steven Rostedt
2023-08-10  5:50             ` Ze Gao
2023-08-10  6:07               ` [PATCH] perf sched: parse task state from tracepoint print format Ze Gao
2023-08-11 17:28               ` Steven Rostedt [this message]
2023-08-14  2:28                 ` Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 2/5] perf sched: reorganize sched-out task state report code Ze Gao
2023-08-03  9:10   ` Steven Rostedt
2023-08-03 12:37     ` Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 3/5] sched, tracing: reorganize fields of switch event struct Ze Gao
2023-08-03  8:53   ` Peter Zijlstra
2023-08-03 11:06     ` Ze Gao
2023-08-03  9:18   ` Steven Rostedt
2023-08-03  9:51     ` Peter Zijlstra
2023-08-03 14:45       ` Steven Rostedt
2023-08-03 12:54     ` Ze Gao
2023-08-03 12:57     ` Ze Gao
2023-08-23  2:52   ` kernel test robot
2023-08-03  8:33 ` [RFC PATCH v6 4/5] sched, tracing: add to report task state in symbolic chars Ze Gao
2023-08-03  8:59   ` Peter Zijlstra
2023-08-03 13:09     ` Ze Gao
2023-08-03  9:29   ` Steven Rostedt
2023-08-03 10:55     ` Ze Gao
2023-08-03  8:33 ` [RFC PATCH v6 5/5] perf sched: prefer to use prev_state_char introduced in sched_switch Ze Gao
2023-08-03  9:34   ` Steven Rostedt
2023-08-03 11:01     ` Ze Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230811132811.28b9b766@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=zegao2021@gmail.com \
    --cc=zegao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).