From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Guo Ren <guoren@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Huacai Chen <chenhuacai@kernel.org>,
Ming Wang <wangming01@loongson.cn>,
Eric Lin <eric.lin@sifive.com>,
Kan Liang <kan.liang@linux.intel.com>,
Sandipan Das <sandipan.das@amd.com>,
Ivan Babrou <ivan@cloudflare.com>,
Fangrui Song <maskray@google.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-csky@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 0/6] perf parse-regs: Refactor architecture functions
Date: Wed, 16 Aug 2023 10:07:15 +0800 [thread overview]
Message-ID: <20230816020715.GA135657@leoy-huanghe.lan> (raw)
In-Reply-To: <ZNvKjeFkXY8ezf9e@kernel.org>
On Tue, Aug 15, 2023 at 03:57:17PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Aug 15, 2023 at 03:52:38PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Aug 15, 2023 at 03:45:27PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Agreed, applied to perf-tools-next, sorry for the delay.
> > >
> > > Had to add this to make 'perf test python' to work. Please run 'perf
> > > test' before sending patches.
> >
> > One more, please also do a 'make -C tools/perf build-test', with it I
> > caught this:
> >
> > make_no_libunwind_O: cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH
> > cd . && make NO_LIBUNWIND=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.yeEGyQq2HR DESTDIR=/tmp/tmp.ITgoO16jjH
>
> +#include "util/env.h"
>
> As now we need it for perf_env__arch(ui->machine->env)
Sorry for inconvenience.
I saw this patch series has been picked into the branch:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf-tools-next
If want me to follow up, let me know. Thank you!
> > CC /tmp/tmp.yeEGyQq2HR/util/expr-flex.o
> > util/unwind-libdw.c: In function ‘memory_read’:
> > util/unwind-libdw.c:173:28: error: implicit declaration of function ‘perf_env__arch’ [-Werror=implicit-function-declaration]
> > 173 | const char *arch = perf_env__arch(ui->machine->env);
> > | ^~~~~~~~~~~~~~
> > util/unwind-libdw.c:173:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
> > util/unwind-libdw.c: In function ‘unwind__get_entries’:
> > util/unwind-libdw.c:258:28: error: initialization of ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
> > 258 | const char *arch = perf_env__arch(ui_buf.machine->env);
> > | ^~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > make[6]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:98: /tmp/tmp.yeEGyQq2HR/util/unwind-libdw.o] Error 1
> > make[6]: *** Waiting for unfinished jobs....
> > make[5]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:150: util] Error 2
> > make[4]: *** [Makefile.perf:662: /tmp/tmp.yeEGyQq2HR/perf-in.o] Error 2
> > make[4]: *** Waiting for unfinished jobs....
> > CC /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events.o
> > LD /tmp/tmp.yeEGyQq2HR/pmu-events/pmu-events-in.o
> > make[3]: *** [Makefile.perf:238: sub-make] Error 2
> > make[2]: *** [Makefile:70: all] Error 2
> > make[1]: *** [tests/make:337: make_no_libunwind_O] Error 1
> > make: *** [Makefile:103: build-test] Error 2
> > make: Leaving directory '/var/home/acme/git/perf-tools-next/tools/perf'
> >
> > real 1m29.784s
> > user 10m41.597s
> > sys 2m55.948s
> > ⬢[acme@toolbox perf-tools-next]$
> >
> > I'm trying to fix
>
> --
>
> - Arnaldo
next prev parent reply other threads:[~2023-08-16 2:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 1:45 [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Leo Yan
2023-06-06 1:45 ` [PATCH v2 1/6] perf parse-regs: Refactor arch register parsing functions Leo Yan
2023-06-06 1:45 ` [PATCH v2 2/6] perf parse-regs: Introduce functions perf_arch_reg_{ip|sp}() Leo Yan
2023-06-06 1:45 ` [PATCH v2 3/6] perf unwind: Use perf_arch_reg_{ip|sp}() to substitute macros Leo Yan
2023-06-06 1:45 ` [PATCH v2 4/6] perf parse-regs: Remove unused macros PERF_REG_{IP|SP} Leo Yan
2023-06-06 1:45 ` [PATCH v2 5/6] perf parse-regs: Remove PERF_REGS_{MAX|MASK} from common code Leo Yan
2023-06-06 1:45 ` [PATCH v2 6/6] perf parse-regs: Move out arch specific header from util/perf_regs.h Leo Yan
2023-07-12 22:37 ` [PATCH v2 0/6] perf parse-regs: Refactor architecture functions Ian Rogers
2023-08-15 18:24 ` Arnaldo Carvalho de Melo
2023-08-15 18:45 ` Arnaldo Carvalho de Melo
2023-08-15 18:52 ` Arnaldo Carvalho de Melo
2023-08-15 18:57 ` Arnaldo Carvalho de Melo
2023-08-16 2:07 ` Leo Yan [this message]
2023-08-16 11:46 ` Arnaldo Carvalho de Melo
2023-08-16 11:48 ` Arnaldo Carvalho de Melo
2023-08-17 9:23 ` Leo Yan
2023-08-17 9:12 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816020715.GA135657@leoy-huanghe.lan \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=chenhuacai@kernel.org \
--cc=eric.lin@sifive.com \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=ivan@cloudflare.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maskray@google.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=wangming01@loongson.cn \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).