From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-mm@kvack.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-perf-users@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, urezki@gmail.com,
hch@infradead.org, lstoakes@gmail.com
Subject: [RFC PATCH 1/4] perf: Convert perf_mmap_(alloc,free)_page to folios
Date: Mon, 21 Aug 2023 21:20:13 +0100 [thread overview]
Message-ID: <20230821202016.2910321-2-willy@infradead.org> (raw)
In-Reply-To: <20230821202016.2910321-1-willy@infradead.org>
Use the folio API to alloc & free memory. Also pass in the node ID
instead of the CPU ID since we already did that calculation in the
caller. And call numa_mem_id() instead of leaving the node ID as
-1 and having the MM call numa_mem_id() each time.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
kernel/events/ring_buffer.c | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c
index fb1e180b5f0a..cc90d5299005 100644
--- a/kernel/events/ring_buffer.c
+++ b/kernel/events/ring_buffer.c
@@ -770,7 +770,7 @@ void rb_free_aux(struct perf_buffer *rb)
#ifndef CONFIG_PERF_USE_VMALLOC
/*
- * Back perf_mmap() with regular GFP_KERNEL-0 pages.
+ * Back perf_mmap() with regular GFP_KERNEL pages.
*/
static struct page *
@@ -785,25 +785,23 @@ __perf_mmap_to_page(struct perf_buffer *rb, unsigned long pgoff)
return virt_to_page(rb->data_pages[pgoff - 1]);
}
-static void *perf_mmap_alloc_page(int cpu)
+static void *perf_mmap_alloc_page(int node)
{
- struct page *page;
- int node;
+ struct folio *folio;
- node = (cpu == -1) ? cpu : cpu_to_node(cpu);
- page = alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 0);
- if (!page)
+ folio = __folio_alloc_node(GFP_KERNEL | __GFP_ZERO, 0, node);
+ if (!folio)
return NULL;
- return page_address(page);
+ return folio_address(folio);
}
static void perf_mmap_free_page(void *addr)
{
- struct page *page = virt_to_page(addr);
+ struct folio *folio = virt_to_folio(addr);
- page->mapping = NULL;
- __free_page(page);
+ folio->mapping = NULL;
+ folio_put(folio);
}
struct perf_buffer *rb_alloc(int nr_pages, long watermark, int cpu, int flags)
@@ -818,17 +816,17 @@ struct perf_buffer *rb_alloc(int nr_pages, long watermark, int cpu, int flags)
if (order_base_2(size) > PAGE_SHIFT+MAX_ORDER)
goto fail;
- node = (cpu == -1) ? cpu : cpu_to_node(cpu);
+ node = (cpu == -1) ? numa_mem_id() : cpu_to_node(cpu);
rb = kzalloc_node(size, GFP_KERNEL, node);
if (!rb)
goto fail;
- rb->user_page = perf_mmap_alloc_page(cpu);
+ rb->user_page = perf_mmap_alloc_page(node);
if (!rb->user_page)
goto fail_user_page;
for (i = 0; i < nr_pages; i++) {
- rb->data_pages[i] = perf_mmap_alloc_page(cpu);
+ rb->data_pages[i] = perf_mmap_alloc_page(node);
if (!rb->data_pages[i])
goto fail_data_pages;
}
--
2.40.1
next prev parent reply other threads:[~2023-08-21 20:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 20:20 [RFC PATCH 0/4] Convert perf ringbuffer to folios Matthew Wilcox (Oracle)
2023-08-21 20:20 ` Matthew Wilcox (Oracle) [this message]
2023-08-23 7:28 ` [RFC PATCH 1/4] perf: Convert perf_mmap_(alloc,free)_page " Yin Fengwei
2023-08-27 7:33 ` Lorenzo Stoakes
2023-09-13 13:31 ` Peter Zijlstra
2023-09-22 20:19 ` Lorenzo Stoakes
2023-08-21 20:20 ` [RFC PATCH 2/4] mm: Add vmalloc_user_node() Matthew Wilcox (Oracle)
2023-09-13 13:32 ` Peter Zijlstra
2023-08-21 20:20 ` [RFC PATCH 3/4] perf: Use vmalloc_to_folio() Matthew Wilcox (Oracle)
2023-08-22 7:54 ` Zhu Yanjun
2023-08-23 7:30 ` Yin Fengwei
2023-08-23 12:16 ` Matthew Wilcox
2023-08-27 7:22 ` Lorenzo Stoakes
2023-08-21 20:20 ` [RFC PATCH 4/4] perf: Use folios for the aux ringbuffer & pagefault path Matthew Wilcox (Oracle)
2023-08-23 7:38 ` Yin Fengwei
2023-08-23 12:23 ` Matthew Wilcox
2023-08-23 12:45 ` Yin, Fengwei
2023-08-27 8:01 ` Lorenzo Stoakes
2023-08-27 11:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821202016.2910321-2-willy@infradead.org \
--to=willy@infradead.org \
--cc=acme@kernel.org \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).