From: Tero Kristo <tero.kristo@linux.intel.com>
To: dave.hansen@linux.intel.com, tglx@linutronix.de, x86@kernel.org,
bp@alien8.de
Cc: artem.bityutskiy@linux.intel.com, acme@kernel.org,
bpf@vger.kernel.org, namhyung@kernel.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
irogers@google.com, hpa@zytor.com, mark.rutland@arm.com,
jolsa@kernel.org, adrian.hunter@intel.com,
alexander.shishkin@linux.intel.com, peterz@infradead.org
Subject: [PATCH 2/2] perf/core: Allow reading package events from perf_event_read_local
Date: Wed, 23 Aug 2023 08:56:53 +0300 [thread overview]
Message-ID: <20230823055653.2964237-3-tero.kristo@linux.intel.com> (raw)
In-Reply-To: <20230823055653.2964237-1-tero.kristo@linux.intel.com>
Per-package perf events are typically registered with a single CPU only,
however they can be read across all the CPUs within the package.
Currently perf_event_read maps the event CPU according to the topology
information to avoid an unnecessary SMP call, however
perf_event_read_local deals with hard values and rejects a read with a
failure if the CPU is not the one exactly registered. Allow similar
mapping within the perf_event_read_local if the perf event in question
can support this.
This allows users like BPF code to read the package perf events properly
across different CPUs within a package.
Signed-off-by: Tero Kristo <tero.kristo@linux.intel.com>
---
kernel/events/core.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 78ae7b6f90fd..37db7c003b79 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -4528,6 +4528,7 @@ int perf_event_read_local(struct perf_event *event, u64 *value,
{
unsigned long flags;
int ret = 0;
+ int event_cpu;
/*
* Disabling interrupts avoids all counter scheduling (context
@@ -4551,15 +4552,19 @@ int perf_event_read_local(struct perf_event *event, u64 *value,
goto out;
}
+ /* Allow reading a per-package perf-event from local CPU also */
+ event_cpu = READ_ONCE(event->oncpu);
+ event_cpu = __perf_event_read_cpu(event, event_cpu);
+
/* If this is a per-CPU event, it must be for this CPU */
if (!(event->attach_state & PERF_ATTACH_TASK) &&
- event->cpu != smp_processor_id()) {
+ event_cpu != smp_processor_id()) {
ret = -EINVAL;
goto out;
}
/* If this is a pinned event it must be running on this CPU */
- if (event->attr.pinned && event->oncpu != smp_processor_id()) {
+ if (event->attr.pinned && event_cpu != smp_processor_id()) {
ret = -EBUSY;
goto out;
}
@@ -4569,7 +4574,7 @@ int perf_event_read_local(struct perf_event *event, u64 *value,
* or local to this CPU. Furthermore it means its ACTIVE (otherwise
* oncpu == -1).
*/
- if (event->oncpu == smp_processor_id())
+ if (event_cpu == smp_processor_id())
event->pmu->read(event);
*value = local64_read(&event->count);
--
2.25.1
prev parent reply other threads:[~2023-08-23 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 5:56 [PATCH 0/2] perf/x86: Package residency counter improvements Tero Kristo
2023-08-23 5:56 ` [PATCH 1/2] perf/x86/cstate: Allow reading the package statistics from local CPU Tero Kristo
2023-08-23 5:56 ` Tero Kristo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823055653.2964237-3-tero.kristo@linux.intel.com \
--to=tero.kristo@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).