From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@arm.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Kajol Jain <kjain@linux.ibm.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Rob Herring <robh@kernel.org>,
Gaosheng Cui <cuigaosheng1@huawei.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 00/18] Lazily load PMU data
Date: Wed, 23 Aug 2023 21:13:12 -0700 [thread overview]
Message-ID: <20230824041330.266337-1-irogers@google.com> (raw)
Lazily load PMU data both from sysfs and json files. Reorganize
json data to be more PMU oriented to facilitate this, for
example, json data is now sorted into arrays for their PMU.
In refactoring the code some changes were made to get rid of maximum
encoding sizes for events (256 bytes), with input files being directly
passed to the lex generated code. There is also a small event parse
error message improvement.
Some results from an Intel tigerlake laptop running Debian:
Binary size reduction of 5.3% or 552,864 bytes because the PMU
name no longer appears in the string or desc field.
stat -e cpu/cycles/ minor faults reduced from 1733 to 1667, open calls reduced
from 171 to 94.
stat default minor faults reduced from 1805 to 1717, open calls reduced
from 654 to 343.
Average PMU scanning reduced from 4720.641usec to 2927.293usec.
Average core PMU scanning reduced from 1004.658usec to 232.668usec
(4.3x faster).
v2: Add error path for failing strdup when allocating a format,
suggested by Arnaldo. Rebased on top of tmp.perf-tools-next
removing 8 patches. Added "perf jevents: Don't append Unit to
desc" to save yet more encoding json event space.
Ian Rogers (18):
perf pmu: Make the loading of formats lazy
perf pmu: Abstract alias/event struct
perf pmu-events: Add extra underscore to function names
perf jevents: Group events by PMU
perf parse-events: Improve error message for double setting
perf s390 s390_cpumcfdg_dump: Don't scan all PMUs
perf pmu-events: Reduce processed events by passing PMU
perf pmu-events: Add pmu_events_table__find_event
perf pmu: Parse sysfs events directly from a file
perf pmu: Prefer passing pmu to aliases list
perf pmu: Merge json events with sysfs at load time
perf pmu: Cache json events table
perf pmu: Lazily add json events
perf pmu: Scan type early to fail an invalid PMU quickly
perf pmu: Be lazy about loading event info files from sysfs
perf pmu: Lazily load sysfs aliases
perf jevents: Sort strings in the big C string to reduce faults
perf jevents: Don't append Unit to desc
tools/perf/arch/x86/util/intel-pt.c | 2 +-
tools/perf/bench/pmu-scan.c | 8 +-
tools/perf/builtin-list.c | 13 +-
tools/perf/pmu-events/empty-pmu-events.c | 49 +-
tools/perf/pmu-events/jevents.py | 312 +++++++--
tools/perf/pmu-events/pmu-events.h | 15 +-
tools/perf/tests/parse-events.c | 2 +-
tools/perf/tests/pmu-events.c | 148 +++--
tools/perf/tests/pmu.c | 2 +-
tools/perf/util/metricgroup.c | 10 +-
tools/perf/util/parse-events.c | 87 ++-
tools/perf/util/parse-events.h | 3 +-
tools/perf/util/pmu.c | 806 +++++++++++++++--------
tools/perf/util/pmu.h | 96 ++-
tools/perf/util/pmu.y | 20 +-
tools/perf/util/pmus.c | 230 +++----
tools/perf/util/s390-sample-raw.c | 50 +-
17 files changed, 1141 insertions(+), 712 deletions(-)
--
2.42.0.rc1.204.g551eb34607-goog
next reply other threads:[~2023-08-24 4:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 4:13 Ian Rogers [this message]
2023-08-24 4:13 ` [PATCH v2 01/18] perf pmu: Make the loading of formats lazy Ian Rogers
2023-08-24 4:13 ` [PATCH v2 02/18] perf pmu: Abstract alias/event struct Ian Rogers
2023-08-24 4:13 ` [PATCH v2 03/18] perf pmu-events: Add extra underscore to function names Ian Rogers
2023-08-24 4:13 ` [PATCH v2 04/18] perf jevents: Group events by PMU Ian Rogers
2023-08-29 15:28 ` James Clark
2023-08-29 15:34 ` Ian Rogers
2023-08-24 4:13 ` [PATCH v2 05/18] perf parse-events: Improve error message for double setting Ian Rogers
2023-08-24 4:13 ` [PATCH v2 06/18] perf s390 s390_cpumcfdg_dump: Don't scan all PMUs Ian Rogers
2023-08-24 13:59 ` Arnaldo Carvalho de Melo
2023-08-24 17:31 ` Ian Rogers
2023-08-25 8:19 ` Thomas Richter
2023-08-25 13:14 ` Ian Rogers
2023-08-25 14:39 ` Thomas Richter
2023-08-25 20:56 ` Arnaldo Carvalho de Melo
2023-08-25 22:56 ` Ian Rogers
2023-08-26 1:38 ` Arnaldo Carvalho de Melo
2023-08-26 6:28 ` Ian Rogers
2023-08-28 17:44 ` Arnaldo Carvalho de Melo
2023-08-28 17:53 ` Arnaldo Carvalho de Melo
2023-08-28 21:39 ` Arnaldo Carvalho de Melo
2023-08-29 0:59 ` Ian Rogers
2023-08-29 9:20 ` Jing Zhang
2023-08-29 13:20 ` Arnaldo Carvalho de Melo
2023-08-29 11:28 ` Arnaldo Carvalho de Melo
2023-08-24 4:13 ` [PATCH v2 07/18] perf pmu-events: Reduce processed events by passing PMU Ian Rogers
2023-08-24 4:13 ` [PATCH v2 08/18] perf pmu-events: Add pmu_events_table__find_event Ian Rogers
2023-08-24 4:13 ` [PATCH v2 09/18] perf pmu: Parse sysfs events directly from a file Ian Rogers
2023-08-24 4:13 ` [PATCH v2 10/18] perf pmu: Prefer passing pmu to aliases list Ian Rogers
2023-08-24 4:13 ` [PATCH v2 11/18] perf pmu: Merge json events with sysfs at load time Ian Rogers
2023-08-24 4:13 ` [PATCH v2 12/18] perf pmu: Cache json events table Ian Rogers
2023-08-24 4:13 ` [PATCH v2 13/18] perf pmu: Lazily add json events Ian Rogers
2023-08-24 4:13 ` [PATCH v2 14/18] perf pmu: Scan type early to fail an invalid PMU quickly Ian Rogers
2023-08-24 4:13 ` [PATCH v2 15/18] perf pmu: Be lazy about loading event info files from sysfs Ian Rogers
2023-08-24 4:13 ` [PATCH v2 16/18] perf pmu: Lazily load sysfs aliases Ian Rogers
2023-08-24 4:13 ` [PATCH v2 17/18] perf jevents: Sort strings in the big C string to reduce faults Ian Rogers
2023-08-24 4:13 ` [PATCH v2 18/18] perf jevents: Don't append Unit to desc Ian Rogers
2023-08-24 14:52 ` [PATCH v2 00/18] Lazily load PMU data Arnaldo Carvalho de Melo
2023-08-24 18:01 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824041330.266337-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=cuigaosheng1@huawei.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).