From: Ian Rogers <irogers@google.com>
To: John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
Kajol Jain <kjain@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Ming Wang <wangming01@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Sean Christopherson <seanjc@google.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Wei Li <liwei391@huawei.com>
Subject: [PATCH v2 0/6] Fix missing caps, fix unnecessary casting/checking
Date: Thu, 24 Aug 2023 19:39:56 -0700 [thread overview]
Message-ID: <20230825024002.801955-1-irogers@google.com> (raw)
Wei Li <liwei391@huawei.com> reported an issue where writing PMU caps
for ARM was broken. Patch 1 addresses this issue.
Patch 2 removes unnecessary checks on a PMU's name by ensuring the
fake PMU has a name. Types are updated to have a const as a
consequence and a cleanup of the use of types is done for struct pmu's
variable name. This was motivated by the discussion:
https://lore.kernel.org/lkml/20230818171952.3719251-1-irogers@google.com/
Patches 3-5 repeat the const cleanup on struct pmu's name with the
variables id and config in struct pmu and struct parse_events_term
respectively. This is done for consistency with patch 2.
Patch 6 tidies casts around libslang and removes workarounds for
libslang support needed for a libslang older than 15 years - let's say
nobody cares about a libslang that is this old.
Ian Rogers (6):
perf header: Fix missing PMU caps
perf pmu: Remove logic for PMU name being NULL
perf parse-events: Make term's config const
perf pmu: Make id const and add missing free
perf build-id: Simplify build_id_cache__cachedir
perf tui slang: Tidy casts
tools/perf/arch/arm64/util/mem-events.c | 2 +-
tools/perf/arch/powerpc/util/mem-events.c | 6 ++--
tools/perf/arch/x86/util/mem-events.c | 8 ++---
tools/perf/arch/x86/util/pmu.c | 10 +++---
tools/perf/builtin-list.c | 2 +-
tools/perf/tests/pmu-events.c | 20 ++++++------
tools/perf/tests/pmu.c | 18 +++++------
tools/perf/ui/Build | 2 --
tools/perf/ui/browser.c | 6 ++--
tools/perf/ui/browsers/Build | 5 ---
tools/perf/ui/libslang.h | 20 +++---------
tools/perf/ui/tui/helpline.c | 2 +-
tools/perf/ui/tui/setup.c | 2 +-
tools/perf/ui/tui/util.c | 12 +++----
tools/perf/util/build-id.c | 6 ++--
tools/perf/util/env.c | 8 ++---
tools/perf/util/header.c | 39 ++++++++++-------------
tools/perf/util/mem-events.c | 16 +++++-----
tools/perf/util/mem-events.h | 2 +-
tools/perf/util/parse-events.c | 17 ++++------
tools/perf/util/parse-events.h | 6 ++--
tools/perf/util/parse-events.y | 2 +-
tools/perf/util/pmu.c | 19 ++++++-----
tools/perf/util/pmu.h | 10 +++---
24 files changed, 105 insertions(+), 135 deletions(-)
--
2.42.0.rc2.253.gd59a3bf2b4-goog
next reply other threads:[~2023-08-25 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 2:39 Ian Rogers [this message]
2023-08-25 2:39 ` [PATCH v2 1/6] perf header: Fix missing PMU caps Ian Rogers
2023-08-25 2:39 ` [PATCH v2 2/6] perf pmu: Remove logic for PMU name being NULL Ian Rogers
2023-08-25 2:39 ` [PATCH v2 3/6] perf parse-events: Make term's config const Ian Rogers
2023-08-25 2:40 ` [PATCH v2 4/6] perf pmu: Make id const and add missing free Ian Rogers
2023-08-25 2:40 ` [PATCH v2 5/6] perf build-id: Simplify build_id_cache__cachedir Ian Rogers
2023-08-25 2:40 ` [PATCH v2 6/6] perf tui slang: Tidy casts Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825024002.801955-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kprateek.nayak@amd.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=wangming01@loongson.cn \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).