* [PATCH] powerpc/perf/hv-24x7: Update domain value check
@ 2023-08-25 5:56 Kajol Jain
2023-09-21 9:24 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Kajol Jain @ 2023-08-25 5:56 UTC (permalink / raw)
To: mpe
Cc: atrajeev, linux-kernel, linux-perf-users, maddy, disgoel,
linuxppc-dev, kjain, Krishan Gopal Sarawast
Valid domain value is in range 1 to HV_PERF_DOMAIN_MAX.
Current code has check for domain value greater than or
equal to HV_PERF_DOMAIN_MAX. But the check for domain value 0
is missing.
Fix this issue by adding check for domain value 0.
Fixes: ebd4a5a3ebd9 ("powerpc/perf/hv-24x7: Minor improvements")
Reported-by: Krishan Gopal Sarawast <krishang@linux.vnet.ibm.com>
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
---
arch/powerpc/perf/hv-24x7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
index 317175791d23..644881cc1c00 100644
--- a/arch/powerpc/perf/hv-24x7.c
+++ b/arch/powerpc/perf/hv-24x7.c
@@ -1418,7 +1418,7 @@ static int h_24x7_event_init(struct perf_event *event)
}
domain = event_get_domain(event);
- if (domain >= HV_PERF_DOMAIN_MAX) {
+ if (domain == 0 || domain >= HV_PERF_DOMAIN_MAX) {
pr_devel("invalid domain %d\n", domain);
return -EINVAL;
}
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/perf/hv-24x7: Update domain value check
2023-08-25 5:56 [PATCH] powerpc/perf/hv-24x7: Update domain value check Kajol Jain
@ 2023-09-21 9:24 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2023-09-21 9:24 UTC (permalink / raw)
To: Kajol Jain
Cc: atrajeev, linux-kernel, linux-perf-users, maddy, disgoel,
linuxppc-dev, Krishan Gopal Sarawast
On Fri, 25 Aug 2023 11:26:01 +0530, Kajol Jain wrote:
> Valid domain value is in range 1 to HV_PERF_DOMAIN_MAX.
> Current code has check for domain value greater than or
> equal to HV_PERF_DOMAIN_MAX. But the check for domain value 0
> is missing.
> Fix this issue by adding check for domain value 0.
>
>
> [...]
Applied to powerpc/fixes.
[1/1] powerpc/perf/hv-24x7: Update domain value check
https://git.kernel.org/powerpc/c/4ff3ba4db5943cac1045e3e4a3c0463ea10f6930
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-21 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 5:56 [PATCH] powerpc/perf/hv-24x7: Update domain value check Kajol Jain
2023-09-21 9:24 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).